286b15db78: BUG:KASAN:wild-memory-access_in_t
Quoted 13 lines · Hillf Danton
Quoted 13 lines
+------------------------------------------+------------+------------+ | | dfd001e50c | 286b15db78 | +------------------------------------------+------------+------------+ | boot_successes | 14 | 0 | | boot_failures | 0 | 16 | | BUG:KASAN:wild-memory-access_in_t | 0 | 16 | | general_protection_fault:#[##] | 0 | 16 | | RIP:try_module_get | 0 | 16 | | Kernel_panic-not_syncing:Fatal_exception | 0 | 16 | +------------------------------------------+------------+------------+
Quoted 6 lines
Quoted 6 lines
If you fix the issue, kindly add following tag
Reported-by kernel test robot <[email protected]>[ 2.801166] BUG: KASAN: wild-memory-access in try_module_get+0x78/0x1bf [ 2.803334] Read of size 4 at addr 6b6b6b6b6b6b6b6b by task swapper/0
Yuck.
Quoted 3 lines
Quoted 1 line
Try to pump up module after checking it is valid only if .owner =
THIS_MODULEdoes not help in the case of hpet.
Errrm?
Quoted 10 lines
Hillf
--- kernel/time/tick-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/time/tick-common.c +0
-0
kernel/time/tick-common.c void tick_check_new_device(struct clock_event_device *newdev) · line 314
Quoted 5 lines
kernel/time/tick-common.c +1
-1@@ -311,7 +311,7 @@ void tick_check_new_device(struct clock_event_device *newdev)if (!tick_check_preferred (curdev, newdev)) goto out_bc; -if (!try_module_get (newdev->owner)) +if (newdev->owner && !try_module_get (newdev->owner))
How does that prevent the above? That's not about a NULL pointer. Its simply uninitialized memory.
Aside that the check is pointless as try_module_get() has a NULL pointer check inside already.
Thanks,
tglx