arm64: tegra: A few device-tree fixes
Subsystems (3)
Jon Hunter
maintainercover arm64: tegra: A few device-tree fixes
Here are a few device-tree fixes for Tegra210 GPU regulator and AGIC.
Jon Hunter (3):
arm64: tegra: Fix AGIC register range
arm64: tegra: Update Jetson TX1 GPU regulator timings
arm64: tegra: Fix Jetson Nano GPU regulator
.../arm64/boot/dts/nvidia/tegra210-p2180.dtsi | 3 ++- .../boot/dts/nvidia/tegra210-p3450-0000.dts | 21 +++++++++++-------- arch/arm64/boot/dts/nvidia/tegra210.dtsi | 2 +- 3 files changed, 15 insertions(+), 11 deletions(-)
Signature · 1 line
2.17.1
Jon Hunter
maintainerPATCH 1/3 arm64: tegra: Fix AGIC register range
The Tegra AGIC interrupt controller is an ARM GIC400 interrupt controller. Per the ARM GIC device-tree binding, the first address region is for the GIC distributor registers and the second address region is for the GIC CPU interface registers. The address space for the distributor registers is 4kB, but currently this is incorrectly defined as 8kB for the Tegra AGIC and overlaps with the CPU interface registers. Correct the address space for the distributor to be 4kB.
--- arch/arm64/boot/dts/nvidia/tegra210.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/nvidia/tegra210.dtsi +1 -1
@@ -1258,7 +1258,7 @@ compatible = "nvidia,tegra210-agic"; #interrupt-cells = <3>; interrupt-controller; - reg = <0x702f9000 0x2000>, + reg = <0x702f9000 0x1000>, <0x702fa000 0x2000>; interrupts = <GIC_SPI 102 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>; clocks = <&tegra_car TEGRA210_CLK_APE>;
Signature · 1 line
2.17.1
Jon Hunter
maintainerPATCH 2/3 arm64: tegra: Update Jetson TX1 GPU regulator timings
In reply to Jon HunterThe GPU regulator enable ramp delay for Jetson TX1 is set to 1ms which not sufficient because the enable ramp delay has been measured to be greater than 1ms. Furthermore, the downstream kernels released by NVIDIA for Jetson TX1 are using a enable ramp delay 2ms and a settling delay of 160us. Update the GPU regulator enable ramp delay for Jetson TX1 to be 2ms and add a settling delay of 160us.
--- arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi +2 -1
@@ -341,7 +341,8 @@ regulator-max-microvolt = <1320000>; enable-gpios = <&pmic 6 GPIO_ACTIVE_HIGH>; regulator-ramp-delay = <80>; - regulator-enable-ramp-delay = <1000>; + regulator-enable-ramp-delay = <2000>; + regulator-settling-time-us = <160>; }; }; };
Signature · 1 line
2.17.1
Jon Hunter
maintainerPATCH 3/3 arm64: tegra: Fix Jetson Nano GPU regulator
In reply to Jon HunterThere are a few issues with the GPU regulator defined for Jetson Nano which are:
1. The GPU regulator is a PWM based regulator and not a fixed voltage regulator.
2. The output voltages for the GPU regulator are not correct.
3. The regulator enable ramp delay is too short for the regulator and needs to be increased. 2ms should be sufficient.
4. This is the same regulator used on Jetson TX1 and so make the ramp delay and settling time the same as Jetson TX1.
--- .../boot/dts/nvidia/tegra210-p3450-0000.dts | 21 +++++++++++-------- 1 file changed, 12 insertions(+), 9 deletions(-)
arch/arm64/boot/dts/nvidia/tegra210-p3450-0000.dts +12 -9
@@ -88,6 +88,10 @@ status = "okay"; }; + pwm@7000a000 { + status = "okay"; + }; + i2c@7000c500 { status = "okay"; clock-frequency = <100000>;
@@ -664,17 +668,16 @@ }; vdd_gpu: regulator@6 { - compatible = "regulator-fixed"; + compatible = "pwm-regulator"; reg = <6>; - + pwms = <&pwm 1 4880>; regulator-name = "VDD_GPU"; - regulator-min-microvolt = <5000000>; - regulator-max-microvolt = <5000000>; - regulator-enable-ramp-delay = <250>; - - gpio = <&pmic 6 GPIO_ACTIVE_HIGH>; - enable-active-high; - + regulator-min-microvolt = <710000>; + regulator-max-microvolt = <1320000>; + regulator-ramp-delay = <80>; + regulator-enable-ramp-delay = <2000>; + regulator-settling-time-us = <160>; + enable-gpios = <&pmic 6 GPIO_ACTIVE_HIGH>; vin-supply = <&vdd_5v0_sys>; }; };
Signature · 1 line
2.17.1
Thierry Reding
AppliedRe: [PATCH 1/3] arm64: tegra: Fix AGIC register range
In reply to Jon HunterQuoted 8 lines · Jon Hunter
The Tegra AGIC interrupt controller is an ARM GIC400 interrupt controller. Per the ARM GIC device-tree binding, the first address region is for the GIC distributor registers and the second address region is for the GIC CPU interface registers. The address space for the distributor registers is 4kB, but currently this is incorrectly defined as 8kB for the Tegra AGIC and overlaps with the CPU interface registers. Correct the address space for the distributor to be 4kB.
Quoted 5 lines
Signed-off-by Jon Hunter <[email protected]>--- arch/arm64/boot/dts/nvidia/tegra210.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-5.3/arm64/dt, though I also added the following Fixes:
line:
Thanks,
Thierry
Thierry Reding
AppliedRe: [PATCH 2/3] arm64: tegra: Update Jetson TX1 GPU regulator timings
In reply to Jon HunterQuoted 7 lines · Jon Hunter
The GPU regulator enable ramp delay for Jetson TX1 is set to 1ms which not sufficient because the enable ramp delay has been measured to be greater than 1ms. Furthermore, the downstream kernels released by NVIDIA for Jetson TX1 are using a enable ramp delay 2ms and a settling delay of 160us. Update the GPU regulator enable ramp delay for Jetson TX1 to be 2ms and add a settling delay of 160us.
Quoted 5 lines
Signed-off-by Jon Hunter <[email protected]>--- arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Applied to for-5.3/arm64/dt, and I added this Fixes: line:
Thanks,
Thierry
Thierry Reding
AppliedRe: [PATCH 3/3] arm64: tegra: Fix Jetson Nano GPU regulator
In reply to Jon HunterQuoted 11 lines · Jon Hunter
There are a few issues with the GPU regulator defined for Jetson Nano which are:
1. The GPU regulator is a PWM based regulator and not a fixed voltage regulator.
2. The output voltages for the GPU regulator are not correct.
3. The regulator enable ramp delay is too short for the regulator and needs to be increased. 2ms should be sufficient.
4. This is the same regulator used on Jetson TX1 and so make the ramp delay and settling time the same as Jetson TX1.
Quoted 5 lines
Signed-off-by Jon Hunter <[email protected]>--- .../boot/dts/nvidia/tegra210-p3450-0000.dts | 21 +++++++++++-------- 1 file changed, 12 insertions(+), 9 deletions(-)
Applied to for-5.3/arm64/dt and added the following Fixes: line:
Thanks,
Thierry