staging: rtl8188eu: cleanup lines ending with a '('
PATCH 1/2 staging: rtl8188eu: cleanup lines ending with a '('
Cleanup checkpatch issues in usb_halinit.c.
CHECK: Lines should not end with a '('
Signed-off-by Michael Straube <[email protected]>
--- drivers/staging/rtl8188eu/hal/usb_halinit.c | 21 +++++---------------- 1 file changed, 5 insertions(+), 16 deletions(-)
drivers/staging/rtl8188eu/hal/usb_halinit.c +5 -16
@@ -469,10 +469,7 @@ static void usb_AggSettingTxUpdate(struct adapter *Adapter)* *--------------------------------------------------------------------------- */ -static void -usb_AggSettingRxUpdate ( -struct adapter *Adapter - ) +static void usb_AggSettingRxUpdate (struct adapter *Adapter) {struct hal_data_8188e *haldata = Adapter->HalData;u8 valueDMA;
@@ -1044,10 +1041,7 @@ static void Hal_EfuseParseMACAddr_8188EU(struct adapter *adapt, u8 *hwinfo, bool eeprom->mac_addr)); } -static void -readAdapterInfo_8188EU ( -struct adapter *adapt - ) +static void readAdapterInfo_8188EU (struct adapter *adapt) {struct eeprom_priv *eeprom =GET_EEPROM_EFUSE_PRIV (adapt);
@@ -1067,9 +1061,7 @@ readAdapterInfo_8188EU(Hal_ReadThermalMeter_88E (adapt, eeprom->efuse_eeprom_data, eeprom->bautoload_fail_flag); } -static void _ReadPROMContent ( -struct adapter *Adapter - ) +static void _ReadPROMContent (struct adapter *Adapter) {struct eeprom_priv *eeprom =GET_EEPROM_EFUSE_PRIV (Adapter);u8 eeValue;
@@ -1782,11 +1774,8 @@ void rtw_hal_get_hwreg(struct adapter *Adapter, u8 variable, u8 *val)/* Description: */ /* Query setting of specified variable. */ /* */ -u8 rtw_hal_get_def_var ( -struct adapter *Adapter, -enum hal_def_variable eVariable, -void *pValue - ) +u8 rtw_hal_get_def_var (struct adapter *Adapter,enum hal_def_variable eVariable, +void *pValue) {struct hal_data_8188e *haldata = Adapter->HalData;u8 bResult = _SUCCESS;
Signature · 1 line
2.22.0
PATCH 2/2 staging: rtl8188eu: remove hal_init_macaddr()
Function hal_init_macaddr() just calls rtw_hal_set_hwreg(). Use rtw_hal_set_hwreg() directly and remove hal_init_macaddr().
Signed-off-by Michael Straube <[email protected]>
--- drivers/staging/rtl8188eu/hal/hal_com.c | 6 ------ drivers/staging/rtl8188eu/hal/usb_halinit.c | 3 ++- drivers/staging/rtl8188eu/include/hal_com.h | 1 - 3 files changed, 2 insertions(+), 8 deletions(-)
drivers/staging/rtl8188eu/hal/hal_com.c +0 -6
@@ -283,9 +283,3 @@ bool hal_mapping_out_pipe(struct adapter *adapter, u8 numoutpipe) }return result; } - -void hal_init_macaddr (struct adapter *adapter) -{ -rtw_hal_set_hwreg (adapter,HW_VAR_MAC_ADDR , - adapter->eeprompriv.mac_addr); -}
drivers/staging/rtl8188eu/hal/usb_halinit.c +2 -1
@@ -746,7 +746,8 @@ u32 rtl8188eu_hal_init(struct adapter *Adapter)_InitDriverInfoSize (Adapter,DRVINFO_SZ );_InitInterrupt (Adapter); -hal_init_macaddr (Adapter);/* set mac_address */ +rtw_hal_set_hwreg (Adapter,HW_VAR_MAC_ADDR , + Adapter->eeprompriv.mac_addr);_InitNetworkType (Adapter);/* set msr */ _InitWMACSetting (Adapter);_InitAdaptiveCtrl (Adapter);
drivers/staging/rtl8188eu/include/hal_com.h +0 -1
@@ -148,5 +148,4 @@ void hal_set_brate_cfg(u8 *brates, u16 *rate_cfg);bool hal_mapping_out_pipe (struct adapter *adapter,u8 numoutpipe); -void hal_init_macaddr (struct adapter *adapter);#endif /* __HAL_COMMON_H__ */
Signature · 1 line
2.22.0