Skip to contentSkip to conversation

efibootmgr: Pass correct flags to compiler from pkg-config

PATCH Superseded Khem Raj 2 participants 3 messages Jun 24, 2019 – Jun 25, 2019

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 efibootmgr: Pass correct flags to compiler from pkg-config

efivar.h is in usr/include/efirvar directory so it should be added to include search path via -I to compiler cmdline to fix

make[1]: *** No rule to make target 'efivar.h', needed by 'efibootmgr.o'. Stop. | make[1]: *** Waiting for unfinished jobs....

---
 meta/recipes-bsp/efibootmgr/efibootmgr_17.bb | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
meta/recipes-bsp/efibootmgr/efibootmgr_17.bb +1 -2
index 0e5a81e316..2f8fa34ee7 100644
@@ -22,8 +22,7 @@ inherit pkgconfig
 # The directory under the ESP that the default bootloader is found in.  When
 # wic uses a subdirectory, this should use the same one too.
 EFIDIR ?= "/"
-
-EXTRA_OEMAKE += "'EFIDIR=${EFIDIR}'"
+EXTRA_OEMAKE += "'EFIDIR=${EFIDIR}' 'CFLAGS=${CFLAGS} `pkg-config --cflags efivar`'"
 
 CFLAGS += " -Wno-error"
 
Signature · 1 line
2.22.0
#1 lore raw

So why does this build for me?

Ross

Quoted 34 lines · Khem Raj

efivar.h is in usr/include/efirvar directory so it should be added to include search path via -I to compiler cmdline to fix

make[1]: *** No rule to make target 'efivar.h', needed by 'efibootmgr.o'. Stop. | make[1]: *** Waiting for unfinished jobs....

---
 meta/recipes-bsp/efibootmgr/efibootmgr_17.bb | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
meta/recipes-bsp/efibootmgr/efibootmgr_17.bb +1 -3
index 0e5a81e316..2f8fa34ee7 100644
@@ -22,8 +22,7 @@ inherit pkgconfig
 # The directory under the ESP that the default bootloader is found in.  When
 # wic uses a subdirectory, this should use the same one too.
 EFIDIR ?= "/"
-
-EXTRA_OEMAKE += "'EFIDIR=${EFIDIR}'"
+EXTRA_OEMAKE += "'EFIDIR=${EFIDIR}' 'CFLAGS=${CFLAGS} `pkg-config --cflags efivar`'"
 
 CFLAGS += " -Wno-error"
 
--

2.22.0

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

author
#2 lore raw
Quoted 2 lines · Ross

So why does this build for me?

This happens when TOOLCHAIN = "clang" which is when using meta-clang when using TOOLCHAIN = "gcc" all works

Quoted 38 lines

Ross

Quoted 34 lines · Khem Raj

efivar.h is in usr/include/efirvar directory so it should be added to include search path via -I to compiler cmdline to fix

make[1]: *** No rule to make target 'efivar.h', needed by 'efibootmgr.o'. Stop. | make[1]: *** Waiting for unfinished jobs....

---
 meta/recipes-bsp/efibootmgr/efibootmgr_17.bb | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
meta/recipes-bsp/efibootmgr/efibootmgr_17.bb +1 -3
index 0e5a81e316..2f8fa34ee7 100644
@@ -22,8 +22,7 @@ inherit pkgconfig
 # The directory under the ESP that the default bootloader is found in.  When
 # wic uses a subdirectory, this should use the same one too.
 EFIDIR ?= "/"
-
-EXTRA_OEMAKE += "'EFIDIR=${EFIDIR}'"
+EXTRA_OEMAKE += "'EFIDIR=${EFIDIR}' 'CFLAGS=${CFLAGS} `pkg-config --cflags efivar`'"
 
 CFLAGS += " -Wno-error"
 
--

2.22.0

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core