Skip to contentSkip to conversation

arm64: dts: meson-g12a: add missing dwc2 phy-names

PATCH In review Neil Armstrong 2 participants 2 messages Jun 25, 2019 – Jun 28, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: meson-g12a: add missing dwc2 phy-names

The G12A USB2 OTG capable PHY uses a 8bit large UTMI bus, and the OTG controller gets the PHY but width by probing the associated phy.

By default it will use 16bit wide settings if a phy is not specified, in our case we specified the phy, but not the phy-names.

The dwc2 bindings specifies that if phys is present, phy-names shall be "usb2-phy".

Adding phy-names = "usb2-phy" solves the OTG PHY bus configuration.

Fixes 9baf7d6be730 ("arm64: dts: meson: g12a: Add G12A USB nodes")
---
 arch/arm64/boot/dts/amlogic/meson-g12a.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/amlogic/meson-g12a.dtsi +1 -0
index f8d43e3dcf20..1785552d450c 100644
@@ -2386,6 +2386,7 @@
 				clocks = <&clkc CLKID_USB1_DDR_BRIDGE>;
 				clock-names = "ddr";
 				phys = <&usb2_phy1>;
+				phy-names = "usb2-phy";
 				dr_mode = "peripheral";
 				g-rx-fifo-size = <192>;
 				g-np-tx-fifo-size = <128>;
Signature · 1 line
2.21.0
maintainer
#1 lore raw
Quoted 6 lines · Neil Armstrong

The G12A USB2 OTG capable PHY uses a 8bit large UTMI bus, and the OTG controller gets the PHY but width by probing the associated phy.

By default it will use 16bit wide settings if a phy is not specified, in our case we specified the phy, but not the phy-names.

Quoted 7 lines

The dwc2 bindings specifies that if phys is present, phy-names shall be "usb2-phy".

Adding phy-names = "usb2-phy" solves the OTG PHY bus configuration.

Fixes 9baf7d6be730 ("arm64: dts: meson: g12a: Add G12A USB nodes")

Queuing for v5.3-rc,

Thanks,

Kevin