Skip to contentSkip to conversation

libnotify: Remove obsolete dependency on dbus-glib

PATCH In review Adrian Bunk 2 participants 3 messages Jun 25, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libnotify: Remove obsolete dependency on dbus-glib

Upstream stopped using it in 2010.

---
 meta/recipes-gnome/libnotify/libnotify_0.7.8.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-gnome/libnotify/libnotify_0.7.8.bb +1 -1
index 82c137ca33..1c9084d919 100644
@@ -4,7 +4,7 @@ SECTION = "libs"
 LICENSE = "LGPLv2.1"
 LIC_FILES_CHKSUM = "file://COPYING;md5=7fbc338309ac38fefcd64b04bb903e34"
 
-DEPENDS = "dbus gtk+3 dbus-glib"
+DEPENDS = "dbus gtk+3 glib-2.0"
 
 inherit gnomebase gtk-doc distro_features_check gobject-introspection
 # depends on gtk+3
Signature · 1 line
2.17.1
#1 lore raw
Quoted 13 lines · Adrian Bunk

Upstream stopped using it in 2010.

---
  meta/recipes-gnome/libnotify/libnotify_0.7.8.bb | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-gnome/libnotify/libnotify_0.7.8.bb +0 -0
index 82c137ca33..1c9084d919 100644

meta/recipes-gnome/libnotify/libnotify_0.7.8.bb SECTION = "libs" · line 10

Quoted 8 lines
meta/recipes-gnome/libnotify/libnotify_0.7.8.bb +1 -1
@@ -4,7 +4,7 @@ SECTION = "libs"
  LICENSE = "LGPLv2.1"
  LIC_FILES_CHKSUM = "file://COPYING;md5=7fbc338309ac38fefcd64b04bb903e34"
 
-DEPENDS = "dbus gtk+3 dbus-glib"
+DEPENDS = "dbus gtk+3 glib-2.0"
 
  inherit gnomebase gtk-doc distro_features_check gobject-introspection
  # depends on gtk+3

Nice.

Are you doing a manual inspection and analysis or something more automated that you can share as a script/workflow?

Signature · 2 lines
# Randy MacLeod
# Wind River Linux
#2 lore raw
Quoted 23 lines · Randy MacLeod
Quoted 12 lines · Adrian Bunk

Upstream stopped using it in 2010.

---
  meta/recipes-gnome/libnotify/libnotify_0.7.8.bb | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-gnome/libnotify/libnotify_0.7.8.bb +0 -0
index 82c137ca33..1c9084d919 100644

meta/recipes-gnome/libnotify/libnotify_0.7.8.bb SECTION = "libs" · line 9

Quoted 7 lines
meta/recipes-gnome/libnotify/libnotify_0.7.8.bb +1 -1
@@ -4,7 +4,7 @@ SECTION = "libs"
  LICENSE = "LGPLv2.1"
  LIC_FILES_CHKSUM = "file://COPYING;md5=7fbc338309ac38fefcd64b04bb903e34"
-DEPENDS = "dbus gtk+3 dbus-glib"
+DEPENDS = "dbus gtk+3 glib-2.0"
  inherit gnomebase gtk-doc distro_features_check gobject-introspection
  # depends on gtk+3
 

Nice.

Quoted 2 lines

Are you doing a manual inspection and analysis or something more automated that you can share as a script/workflow?

Manual.

I was curious what it would take to remove dbus-glib from oe-core. This doesn't seem to be easy right now, but these were some trivial cases where all that was needed was to remove the dependency.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed