PCI: imx: Allow iMX PCIe driver on iMX6SX
Subsystems (2)
PATCH 1/1 PCI: imx: Allow iMX PCIe driver on iMX6SX
The driver supports iMX6SX, align the Kconfig file with the driver.
--- drivers/pci/controller/dwc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/controller/dwc/Kconfig +1 -1
@@ -90,7 +90,7 @@ config PCI_EXYNOS config PCI_IMX6 bool "Freescale i.MX6/7/8 PCIe controller" - depends on SOC_IMX6Q || SOC_IMX7D || (ARM64 && ARCH_MXC) || COMPILE_TEST + depends on SOC_IMX6SX || SOC_IMX6Q || SOC_IMX7D || (ARM64 && ARCH_MXC) || COMPILE_TEST depends on PCI_MSI_IRQ_DOMAIN select PCIE_DW_HOST
Signature · 1 line
2.20.1
Hi Marek,
Am Sonntag, den 30.06.2019, 22:53 +0200 schrieb Marek Vasut:
Quoted 1 line
The driver supports iMX6SX, align the
Kconfigfile with the driver.
The patch "PCI: Kconfig: Simplify PCI_IMX6 depends on", which will hopefully hit mainline pretty soon now after it got lost in the cracks of my inbox for far too long, is a more complete solution to the same problem.
Regards,
Lucas
Quoted 25 lines
Signed-off-by Marek Vasut <[email protected]>Cc Bjorn Helgaas <[email protected]>Cc Lorenzo Pieralisi <[email protected]>Cc Lucas Stach <[email protected]>Cc Richard Zhu <[email protected]>Cc Sasha Levin <[email protected]>Cc Sven Van Asbroeck <[email protected]>Cc Trent Piepho <[email protected]>---
drivers/pci/controller/dwc/Kconfig | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/pci/controller/dwc/Kconfig +0
-0@@ -90,7 +90,7 @@ config PCI_EXYNOS
configPCI_IMX6
bool "Freescale i.MX6/7/8 PCIe controller"drivers/pci/controller/dwc/Kconfig +1
-1- depends on SOC_IMX6Q || SOC_IMX7D || (ARM64 && ARCH_MXC) || COMPILE_TEST + depends on SOC_IMX6SX || SOC_IMX6Q || SOC_IMX7D || (ARM64 && ARCH_MXC) || COMPILE_TESTdepends on
PCI_MSI_IRQ_DOMAINselectPCIE_DW_HOST
Quoted 9 lines · Lucas Stach
Hi Marek,
Am Sonntag, den 30.06.2019, 22:53 +0200 schrieb Marek Vasut:
Quoted 1 line
The driver supports iMX6SX, align the
Kconfigfile with the driver.The patch "PCI:
Kconfig: SimplifyPCI_IMX6depends on", which will hopefully hit mainline pretty soon now after it got lost in the cracks of my inbox for far too long, is a more complete solution to the same problem.
Is it ? Some of the SoCs where that other patch enables the driver do not even have a PCIe IP in it, it feels like a heavy-handed approach to me.
Quoted 25 lines
Quoted 25 lines
Signed-off-by Marek Vasut <[email protected]>Cc Bjorn Helgaas <[email protected]>Cc Lorenzo Pieralisi <[email protected]>Cc Lucas Stach <[email protected]>Cc Richard Zhu <[email protected]>Cc Sasha Levin <[email protected]>Cc Sven Van Asbroeck <[email protected]>Cc Trent Piepho <[email protected]>---
drivers/pci/controller/dwc/Kconfig | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/pci/controller/dwc/Kconfig +0
-0@@ -90,7 +90,7 @@ config PCI_EXYNOS
configPCI_IMX6
bool "Freescale i.MX6/7/8 PCIe controller"drivers/pci/controller/dwc/Kconfig +1
-1- depends on SOC_IMX6Q || SOC_IMX7D || (ARM64 && ARCH_MXC) || COMPILE_TEST + depends on SOC_IMX6SX || SOC_IMX6Q || SOC_IMX7D || (ARM64 && ARCH_MXC) || COMPILE_TESTdepends on
PCI_MSI_IRQ_DOMAINselectPCIE_DW_HOST
Signature · 2 lines
Best regards, Marek Vasut
Quoted 9 lines · Lucas Stach
Hi Marek,
Am Sonntag, den 30.06.2019, 22:53 +0200 schrieb Marek Vasut:
Quoted 1 line
The driver supports iMX6SX, align the
Kconfigfile with the driver.The patch "PCI:
Kconfig: SimplifyPCI_IMX6depends on", which will hopefully hit mainline pretty soon now after it got lost in the cracks of my inbox for far too long, is a more complete solution to the same problem.
If so can you ACK it
https://patchwork.ozlabs.org/patch/1054789/
please ? At the same time, I will drop this patch from the PCI queue.
Thanks,
Lorenzo
Quoted 28 lines
Regards,
LucasQuoted 25 lines
Signed-off-by Marek Vasut <[email protected]>Cc Bjorn Helgaas <[email protected]>Cc Lorenzo Pieralisi <[email protected]>Cc Lucas Stach <[email protected]>Cc Richard Zhu <[email protected]>Cc Sasha Levin <[email protected]>Cc Sven Van Asbroeck <[email protected]>Cc Trent Piepho <[email protected]>---
drivers/pci/controller/dwc/Kconfig | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/pci/controller/dwc/Kconfig +0
-0@@ -90,7 +90,7 @@ config PCI_EXYNOS
configPCI_IMX6
bool "Freescale i.MX6/7/8 PCIe controller"drivers/pci/controller/dwc/Kconfig +1
-1- depends on SOC_IMX6Q || SOC_IMX7D || (ARM64 && ARCH_MXC) || COMPILE_TEST + depends on SOC_IMX6SX || SOC_IMX6Q || SOC_IMX7D || (ARM64 && ARCH_MXC) || COMPILE_TESTdepends on
PCI_MSI_IRQ_DOMAINselectPCIE_DW_HOST
Hi Lorenzo,
Quoted 5 lines · Lorenzo Pieralisi
If so can you ACK it
https://patchwork.ozlabs.org/patch/1054789/
please ? At the same time, I will drop this patch from the PCI queue.
Lucas has already acked the patch from the patchwork link you shared.