Skip to contentSkip to conversation

PCI: imx: Allow iMX PCIe driver on iMX6SX

PATCH In review Marek Vasut 4 participants 5 messages Jun 30, 2019 – Jul 5, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PCI: imx: Allow iMX PCIe driver on iMX6SX

The driver supports iMX6SX, align the Kconfig file with the driver.

Cc Bjorn Helgaas <[email protected]>
Cc Lorenzo Pieralisi <[email protected]>
Cc Lucas Stach <[email protected]>
Cc Richard Zhu <[email protected]>
Cc Sasha Levin <[email protected]>
Cc Sven Van Asbroeck <[email protected]>
Cc Trent Piepho <[email protected]>
---
 drivers/pci/controller/dwc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/controller/dwc/Kconfig +1 -1
index a6ce1ee51b4c..3051387bf4f3 100644
@@ -90,7 +90,7 @@ config PCI_EXYNOS
 
 config PCI_IMX6
 	bool "Freescale i.MX6/7/8 PCIe controller"
-	depends on SOC_IMX6Q || SOC_IMX7D || (ARM64 && ARCH_MXC) || COMPILE_TEST
+	depends on SOC_IMX6SX || SOC_IMX6Q || SOC_IMX7D || (ARM64 && ARCH_MXC) || COMPILE_TEST
 	depends on PCI_MSI_IRQ_DOMAIN
 	select PCIE_DW_HOST
 
Signature · 1 line
2.20.1
#1 lore raw

Hi Marek,

Am Sonntag, den 30.06.2019, 22:53 +0200 schrieb Marek Vasut:

Quoted 1 line

The driver supports iMX6SX, align the Kconfig file with the driver.

The patch "PCI: Kconfig: Simplify PCI_IMX6 depends on", which will hopefully hit mainline pretty soon now after it got lost in the cracks of my inbox for far too long, is a more complete solution to the same problem.

Regards,
Lucas

Quoted 25 lines
Cc Bjorn Helgaas <[email protected]>
Cc Lorenzo Pieralisi <[email protected]>
Cc Lucas Stach <[email protected]>
Cc Richard Zhu <[email protected]>
Cc Sasha Levin <[email protected]>
Cc Sven Van Asbroeck <[email protected]>
Cc Trent Piepho <[email protected]>

---
 drivers/pci/controller/dwc/Kconfig | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/controller/dwc/Kconfig +0 -0
index a6ce1ee51b4c..3051387bf4f3 100644
@@ -90,7 +90,7 @@ config PCI_EXYNOS


 config PCI_IMX6
  bool "Freescale i.MX6/7/8 PCIe controller"

drivers/pci/controller/dwc/Kconfig +1 -1
-	depends on SOC_IMX6Q || SOC_IMX7D || (ARM64 && ARCH_MXC) || COMPILE_TEST
+	depends on SOC_IMX6SX || SOC_IMX6Q || SOC_IMX7D || (ARM64 && ARCH_MXC) || COMPILE_TEST

  depends on PCI_MSI_IRQ_DOMAIN select PCIE_DW_HOST

#2 lore raw
Quoted 9 lines · Lucas Stach

Hi Marek,

Am Sonntag, den 30.06.2019, 22:53 +0200 schrieb Marek Vasut:

Quoted 1 line

The driver supports iMX6SX, align the Kconfig file with the driver.

The patch "PCI: Kconfig: Simplify PCI_IMX6 depends on", which will hopefully hit mainline pretty soon now after it got lost in the cracks of my inbox for far too long, is a more complete solution to the same problem.

Is it ? Some of the SoCs where that other patch enables the driver do not even have a PCIe IP in it, it feels like a heavy-handed approach to me.

Quoted 25 lines
Quoted 25 lines
Cc Bjorn Helgaas <[email protected]>
Cc Lorenzo Pieralisi <[email protected]>
Cc Lucas Stach <[email protected]>
Cc Richard Zhu <[email protected]>
Cc Sasha Levin <[email protected]>
Cc Sven Van Asbroeck <[email protected]>
Cc Trent Piepho <[email protected]>

---
 drivers/pci/controller/dwc/Kconfig | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/controller/dwc/Kconfig +0 -0
index a6ce1ee51b4c..3051387bf4f3 100644
@@ -90,7 +90,7 @@ config PCI_EXYNOS


 config PCI_IMX6
  bool "Freescale i.MX6/7/8 PCIe controller"

drivers/pci/controller/dwc/Kconfig +1 -1
-	depends on SOC_IMX6Q || SOC_IMX7D || (ARM64 && ARCH_MXC) || COMPILE_TEST
+	depends on SOC_IMX6SX || SOC_IMX6Q || SOC_IMX7D || (ARM64 && ARCH_MXC) || COMPILE_TEST

  depends on PCI_MSI_IRQ_DOMAIN select PCIE_DW_HOST

Signature · 2 lines
Best regards,
Marek Vasut
#3 lore raw
In reply to Lucas Stach
Quoted 9 lines · Lucas Stach

Hi Marek,

Am Sonntag, den 30.06.2019, 22:53 +0200 schrieb Marek Vasut:

Quoted 1 line

The driver supports iMX6SX, align the Kconfig file with the driver.

The patch "PCI: Kconfig: Simplify PCI_IMX6 depends on", which will hopefully hit mainline pretty soon now after it got lost in the cracks of my inbox for far too long, is a more complete solution to the same problem.

If so can you ACK it

https://patchwork.ozlabs.org/patch/1054789/

please ? At the same time, I will drop this patch from the PCI queue.

Thanks,
Lorenzo

Quoted 28 lines

Regards,
Lucas

Quoted 25 lines
Cc Bjorn Helgaas <[email protected]>
Cc Lorenzo Pieralisi <[email protected]>
Cc Lucas Stach <[email protected]>
Cc Richard Zhu <[email protected]>
Cc Sasha Levin <[email protected]>
Cc Sven Van Asbroeck <[email protected]>
Cc Trent Piepho <[email protected]>

---
 drivers/pci/controller/dwc/Kconfig | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/controller/dwc/Kconfig +0 -0
index a6ce1ee51b4c..3051387bf4f3 100644
@@ -90,7 +90,7 @@ config PCI_EXYNOS


 config PCI_IMX6
  bool "Freescale i.MX6/7/8 PCIe controller"

drivers/pci/controller/dwc/Kconfig +1 -1
-	depends on SOC_IMX6Q || SOC_IMX7D || (ARM64 && ARCH_MXC) || COMPILE_TEST
+	depends on SOC_IMX6SX || SOC_IMX6Q || SOC_IMX7D || (ARM64 && ARCH_MXC) || COMPILE_TEST

  depends on PCI_MSI_IRQ_DOMAIN select PCIE_DW_HOST