Reminder: 22 open syzbot bugs in perf subsystem
[This email was generated by a script. Let me know if you have any suggestions to make it better, or if you want it re-generated with the latest status.]
Of the currently open syzbot reports against the upstream kernel, I've manually marked 22 of them as possibly being bugs in the perf subsystem. I've listed these reports below, sorted by an algorithm that tries to list first the reports most likely to be still valid, important, and actionable.
Of these 22 bugs, 7 were seen in mainline in the last week.
Of these 22 bugs, 2 were bisected to commits from the following people:
Song Liu <[email protected]>
Kan Liang <[email protected]>
If you believe a bug is no longer valid, please close the syzbot report by sending a '#syz fix', '#syz dup', or '#syz invalid' command in reply to the original thread, as explained at https://goo.gl/tpsmEJ#status
If you believe I misattributed a bug to the perf subsystem, please let me know, and if possible forward the report to the correct people or mailing list.
Here are the bugs:
--------------------------------------------------------------------------------
Title: WARNING in perf_group_attach Last occurred: 0 days ago Reported: 185 days ago Branches: Mainline and others Dashboard link: https://syzkaller.appspot.com/bug?id=bc574683e1e3241992f8460c82ddac937e3c88b9 Original thread: https://lkml.kernel.org/lkml/[email protected]/T/#u
This bug has a C reproducer.
No one replied to the original thread for this bug.
If you fix this bug, please add the following tag to the commit:
If you send any email or patch for this bug, please consider replying to the original thread. For the git send-email command to use, or tips on how to reply if the thread isn't in your mailbox, see the "Reply instructions" at
https://lkml.kernel.org/r/[email protected]
--------------------------------------------------------------------------------
Title: INFO: rcu detected stall in sys_sendfile64 (2) Last occurred: 0 days ago Reported: 163 days ago Branches: Mainline and others Dashboard link: https://syzkaller.appspot.com/bug?id=6a6553c3d34bb00172b5cbd32f4912151b6133dc Original thread: https://lkml.kernel.org/lkml/[email protected]/T/#u
This bug has a C reproducer.
syzbot has bisected this bug, but I think the bisection result is incorrect.
The original thread for this bug received 15 replies; the last was 103 days ago.
I'm not confident this bug is really in the perf subsystem. I also think it might be in the fs/ext4 subsystem.
If you fix this bug, please add the following tag to the commit:
Reported-by: [email protected]
If you send any email or patch for this bug, please consider replying to the original thread. For the git send-email command to use, or tips on how to reply if the thread isn't in your mailbox, see the "Reply instructions" at
https://lkml.kernel.org/r/[email protected]
--------------------------------------------------------------------------------
Title: INFO: rcu detected stall in ext4_file_write_iter Last occurred: 2 days ago Reported: 125 days ago Branches: Mainline and others Dashboard link: https://syzkaller.appspot.com/bug?id=bc195cf62ac17381792072c72a692bf133c528d4 Original thread: https://lkml.kernel.org/lkml/[email protected]/T/#u
This bug has a C reproducer.
The original thread for this bug received 4 replies; the last was 123 days ago.
I'm not confident this bug is really in the perf subsystem. I also think it might be in the fs/ext4 subsystem.
If you fix this bug, please add the following tag to the commit:
Reported-by: [email protected]
If you send any email or patch for this bug, please consider replying to the original thread. For the git send-email command to use, or tips on how to reply if the thread isn't in your mailbox, see the "Reply instructions" at
https://lkml.kernel.org/r/[email protected]
--------------------------------------------------------------------------------
Title: KASAN: stack-out-of-bounds Read in update_stack_state Last occurred: 7 days ago Reported: 495 days ago Branches: Mainline and others Dashboard link: https://syzkaller.appspot.com/bug?id=51b058f4d86b9045d31b6bbe97211d3ebc96d4fa Original thread: https://lkml.kernel.org/lkml/[email protected]/T/#u
This bug has a C reproducer.
No one replied to the original thread for this bug.
If you fix this bug, please add the following tag to the commit:
Reported-by: [email protected]
If you send any email or patch for this bug, please consider replying to the original thread. For the git send-email command to use, or tips on how to reply if the thread isn't in your mailbox, see the "Reply instructions" at
https://lkml.kernel.org/r/[email protected]
--------------------------------------------------------------------------------
Title: INFO: task hung in __do_page_fault (2) Last occurred: 6 days ago Reported: 247 days ago Branches: Mainline and others Dashboard link: https://syzkaller.appspot.com/bug?id=9e5eb5f575324225d04b9b3095f5c3fc71700f08 Original thread: https://lkml.kernel.org/lkml/[email protected]/T/#u
This bug has a C reproducer.
No one replied to the original thread for this bug.
If you fix this bug, please add the following tag to the commit:
Reported-by: [email protected]
If you send any email or patch for this bug, please consider replying to the original thread. For the git send-email command to use, or tips on how to reply if the thread isn't in your mailbox, see the "Reply instructions" at
https://lkml.kernel.org/r/[email protected]
--------------------------------------------------------------------------------
Title: INFO: task hung in do_exit Last occurred: 1 day ago Reported: 79 days ago Branches: Mainline and others Dashboard link: https://syzkaller.appspot.com/bug?id=3e6c42e24155e5f0125368e609bee32f2b7394fe Original thread: https://lkml.kernel.org/lkml/[email protected]/T/#u
This bug has a syzkaller reproducer only.
syzbot has bisected this bug, but I think the bisection result is incorrect.
The original thread for this bug has received 1 reply, 78 days ago.
If you fix this bug, please add the following tag to the commit:
Reported-by: [email protected]
If you send any email or patch for this bug, please consider replying to the original thread. For the git send-email command to use, or tips on how to reply if the thread isn't in your mailbox, see the "Reply instructions" at
https://lkml.kernel.org/r/[email protected]
--------------------------------------------------------------------------------
Title: WARNING in add_event_to_ctx Last occurred: 0 days ago Reported: 11 days ago Branches: Mainline Dashboard link: https://syzkaller.appspot.com/bug?id=c0b2e13c4e106f405e56cc89843b0e54eb6d9e52 Original thread: https://lkml.kernel.org/lkml/[email protected]/T/#u
This bug has a C reproducer.
This bug was bisected to:
commit 33ea4b24277b06dbc55d7f5772a46f029600255e Author: Song Liu <[email protected]> Date: Wed Dec 6 22:45:16 2017 +0000 perf/core: Implement the 'perf_uprobe' PMU
No one has replied to the original thread for this bug yet.
If you fix this bug, please add the following tag to the commit:
Reported-by: [email protected]
If you send any email or patch for this bug, please reply to the original thread. For the git send-email command to use, or tips on how to reply if the thread isn't in your mailbox, see the "Reply instructions" at
https://lkml.kernel.org/r/[email protected]
--------------------------------------------------------------------------------
Title: general protection fault in perf_tp_event Last occurred: 0 days ago Reported: 424 days ago Branches: Mainline and others Dashboard link: https://syzkaller.appspot.com/bug?id=db96e8cebcedb255a170187c8add3ea0745db13b Original thread: https://lkml.kernel.org/lkml/[email protected]/T/#u
Unfortunately, this bug does not have a reproducer.
No one replied to the original thread for this bug.
If you fix this bug, please add the following tag to the commit:
Reported-by: [email protected]
If you send any email or patch for this bug, please consider replying to the original thread. For the git send-email command to use, or tips on how to reply if the thread isn't in your mailbox, see the "Reply instructions" at
https://lkml.kernel.org/r/[email protected]
--------------------------------------------------------------------------------
Title: WARNING in perf_reg_value Last occurred: 3 days ago Reported: 12 days ago Branches: Mainline and others Dashboard link: https://syzkaller.appspot.com/bug?id=629d95983fbba49821af91acf780387bca180546 Original thread: https://lkml.kernel.org/lkml/[email protected]/T/#u
This bug has a C reproducer.
This bug was bisected to:
commit 878068ea270ea82767ff1d26c91583263c81fba0 Author: Kan Liang <[email protected]> Date: Tue Apr 2 19:44:59 2019 +0000 perf/x86: Support outputting XMM registers
The original thread for this bug has received 3 replies; the last was 11 days ago.
If you fix this bug, please add the following tag to the commit:
Reported-by: [email protected]
If you send any email or patch for this bug, please reply to the original thread, which had activity only 11 days ago. For the git send-email command to use, or tips on how to reply if the thread isn't in your mailbox, see the "Reply instructions" at https://lkml.kernel.org/r/[email protected]
--------------------------------------------------------------------------------
Title: WARNING in tracepoint_probe_register_prio (3) Last occurred: 0 days ago Reported: 409 days ago Branches: Mainline and others Dashboard link: https://syzkaller.appspot.com/bug?id=63e3738079e5b2a71cd19820e454b8ac315c7550 Original thread: https://lkml.kernel.org/lkml/[email protected]/T/#u
Unfortunately, this bug does not have a reproducer.
No one replied to the original thread for this bug.
If you fix this bug, please add the following tag to the commit:
Reported-by: [email protected]
If you send any email or patch for this bug, please consider replying to the original thread. For the git send-email command to use, or tips on how to reply if the thread isn't in your mailbox, see the "Reply instructions" at
https://lkml.kernel.org/r/[email protected]
--------------------------------------------------------------------------------
Title: INFO: task hung in exit_mm Last occurred: 4 days ago Reported: 0 days ago Branches: Mainline Dashboard link: https://syzkaller.appspot.com/bug?id=dd115babf1498c3370fab8758d58940b7c6bffa4 Original thread: https://lkml.kernel.org/lkml/[email protected]/T/#u
This bug has a syzkaller reproducer only.
The original thread for this bug has received 1 reply, 22 hours ago.
If you fix this bug, please add the following tag to the commit:
If you send any email or patch for this bug, please reply to the original thread, which had activity only 22 hours ago. For the git send-email command to use, or tips on how to reply if the thread isn't in your mailbox, see the "Reply instructions" at https://lkml.kernel.org/r/[email protected]
--------------------------------------------------------------------------------
Title: KASAN: use-after-free Read in _free_event Last occurred: 9 days ago Reported: 7 days ago Branches: Mainline Dashboard link: https://syzkaller.appspot.com/bug?id=178d9570289a3e1aaf929f00e78b0d9596fccc7c Original thread: https://lkml.kernel.org/lkml/[email protected]/T/#u
Unfortunately, this bug does not have a reproducer.
The original thread for this bug has received 1 reply, 7 days ago.
If you fix this bug, please add the following tag to the commit:
Reported-by: [email protected]
If you send any email or patch for this bug, please reply to the original thread, which had activity only 7 days ago. For the git send-email command to use, or tips on how to reply if the thread isn't in your mailbox, see the "Reply instructions" at https://lkml.kernel.org/r/[email protected]
--------------------------------------------------------------------------------
Title: KASAN: use-after-free Read in refcount_sub_and_test_checked (2) Last occurred: 74 days ago Reported: 180 days ago Branches: Mainline and others Dashboard link: https://syzkaller.appspot.com/bug?id=eaf7abde8e5497bbf7403a3d2afb9226005362cf Original thread: https://lkml.kernel.org/lkml/[email protected]/T/#u
This bug has a syzkaller reproducer only.
syzbot has bisected this bug, but I think the bisection result is incorrect.
No one replied to the original thread for this bug.
If you fix this bug, please add the following tag to the commit:
Reported-by: [email protected]
If you send any email or patch for this bug, please consider replying to the original thread. For the git send-email command to use, or tips on how to reply if the thread isn't in your mailbox, see the "Reply instructions" at
https://lkml.kernel.org/r/[email protected]
--------------------------------------------------------------------------------
Title: KASAN: use-after-free Write in _free_event Last occurred: 120 days ago Reported: 357 days ago Branches: Mainline and others Dashboard link: https://syzkaller.appspot.com/bug?id=e4223c174b5ef17b309798050835bafb6d6520b0 Original thread: https://lkml.kernel.org/lkml/[email protected]/T/#u
This bug has a C reproducer.
The original thread for this bug received 14 replies; the last was 13 hours ago.
If you fix this bug, please add the following tag to the commit:
Reported-by: [email protected]
If you send any email or patch for this bug, please reply to the original thread, which had activity only 13 hours ago. For the git send-email command to use, or tips on how to reply if the thread isn't in your mailbox, see the "Reply instructions" at https://lkml.kernel.org/r/[email protected]
--------------------------------------------------------------------------------
Title: WARNING in arch_install_hw_breakpoint Last occurred: 100 days ago Reported: 99 days ago Branches: Mainline and others Dashboard link: https://syzkaller.appspot.com/bug?id=7250aa28cb43ada4cba944fe46d80f67435022ef Original thread: https://lkml.kernel.org/lkml/[email protected]/T/#u
This bug has a C reproducer.
The original thread for this bug received 8 replies; the last was 95 days ago.
If you fix this bug, please add the following tag to the commit:
Reported-by: [email protected]
If you send any email or patch for this bug, please consider replying to the original thread. For the git send-email command to use, or tips on how to reply if the thread isn't in your mailbox, see the "Reply instructions" at
https://lkml.kernel.org/r/[email protected]
--------------------------------------------------------------------------------
Title: KASAN: use-after-free Read in uprobe_perf_close Last occurred: 136 days ago Reported: 455 days ago Branches: Mainline and others Dashboard link: https://syzkaller.appspot.com/bug?id=3fb9c4777053e79a6d2a65ac3738664c87629a21 Original thread: https://lkml.kernel.org/lkml/[email protected]/T/#u
This bug has a C reproducer.
No one replied to the original thread for this bug.
If you fix this bug, please add the following tag to the commit:
If you send any email or patch for this bug, please consider replying to the original thread. For the git send-email command to use, or tips on how to reply if the thread isn't in your mailbox, see the "Reply instructions" at
https://lkml.kernel.org/r/[email protected]
--------------------------------------------------------------------------------
Title: WARNING: ODEBUG bug in __do_softirq Last occurred: 73 days ago Reported: 499 days ago Branches: Mainline and others Dashboard link: https://syzkaller.appspot.com/bug?id=26c9593893aa8625f556867ea71649010a07e74d Original thread: https://groups.google.com/d/msgid/syzkaller-bugs/001a1143e62eb6a9510565640e76%40google.com
This bug has a syzkaller reproducer only.
syzbot has bisected this bug, but I think the bisection result is incorrect.
For some reason the original report email for this bug is missing from the LKML archive at lore.kernel.org, so my script couldn't check whether anyone has replied to it or not. The Google Groups link above should still work, though. Also try searching for the bug title.
--------------------------------------------------------------------------------
Title: INFO: rcu detected stall in __perf_sw_event Last occurred: 81 days ago Reported: 144 days ago Branches: Mainline and others Dashboard link: https://syzkaller.appspot.com/bug?id=c97097e0408c6c6f60ac89b78faaf0e42663cbac Original thread: https://lkml.kernel.org/lkml/[email protected]/T/#u
This bug has a syzkaller reproducer only.
syzbot has bisected this bug, but I think the bisection result is incorrect.
The original thread for this bug received 2 replies; the last was 95 days ago.
If you fix this bug, please add the following tag to the commit:
Reported-by: [email protected]
If you send any email or patch for this bug, please consider replying to the original thread. For the git send-email command to use, or tips on how to reply if the thread isn't in your mailbox, see the "Reply instructions" at
https://lkml.kernel.org/r/[email protected]
--------------------------------------------------------------------------------
Title: WARNING in event_function_local Last occurred: 264 days ago Reported: 520 days ago Branches: Mainline and others Dashboard link: https://syzkaller.appspot.com/bug?id=ea9e1f49354606d70d272294fcc1d80a86ea0e6b Original thread: https://lkml.kernel.org/lkml/[email protected]/T/#u
This bug has a C reproducer.
The original thread for this bug received 8 replies; the last was 138 days ago.
If you fix this bug, please add the following tag to the commit:
Reported-by: [email protected]
If you send any email or patch for this bug, please consider replying to the original thread. For the git send-email command to use, or tips on how to reply if the thread isn't in your mailbox, see the "Reply instructions" at
https://lkml.kernel.org/r/[email protected]
--------------------------------------------------------------------------------
Title: INFO: task hung in uprobe_start_dup_mmap Last occurred: 84 days ago Reported: 298 days ago Branches: Mainline and others Dashboard link: https://syzkaller.appspot.com/bug?id=4432696d9b58dd75ab7ea39171bfaaed10f44d47 Original thread: https://lkml.kernel.org/lkml/[email protected]/T/#u
Unfortunately, this bug does not have a reproducer.
No one replied to the original thread for this bug.
If you fix this bug, please add the following tag to the commit:
If you send any email or patch for this bug, please consider replying to the original thread. For the git send-email command to use, or tips on how to reply if the thread isn't in your mailbox, see the "Reply instructions" at
https://lkml.kernel.org/r/[email protected]
--------------------------------------------------------------------------------
Title: possible deadlock in percpu_down_write Last occurred: 172 days ago Reported: 260 days ago Branches: Mainline Dashboard link: https://syzkaller.appspot.com/bug?id=041178b4b3a51686e1d5920a3d660b3e5b9d8ab3 Original thread: https://lkml.kernel.org/lkml/[email protected]/T/#u
Unfortunately, this bug does not have a reproducer.
No one replied to the original thread for this bug.
If you fix this bug, please add the following tag to the commit:
Reported-by: [email protected]
If you send any email or patch for this bug, please consider replying to the original thread. For the git send-email command to use, or tips on how to reply if the thread isn't in your mailbox, see the "Reply instructions" at
https://lkml.kernel.org/r/[email protected]
--------------------------------------------------------------------------------
Title: possible deadlock in uprobe_clear_state Last occurred: 164 days ago Reported: 201 days ago Branches: Mainline Dashboard link: https://syzkaller.appspot.com/bug?id=a1ce9b3da349209c5085bb8c4fee753d68c3697f Original thread: https://lkml.kernel.org/lkml/[email protected]/T/#u
Unfortunately, this bug does not have a reproducer.
No one replied to the original thread for this bug.
If you fix this bug, please add the following tag to the commit:
Reported-by: [email protected]
If you send any email or patch for this bug, please consider replying to the original thread. For the git send-email command to use, or tips on how to reply if the thread isn't in your mailbox, see the "Reply instructions" at
https://lkml.kernel.org/r/[email protected]
Quoted 12 lines · Eric Biggers
--------------------------------------------------------------------------------
Title: possible deadlock in uprobe_clear_state Last occurred: 164 days ago Reported: 201 days ago Branches: Mainline Dashboard link: https://syzkaller.appspot.com/bug?id=a1ce9b3da349209c5085bb8c4fee753d68c3697f Original thread: https://lkml.kernel.org/lkml/[email protected]/T/#uUnfortunately, this bug does not have a reproducer.
No one replied to the original thread for this bug.
Quoted 8 lines
If you fix this bug, please add the following tag to the commit:
Reported-by: [email protected]If you send any email or patch for this bug, please consider replying to the original thread. For the git send-email command to use, or tips on how to reply if the thread isn't in your mailbox, see the "Reply instructions" at
https://lkml.kernel.org/r/[email protected]
This is false positive:
https://marc.info/?l=linux-kernel&m=154925313012615&w=2
Quoted 18 lines · Ravi Bangoria
Quoted 15 lines · Eric Biggers
--------------------------------------------------------------------------------
Title: possible deadlock in uprobe_clear_state Last occurred: 164 days ago Reported: 201 days ago Branches: Mainline Dashboard link: https://syzkaller.appspot.com/bug?id=a1ce9b3da349209c5085bb8c4fee753d68c3697f Original thread: https://lkml.kernel.org/lkml/[email protected]/T/#uUnfortunately, this bug does not have a reproducer.
No one replied to the original thread for this bug.
If you fix this bug, please add the following tag to the commit:
Reported-by: [email protected]
Quoted 9 lines
Quoted 5 lines
If you send any email or patch for this bug, please consider replying to the original thread. For the git send-email command to use, or tips on how to reply if the thread isn't in your mailbox, see the "Reply instructions" at
https://lkml.kernel.org/r/[email protected]This is false positive:
https://marc.info/?l=linux-kernel&m=154925313012615&w=2
What do you mean "false positive"? Your patch says there can be a deadlock. Also, your patch hasn't been merged yet. So doesn't it still need to be fixed?
- Eric
Hi Eric,
Quoted 25 lines · Eric Biggers
Quoted 24 lines · Ravi Bangoria
Quoted 20 lines · Eric Biggers
--------------------------------------------------------------------------------
Title: possible deadlock in uprobe_clear_state Last occurred: 164 days ago Reported: 201 days ago Branches: Mainline Dashboard link: https://syzkaller.appspot.com/bug?id=a1ce9b3da349209c5085bb8c4fee753d68c3697f Original thread: https://lkml.kernel.org/lkml/[email protected]/T/#uUnfortunately, this bug does not have a reproducer.
No one replied to the original thread for this bug.
If you fix this bug, please add the following tag to the commit:
Reported-by: [email protected]If you send any email or patch for this bug, please consider replying to the original thread. For the git send-email command to use, or tips on how to reply if the thread isn't in your mailbox, see the "Reply instructions" at
https://lkml.kernel.org/r/[email protected]
Quoted 6 lines
Quoted 3 lines
This is false positive:
https://marc.info/?l=linux-kernel&m=154925313012615&w=2What do you mean "false positive"? Your patch says there can be a deadlock. Also, your patch hasn't been merged yet. So doesn't it still need to be fixed?
Please see Oleg's reply to the patch:
https://marc.info/?l=linux-kernel&m=154946017315554&w=2
"""
But this is false positive, right? if CPU1 calls update_ref_ctr() then either ->mm_users is already zero so binder_alloc_free_page()->mmget_not_zero() will fail, or the caller of update_ref_ctr() has a reference and thus binder_alloc_free_page()->mmput() can't trigger __mmput() ?
"""
Quoted 38 lines · Ravi Bangoria
Hi Eric,
Quoted 25 lines · Eric Biggers
Quoted 24 lines · Ravi Bangoria
Quoted 20 lines · Eric Biggers
--------------------------------------------------------------------------------
Title: possible deadlock in uprobe_clear_state Last occurred: 164 days ago Reported: 201 days ago Branches: Mainline Dashboard link: https://syzkaller.appspot.com/bug?id=a1ce9b3da349209c5085bb8c4fee753d68c3697f Original thread: https://lkml.kernel.org/lkml/[email protected]/T/#uUnfortunately, this bug does not have a reproducer.
No one replied to the original thread for this bug.
If you fix this bug, please add the following tag to the commit:
Reported-by: [email protected]If you send any email or patch for this bug, please consider replying to the original thread. For the git send-email command to use, or tips on how to reply if the thread isn't in your mailbox, see the "Reply instructions" at
https://lkml.kernel.org/r/[email protected]Quoted 6 lines
Quoted 3 lines
This is false positive:
https://marc.info/?l=linux-kernel&m=154925313012615&w=2What do you mean "false positive"? Your patch says there can be a deadlock. Also, your patch hasn't been merged yet. So doesn't it still need to be fixed?
Please see Oleg's reply to the patch:
https://marc.info/?l=linux-kernel&m=154946017315554&w=2
Quoted 7 lines
"""
But this is false positive, right? if CPU1 callsupdate_ref_ctr()then either ->mm_users is already zero so binder_alloc_free_page()->mmget_not_zero() will fail, or the caller ofupdate_ref_ctr()has a reference and thus binder_alloc_free_page()->mmput() can't trigger__mmput()?
"""
Even if it's a lockdep false positive you can't ignore it. People rely on lockdep to find bugs, and they will keep sending you bug reports. So someone has to fix something. Did you see Oleg's suggestion to change mmput() to mmput_async() in binder_alloc_free_page()?
https://marc.info/?l=linux-kernel&m=155119805728815&w=2
If you believe that is the right fix, I can reassign this report to binder subsystem and nag the binder maintainers instead...
- Eric
Quoted 47 lines · Eric Biggers
Quoted 38 lines · Ravi Bangoria
Hi Eric,
Quoted 25 lines · Eric Biggers
Quoted 24 lines · Ravi Bangoria
Quoted 20 lines · Eric Biggers
--------------------------------------------------------------------------------
Title: possible deadlock in uprobe_clear_state Last occurred: 164 days ago Reported: 201 days ago Branches: Mainline Dashboard link: https://syzkaller.appspot.com/bug?id=a1ce9b3da349209c5085bb8c4fee753d68c3697f Original thread: https://lkml.kernel.org/lkml/[email protected]/T/#uUnfortunately, this bug does not have a reproducer.
No one replied to the original thread for this bug.
If you fix this bug, please add the following tag to the commit:
Reported-by: [email protected]If you send any email or patch for this bug, please consider replying to the original thread. For the git send-email command to use, or tips on how to reply if the thread isn't in your mailbox, see the "Reply instructions" at
https://lkml.kernel.org/r/[email protected]Quoted 6 lines
Quoted 3 lines
This is false positive:
https://marc.info/?l=linux-kernel&m=154925313012615&w=2What do you mean "false positive"? Your patch says there can be a deadlock. Also, your patch hasn't been merged yet. So doesn't it still need to be fixed?
Please see Oleg's reply to the patch:
https://marc.info/?l=linux-kernel&m=154946017315554&w=2Quoted 7 lines
"""
But this is false positive, right? if CPU1 callsupdate_ref_ctr()then either ->mm_users is already zero so binder_alloc_free_page()->mmget_not_zero() will fail, or the caller ofupdate_ref_ctr()has a reference and thus binder_alloc_free_page()->mmput() can't trigger__mmput()?
"""
Quoted 3 lines
Even if it's a lockdep false positive you can't ignore it. People rely on lockdep to find bugs, and they will keep sending you bug reports. So someone has to fix something.
Agreed.
Quoted 4 lines
Did you see Oleg's suggestion to change
mmput()tommput_async()inbinder_alloc_free_page()?
https://marc.info/?l=linux-kernel&m=155119805728815&w=2
If you believe that is the right fix,
Yes, fixing it in binderfs looks right to me.
Quoted 2 lines
I can reassign this report to binder subsystem and nag the binder maintainers instead...
Yes please :)
Quoted 8 lines · Eric Biggers
Even if it's a lockdep false positive you can't ignore it. People rely on lockdep to find bugs, and they will keep sending you bug reports. So someone has to fix something. Did you see Oleg's suggestion to change
mmput()tommput_async()inbinder_alloc_free_page()?
https://marc.info/?l=linux-kernel&m=155119805728815&w=2
If you believe that is the right fix, I can reassign this report to binder subsystem and nag the binder maintainers instead...
Yes, please. To me s/mmput/mmput_async/ looks like the "obviously correct fix", but of course I don't understand this code and can't test it.
Oleg.