Simplify NULL comparisons in staging/kpc2000
cover Simplify NULL comparisons in staging/kpc2000
Hi,
These patches simplifies a few comparisons to NULL ("foo == NULL" => "!foo") in staging/kpc2000, as reported by checkpatch.pl.
- Simon
Simon Sandström (3):
staging: kpc2000: simplify comparison to NULL in kpc2000_spi.c
staging: kpc2000: simplify comparison to NULL in dma.c
staging: kpc2000: simplify comparison to NULL in fileops.c
drivers/staging/kpc2000/kpc2000_spi.c | 4 ++-- drivers/staging/kpc2000/kpc_dma/dma.c | 4 ++-- drivers/staging/kpc2000/kpc_dma/fileops.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-)
Signature · 1 line
2.20.1
PATCH 1/3 staging: kpc2000: simplify comparison to NULL in kpc2000_spi.c
Fixes checkpatch warning "Comparison to NULL could be written [...]".
--- drivers/staging/kpc2000/kpc2000_spi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/kpc2000/kpc2000_spi.c +2 -2
@@ -436,7 +436,7 @@ kp_spi_probe(struct platform_device *pldev) } master =spi_alloc_master (&pldev->dev,sizeof (struct kp_spi )); -if (master ==NULL ) { +if (!master) {dev_err (&pldev->dev,"%s: master allocation failed\n" , __func__);return -ENOMEM ;
@@ -460,7 +460,7 @@ kp_spi_probe(struct platform_device *pldev) master->bus_num = pldev->id; r =platform_get_resource (pldev,IORESOURCE_MEM ,0 ); -if (r ==NULL ) { +if (!r) {dev_err (&pldev->dev,"%s: Unable to get platform resources\n" , __func__); status = -ENODEV ;
Signature · 1 line
2.20.1
PATCH 2/3 staging: kpc2000: simplify comparison to NULL in dma.c
In reply to Simon SandströmFixes checkpatch warning "Comparison to NULL could be written [...]".
--- drivers/staging/kpc2000/kpc_dma/dma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/kpc2000/kpc_dma/dma.c +2 -2
@@ -119,7 +119,7 @@ int setup_dma_engine(struct kpc_dma_device *eng, u32 desc_cnt) cur = eng->desc_pool_first;for (i =1 ; i < eng->desc_pool_cnt ; i++) { next =dma_pool_alloc (eng->desc_pool,GFP_KERNEL |GFP_DMA , &next_handle); -if (next ==NULL ) +if (!next) goto done_alloc;clear_desc (next);
@@ -245,7 +245,7 @@ int count_descriptors_available(struct kpc_dma_device *eng)void clear_desc (struct kpc_dma_descriptor *desc) { -if (desc ==NULL ) +if (!desc)return ; desc->DescByteCount =0 ; desc->DescStatusErrorFlags =0 ;
Signature · 1 line
2.20.1
PATCH 3/3 staging: kpc2000: simplify comparison to NULL in fileops.c
In reply to Simon SandströmFixes checkpatch warning "Comparison to NULL could be written [...]".
--- drivers/staging/kpc2000/kpc_dma/fileops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/kpc2000/kpc_dma/fileops.c +1 -1
@@ -247,7 +247,7 @@ int kpc_dma_open(struct inode *inode, struct file *filp)struct dev_private_data *priv;struct kpc_dma_device *ldev =kpc_dma_lookup_device (iminor (inode)); -if (ldev ==NULL ) +if (!ldev)return -ENODEV ;if (!atomic_dec_and_test (&ldev->open_count)) {
Signature · 1 line
2.20.1