Skip to contentSkip to conversation

sound: soc: codecs: wcd9335: add irqflag IRQF_ONESHOT flag

PATCH Superseded Hariprasad Kelam 2 participants 3 messages Jul 4, 2019 – Jul 10, 2019

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sound: soc: codecs: wcd9335: add irqflag IRQF_ONESHOT flag

Add IRQF_ONESHOT to ensure "Interrupt is not reenabled after the hardirq handler finished".

fixes below issue reported by coccicheck

sound/soc/codecs/wcd9335.c:4068:8-33: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT

---
 sound/soc/codecs/wcd9335.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
sound/soc/codecs/wcd9335.c +4 -1
index 85737fe..7ab9bf6f 100644
@@ -4056,6 +4056,9 @@ static struct wcd9335_irq wcd9335_irqs[] = {
 static int wcd9335_setup_irqs(struct wcd9335_codec *wcd)
 {
 	int irq, ret, i;
+	unsigned long irqflags;
+
+	irqflags = IRQF_TRIGGER_RISING | IRQF_ONESHOT;
 
 	for (i = 0; i < ARRAY_SIZE(wcd9335_irqs); i++) {
 		irq = regmap_irq_get_virq(wcd->irq_data, wcd9335_irqs[i].irq);
@@ -4067,7 +4070,7 @@ static int wcd9335_setup_irqs(struct wcd9335_codec *wcd)
 
 		ret = devm_request_threaded_irq(wcd->dev, irq, NULL,
 						wcd9335_irqs[i].handler,
-						IRQF_TRIGGER_RISING,
+						irqflags,
 						wcd9335_irqs[i].name, wcd);
 		if (ret) {
 			dev_err(wcd->dev, "Failed to request %s\n",
Signature · 1 line
2.7.4
#1 lore raw
Quoted 18 lines · Hariprasad Kelam

Add IRQF_ONESHOT to ensure "Interrupt is not reenabled after the hardirq handler finished".

fixes below issue reported by coccicheck

sound/soc/codecs/wcd9335.c:4068:8-33: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT

---
 sound/soc/codecs/wcd9335.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
sound/soc/codecs/wcd9335.c +0 -0
index 85737fe..7ab9bf6f 100644

sound/soc/codecs/wcd9335.c static struct wcd9335_irq wcd9335_irqs[] = { · line 4061

Quoted 6 lines
sound/soc/codecs/wcd9335.c +3 -0
@@ -4056,6 +4056,9 @@ static struct wcd9335_irq wcd9335_irqs[] = {
 static int wcd9335_setup_irqs(struct wcd9335_codec *wcd)
 {
 	int irq, ret, i;
+	unsigned long irqflags;
+
+	irqflags = IRQF_TRIGGER_RISING | IRQF_ONESHOT;

Why does this change trigger adding a variable?

Quoted 18 lines
sound/soc/codecs/wcd9335.c +1 -1
 	for (i = 0; i < ARRAY_SIZE(wcd9335_irqs); i++) {
 		irq = regmap_irq_get_virq(wcd->irq_data, wcd9335_irqs[i].irq);
@@ -4067,7 +4070,7 @@ static int wcd9335_setup_irqs(struct wcd9335_codec *wcd)
 
 		ret = devm_request_threaded_irq(wcd->dev, irq, NULL,
 						wcd9335_irqs[i].handler,
-						IRQF_TRIGGER_RISING,
+						irqflags,
 						wcd9335_irqs[i].name, wcd);
 		if (ret) {
 			dev_err(wcd->dev, "Failed to request %s\n",
Signature · 6 lines
2.7.4

_______________________________________________
Alsa-devel mailing list
[email protected]
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
#2 lore raw
Quoted 14 lines · Ladislav Michl
Quoted 13 lines · Hariprasad Kelam

Add IRQF_ONESHOT to ensure "Interrupt is not reenabled after the hardirq handler finished".

fixes below issue reported by coccicheck

sound/soc/codecs/wcd9335.c:4068:8-33: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT

---
 sound/soc/codecs/wcd9335.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Quoted 13 lines

sound/soc/codecs/wcd9335.c static struct wcd9335_irq wcd9335_irqs[] = { · line 4061

Quoted 11 lines
sound/soc/codecs/wcd9335.c +3 -0
index 85737fe..7ab9bf6f 100644
@@ -4056,6 +4056,9 @@ static struct wcd9335_irq wcd9335_irqs[] = {
 static int wcd9335_setup_irqs(struct wcd9335_codec *wcd)
 {
 	int irq, ret, i;
+	unsigned long irqflags;
+
+	irqflags = IRQF_TRIGGER_RISING | IRQF_ONESHOT;

Why does this change trigger adding a variable?

Yes variable is not required. Will resend the patch without variable.

Quoted 19 lines
Quoted 19 lines
sound/soc/codecs/wcd9335.c +1 -1
 	for (i = 0; i < ARRAY_SIZE(wcd9335_irqs); i++) {
 		irq = regmap_irq_get_virq(wcd->irq_data, wcd9335_irqs[i].irq);
@@ -4067,7 +4070,7 @@ static int wcd9335_setup_irqs(struct wcd9335_codec *wcd)
 
 		ret = devm_request_threaded_irq(wcd->dev, irq, NULL,
 						wcd9335_irqs[i].handler,
-						IRQF_TRIGGER_RISING,
+						irqflags,
 						wcd9335_irqs[i].name, wcd);
 		if (ret) {
 			dev_err(wcd->dev, "Failed to request %s\n",
Signature · 6 lines
2.7.4

_______________________________________________
Alsa-devel mailing list
[email protected]
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel