Skip to contentSkip to conversation

Remove -no-cpp-precomp flag from Darwin builds

PATCH In review Arne Schwabe 2 participants 2 messages Jul 5, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Remove -no-cpp-precomp flag from Darwin builds

GCC 9 no longer accepts this flag and trying to find out what it does do leads to an article

"-no-cpp-precomp: the compiler flag that time forgot"

that also no longer on the Internet. And most other things are PRs/commits from over ten years ago that remove the flag since it is no longer needed.

---
 configure.ac | 2 --
 1 file changed, 2 deletions(-)
configure.ac +0 -2
index 2cc396e5..e9f8a2f9 100644
@@ -323,8 +323,6 @@ case "$host" in
 		AC_DEFINE([TARGET_DARWIN], [1], [Are we running on Mac OS X?])
 		AC_DEFINE_UNQUOTED([TARGET_PREFIX], ["M"], [Target prefix])
 		have_tap_header="yes"
-		dnl some Mac OS X tendering (we use vararg macros...)
-		CPPFLAGS="$CPPFLAGS -no-cpp-precomp"
 		ac_cv_type_struct_in_pktinfo=no
 		;;
 	*-mingw*)
Signature · 1 line
2.22.0
Acked-by on v1 1/1
#1 lore raw

Explanation makes sense :-)

Your patch has been applied to the master and release/2.4 branch.

commit 0740e079a1c094627a69b8b5959c6be56e15d9f6 (master) commit c39b46e5fa0a73a1959bba30a9ca1ee59feb544b (release/2.4)

Author: Arne Schwabe
Date:   Fri Jul 5 13:42:43 2019 +0200
     Remove -no-cpp-precomp flag from Darwin builds

     Acked-by: Gert Doering <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg18650.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering