Fix python feature detection
RFC 1/1 Fix python feature detection
I am having a hard time building BPF samples by doing a make in samples/bpf. While I am debugging that, I ran into the Python issue. Even though the system has libpython2.7-dev:
If I just do a 'make' inside tools/build/feature/ I get:Python.h: No such file or directory
This led me to this patch which fixes Python feature detection for me. I am not sure if it is the right fix for Python since it is hardcoded for Python version 2, but I thought it could be useful.
My system is a Debian buster release.
--- tools/build/feature/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/build/feature/Makefile +2 -2
@@ -83,7 +83,7 @@ __BUILDXX = $(CXX) $(CXXFLAGS) -MD -Wall -Werror -o $@ $(patsubst %.bin,%.cpp,$( ############################### $(OUTPUT)test-all.bin: - $(BUILD) -fstack-protector-all -O2 -D_FORTIFY_SOURCE=2 -ldw -lelf -lnuma -lelf -laudit -I/usr/include/slang -lslang $(shell $(PKG_CONFIG) --libs --cflags gtk+-2.0 2>/dev/null) $(FLAGS_PERL_EMBED) $(FLAGS_PYTHON_EMBED) -DPACKAGE='"perf"' -lbfd -ldl -lz -llzma + $(BUILD) -fstack-protector-all -O2 -D_FORTIFY_SOURCE=2 -ldw -lelf -lnuma -lelf -laudit -I/usr/include/slang -lslang $(shell $(PKG_CONFIG) --libs --cflags gtk+-2.0 2>/dev/null) $(shell $(PKG_CONFIG) --libs --cflags python2 2>/dev/null) $(FLAGS_PERL_EMBED) $(FLAGS_PYTHON_EMBED) -DPACKAGE='"perf"' -lbfd -ldl -lz -llzma $(OUTPUT)test-hello.bin: $(BUILD)
@@ -205,7 +205,7 @@ $(OUTPUT)test-libperl.bin: $(BUILD) $(FLAGS_PERL_EMBED) $(OUTPUT)test-libpython.bin: - $(BUILD) $(FLAGS_PYTHON_EMBED) + $(BUILD) $(shell $(PKG_CONFIG) --libs --cflags python2 2>/dev/null) $(FLAGS_PYTHON_EMBED) $(OUTPUT)test-libpython-version.bin: $(BUILD)
Signature · 1 line
2.22.0.410.gd8fdbe21b5-goog
Quoted 6 lines · Joel Fernandes (Google)
I am having a hard time building BPF samples by doing a make in
samples/bpf. While I am debugging that, I ran into the Python issue. Even though the system has libpython2.7-dev:If I just do a 'make' inside
tools/build/feature/I get:Python.h: No such file or directory
because you don't have FLAGS_PYTHON_EMBED set?
Quoted 4 lines
This led me to this patch which fixes Python feature detection for me. I am not sure if it is the right fix for Python since it is hardcoded for Python version 2, but I thought it could be useful.
we detect python in tools/perf/Makefile.config and set FLAGS_PYTHON_EMBED properly
it's supposed to be set by a project using tools/build for feature detection.. what are you building? AFAICS samples/bpf do not use tools/build
jirka
Quoted 35 lines
My system is a Debian buster release.
--- tools/build/feature/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)tools/build/feature/Makefile +2
-2@@ -83,7 +83,7 @@ __BUILDXX = $(CXX) $(CXXFLAGS) -MD -Wall -Werror -o $@ $(patsubst %.bin,%.cpp,$( ############################### $(OUTPUT)test-all.bin: - $(BUILD) -fstack-protector-all -O2 -D_FORTIFY_SOURCE=2 -ldw -lelf -lnuma -lelf -laudit -I/usr/include/slang -lslang $(shell $(PKG_CONFIG) --libs --cflags gtk+-2.0 2>/dev/null) $(FLAGS_PERL_EMBED) $(FLAGS_PYTHON_EMBED) -DPACKAGE='"perf"' -lbfd -ldl -lz -llzma + $(BUILD) -fstack-protector-all -O2 -D_FORTIFY_SOURCE=2 -ldw -lelf -lnuma -lelf -laudit -I/usr/include/slang -lslang $(shell $(PKG_CONFIG) --libs --cflags gtk+-2.0 2>/dev/null) $(shell $(PKG_CONFIG) --libs --cflags python2 2>/dev/null) $(FLAGS_PERL_EMBED) $(FLAGS_PYTHON_EMBED) -DPACKAGE='"perf"' -lbfd -ldl -lz -llzma $(OUTPUT)test-hello.bin: $(BUILD)@@ -205,7 +205,7 @@ $(OUTPUT)test-libperl.bin: $(BUILD) $(FLAGS_PERL_EMBED) $(OUTPUT)test-libpython.bin: - $(BUILD) $(FLAGS_PYTHON_EMBED) + $(BUILD) $(shell $(PKG_CONFIG) --libs --cflags python2 2>/dev/null) $(FLAGS_PYTHON_EMBED) $(OUTPUT)test-libpython-version.bin: $(BUILD)Signature · 1 line
2.22.0.410.gd8fdbe21b5-goog
Quoted 15 lines · Jiri Olsa
Quoted 6 lines · Joel Fernandes (Google)
I am having a hard time building BPF samples by doing a make in
samples/bpf. While I am debugging that, I ran into the Python issue. Even though the system has libpython2.7-dev:If I just do a 'make' inside
tools/build/feature/I get:Python.h: No such file or directorybecause you don't have
FLAGS_PYTHON_EMBEDset?Quoted 4 lines
This led me to this patch which fixes Python feature detection for me. I am not sure if it is the right fix for Python since it is hardcoded for Python version 2, but I thought it could be useful.
Quoted 6 lines
we detect python in
tools/perf/Makefile.configand setFLAGS_PYTHON_EMBEDproperlyit's supposed to be set by a project using
tools/buildfor feature detection.. what are you building? AFAICSsamples/bpfdo not usetools/build
Yes, you are right. Never mind then. I was debugging feature detection and ended doing a make in this directory like:
make <something>.bin which works always except for python. But as you said it is likely a non-issue.
thanks!
- Joel