Skip to contentSkip to conversation

Staging: rtl8723bs: hal: rtl8723bs_recv.c: Fix code style

PATCH In review Fatih ALTINPINAR 2 participants 2 messages Jul 8, 2019 – Jul 10, 2019 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: rtl8723bs: hal: rtl8723bs_recv.c: Fix code style

Fixed a coding stlye issue. Removed braces from a single statement if block.

---
 drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c +1 -2
index e23b39ab16c5..71a4bcbeada9 100644
@@ -449,9 +449,8 @@ s32 rtl8723bs_init_recv_priv(struct adapter *padapter)
 				skb_reserve(precvbuf->pskb, (RECVBUFF_ALIGN_SZ - alignment));
 			}
 
-			if (!precvbuf->pskb) {
+			if (!precvbuf->pskb)
 				DBG_871X("%s: alloc_skb fail!\n", __func__);
-			}
 		}
 
 		list_add_tail(&precvbuf->list, &precvpriv->free_recv_buf_queue.queue);
Signature · 1 line
2.17.1
#1 lore raw
Quoted 13 lines · Fatih ALTINPINAR

Fixed a coding stlye issue. Removed braces from a single statement if block.

---
 drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c +0 -0
index e23b39ab16c5..71a4bcbeada9 100644

drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c s32 rtl8723bs_init_recv_priv(struct adapter *padapter) · line 454

Quoted 7 lines
drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c +1 -2
@@ -449,9 +449,8 @@ s32 rtl8723bs_init_recv_priv(struct adapter *padapter)
 				skb_reserve(precvbuf->pskb, (RECVBUFF_ALIGN_SZ - alignment));
 			}
 
-			if (!precvbuf->pskb) {
+			if (!precvbuf->pskb)
 				DBG_871X("%s: alloc_skb fail!\n", __func__);
-			}

You could delete the block instead.
alloc_skb failures already do a dump_stack()