mfd: cros_ec: Update cros_ec_commands.h
Subsystems (2)
PATCH 1/1 mfd: cros_ec: Update cros_ec_commands.h
Update cros_ec_commands.h to match the fingerprint MCU section in the current ec_commands.h
---
include/linux/mfd/cros_ec_commands.h | 12 ++++++++++++ 1 file changed, 12 insertions(+)
include/linux/mfd/cros_ec_commands.h +12 -0
@@ -5513,6 +5513,18 @@ struct ec_params_fp_seed {uint8_t seed[FP_CONTEXT_TPM_BYTES ]; } __ec_align4; +#define EC_CMD_FP_ENC_STATUS 0x0409 + +/* FP TPM seed has been set or not */ +#define FP_ENC_STATUS_SEED_SET BIT(0) + +struct ec_response_fp_encryption_status { +/* Used bits in encryption engine status */ +uint32_t valid_flags; +/* Encryption engine status */ +uint32_t status; +} __ec_align4; +/*****************************************************************************/ /* Touchpad MCU commands: range 0x0500-0x05FF */
Signature · 1 line
2.20.1
Note there is a patch series that move cros_ec_commands.h from nclude/linux/mfd/ to include/linux/platform_data.
Quoted 36 lines · Yicheng Li
Update
cros_ec_commands.hto match the fingerprint MCU section in the currentec_commands.hSigned-off-by Yicheng Li <[email protected]>---
include/linux/mfd/cros_ec_commands.h | 12 ++++++++++++ 1 file changed, 12 insertions(+)include/linux/mfd/cros_ec_commands.h +12
-1@@ -5513,6 +5513,18 @@ struct ec_params_fp_seed {uint8_t seed[FP_CONTEXT_TPM_BYTES ]; } __ec_align4; +#define EC_CMD_FP_ENC_STATUS 0x0409 + +/* FP TPM seed has been set or not */ +#define FP_ENC_STATUS_SEED_SET BIT(0) + +struct ec_response_fp_encryption_status { +/* Used bits in encryption engine status */ +uint32_t valid_flags; +/* Encryption engine status */ +uint32_t status; +} __ec_align4; +/*****************************************************************************/ /* Touchpad MCU commands: range 0x0500-0x05FF */ --2.20.1
Enric Balletbo i Serra
Reviewed-byHi Lee,
Quoted 5 lines · Gwendal Grignou
Reviewed-by Gwendal Grignou <[email protected]>Note there is a patch series that move
cros_ec_commands.hfrom nclude/linux/mfd/ toinclude/linux/platform_data.
I just sent a new version of the patches mentioned above now that rc1 is out [1]
As Gwendal said this patch will conflict with them, so we have two options.
1. If Lee picks that patch I can rebase again my series on top of it.
2. If not, we can wait for Lee reviewing my patch series and then I don't mind to rebase that patch on top of my series and carry the patch through chrome-platform. Anyway I'll need an immutable branch from Lee.
Quoted 6 lines · Yicheng Li
Quoted 5 lines
Update
cros_ec_commands.hto match the fingerprint MCU section in the currentec_commands.hSigned-off-by Yicheng Li <[email protected]>
For the first case:
Thanks,
~ Enric
[1] https://lkml.org/lkml/2019/7/22/497
Quoted 31 lines
Quoted 31 lines
---
include/linux/mfd/cros_ec_commands.h | 12 ++++++++++++ 1 file changed, 12 insertions(+)include/linux/mfd/cros_ec_commands.h +12
-1@@ -5513,6 +5513,18 @@ struct ec_params_fp_seed {uint8_t seed[FP_CONTEXT_TPM_BYTES ]; } __ec_align4; +#define EC_CMD_FP_ENC_STATUS 0x0409 + +/* FP TPM seed has been set or not */ +#define FP_ENC_STATUS_SEED_SET BIT(0) + +struct ec_response_fp_encryption_status { +/* Used bits in encryption engine status */ +uint32_t valid_flags; +/* Encryption engine status */ +uint32_t status; +} __ec_align4; +/*****************************************************************************/ /* Touchpad MCU commands: range 0x0500-0x05FF */ --2.20.1
Quoted 9 lines · Enric Balletbo i Serra
Hi Lee,
Quoted 5 lines · Gwendal Grignou
Reviewed-by Gwendal Grignou <[email protected]>Note there is a patch series that move
cros_ec_commands.hfrom nclude/linux/mfd/ toinclude/linux/platform_data.
Quoted 5 lines
I just sent a new version of the patches mentioned above now that rc1 is out [1]
As Gwendal said this patch will conflict with them, so we have two options.
1. If Lee picks that patch I can rebase again my series on top of it.
Yes please.
Quoted 3 lines
2. If not, we can wait for Lee reviewing my patch series and then I don't mind to rebase that patch on top of my series and carry the patch through chrome-platform. Anyway I'll need an immutable branch from Lee.
I just reviewed your series.
Signature · 4 lines
Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Hi Lee,
Quoted 11 lines · Lee Jones
Quoted 9 lines · Enric Balletbo i Serra
Hi Lee,
Quoted 5 lines · Gwendal Grignou
Reviewed-by Gwendal Grignou <[email protected]>Note there is a patch series that move
cros_ec_commands.hfrom nclude/linux/mfd/ toinclude/linux/platform_data.
Quoted 8 lines
Quoted 5 lines
I just sent a new version of the patches mentioned above now that rc1 is out [1]
As Gwendal said this patch will conflict with them, so we have two options.
1. If Lee picks that patch I can rebase again my series on top of it.
Yes please.
Perfect, preparing a new rebased version to send soon.
Quoted 6 lines
Quoted 3 lines
2. If not, we can wait for Lee reviewing my patch series and then I don't mind to rebase that patch on top of my series and carry the patch through chrome-platform. Anyway I'll need an immutable branch from Lee.
I just reviewed your series.
Thanks,
Enric
Lee Jones
AppliedQuoted 8 lines · Yicheng Li
Update
cros_ec_commands.hto match the fingerprint MCU section in the currentec_commands.hSigned-off-by Yicheng Li <[email protected]>---
include/linux/mfd/cros_ec_commands.h | 12 ++++++++++++ 1 file changed, 12 insertions(+)
Applied, thanks.
Signature · 4 lines
Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog