dma-mapping: mark dma_alloc_need_uncached as __always_inline
PATCH 1/1 dma-mapping: mark dma_alloc_need_uncached as __always_inline
Without the __always_inline at least i386 configs that have CONFIG_OPTIMIZE_INLINING set seem fail to inline dma_alloc_need_uncached, leading to a linker error because of undefined symbols.
Reported-by Randy Dunlap <[email protected]>
Signed-off-by Christoph Hellwig <[email protected]>
--- include/linux/dma-noncoherent.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/dma-noncoherent.h +1 -1
@@ -23,7 +23,7 @@ static inline bool dev_is_dma_coherent(struct device *dev)/* * Check if an allocation needs to be marked uncached to be coherent. */ -static inline bool dma_alloc_need_uncached (struct device *dev, +static __always_inline bool dma_alloc_need_uncached(struct device *dev,unsigned long attrs) {if (dev_is_dma_coherent (dev))
Signature · 1 line
2.20.1
Quoted 7 lines · Christoph Hellwig
Without the
__always_inlineat least i386 configs that haveCONFIG_OPTIMIZE_INLININGset seem fail to inlinedma_alloc_need_uncached, leading to a linker error because of undefined symbols.Reported-by Randy Dunlap <[email protected]>Signed-off-by Christoph Hellwig <[email protected]>
Thanks.
Quoted 18 lines
--- include/linux/dma-noncoherent.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/linux/dma-noncoherent.h +1
-1@@ -23,7 +23,7 @@ static inline bool dev_is_dma_coherent(struct device *dev)/* * Check if an allocation needs to be marked uncached to be coherent. */ -static inline bool dma_alloc_need_uncached (struct device *dev, +static __always_inline bool dma_alloc_need_uncached(struct device *dev,unsigned long attrs) {if (dev_is_dma_coherent (dev))
Signature · 1 line
~Randy