Skip to contentSkip to conversation

libsndfile1: disable use of sqlite3 by default

PATCH New Ross Burton 1 participant 2 messages Jul 9, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 libsndfile1: disable use of sqlite3 by default

sqlite3 is only used by the regression testing tool, which is of limited use unless you're the developer of libsndfile. Add a PACKAGECONFIG for this, but disable by default.

---
 meta/recipes-multimedia/libsndfile/libsndfile1_1.0.28.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-multimedia/libsndfile/libsndfile1_1.0.28.bb +2 -1
index 77393db8470..7dfee4e96fa 100644
@@ -1,7 +1,7 @@
 SUMMARY = "Audio format Conversion library"
 HOMEPAGE = "http://www.mega-nerd.com/libsndfile"
 AUTHOR = "Erik de Castro Lopo"
-DEPENDS = "flac libogg libvorbis sqlite3"
+DEPENDS = "flac libogg libvorbis"
 SECTION = "libs/multimedia"
 LICENSE = "LGPLv2.1"
 
@@ -30,6 +30,7 @@ S = "${WORKDIR}/libsndfile-${PV}"
 
 PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'alsa', d)}"
 PACKAGECONFIG[alsa] = "--enable-alsa,--disable-alsa,alsa-lib"
+PACKAGECONFIG[regtest] = "--enable-sqlite,--disable-sqlite,sqlite3"
 
 inherit autotools lib_package pkgconfig
 
Signature · 1 line
2.20.1
#1 lore raw

PATCH 2/2 libsndfile1: remove redundant autoconf seeding

Twelve years ago libsndfile was badly detecting large file handling and generating bad code[1]. The detection code in libsndfile has had many fixes since then and this isn't needed anymore (verified by comparing config.h when built for qemuarm).

[1] https://git.openembedded.org/openembedded/commit/?id=875cfc6f23ae68c6215bf32eb01a486f0387cb92

---
 meta/recipes-multimedia/libsndfile/libsndfile1_1.0.28.bb | 6 ------
 1 file changed, 6 deletions(-)
meta/recipes-multimedia/libsndfile/libsndfile1_1.0.28.bb +0 -6
index 7dfee4e96fa..ffb45855a4b 100644
@@ -33,9 +33,3 @@ PACKAGECONFIG[alsa] = "--enable-alsa,--disable-alsa,alsa-lib"
 PACKAGECONFIG[regtest] = "--enable-sqlite,--disable-sqlite,sqlite3"
 
 inherit autotools lib_package pkgconfig
-
-do_configure_prepend_arm() {
-	export ac_cv_sys_largefile_source=1
-	export ac_cv_sys_file_offset_bits=64
-}
-
Signature · 1 line
2.20.1