Skip to contentSkip to conversation

xen/doc: remove obsolete warning about testing gcov on arm

PATCH Superseded Viktor Mitin 2 participants 4 messages Jul 9, 2019

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xen/doc: remove obsolete warning about testing gcov on arm

Remove obsolete warning about testing gcov on arm. gcov has been fixed and tested with arm hw previously

See commit 6ac66c9

---
 docs/hypervisor-guide/code-coverage.rst | 7 -------
 1 file changed, 7 deletions(-)
docs/hypervisor-guide/code-coverage.rst +0 -7
index 3cebf2d96e..947ee48701 100644
@@ -6,13 +6,6 @@ the coverage of its own basic blocks.  Being a piece of system software rather
 than a userspace, it can't automatically write coverage out to the filesystem,
 so some extra steps are required to collect and process the data.
 
-.. warning::
-
-  Coverage has only been tested on x86 at the moment.  ARM doesn't currently
-  boot when the final binary exceeds 2MB in size, and the coverage build tends
-  to exceeds this limit.
-
-
 Compiling Xen
 -------------
 
Signature · 7 lines
2.17.1


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
#1 lore raw

Hi,

Quoted 4 lines · Viktor Mitin

Remove obsolete warning about testing gcov on arm. gcov has been fixed and tested with arm hw previously

See commit 6ac66c9

This commit...

Quoted 11 lines
---
  docs/hypervisor-guide/code-coverage.rst | 7 -------
  1 file changed, 7 deletions(-)
docs/hypervisor-guide/code-coverage.rst +0 -0
index 3cebf2d96e..947ee48701 100644

docs/hypervisor-guide/code-coverage.rst the coverage of its own basic blocks. Being a piece of system software rather · line 13

Quoted 8 lines
docs/hypervisor-guide/code-coverage.rst +0 -5
@@ -6,13 +6,6 @@ the coverage of its own basic blocks.  Being a piece of system software rather
  than a userspace, it can't automatically write coverage out to the filesystem,
  so some extra steps are required to collect and process the data.
 
-.. warning::
-
-  Coverage has only been tested on x86 at the moment.  ARM doesn't currently
-  boot when the final binary exceeds 2MB in size, and the coverage build tends
-  to exceeds this limit.

... does not address the 2MB part. So part of the warning is still valid here.

Cheers,

Signature · 6 lines
Julien Grall

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
#2 lore raw
Quoted 3 lines · Julien Grall

Hi,

Hi Julien,

Quoted 22 lines · Viktor Mitin
Quoted 4 lines

Remove obsolete warning about testing gcov on arm. gcov has been fixed and tested with arm hw previously

See commit 6ac66c9

This commit...

Quoted 14 lines
---
  docs/hypervisor-guide/code-coverage.rst | 7 -------
  1 file changed, 7 deletions(-)
docs/hypervisor-guide/code-coverage.rst +0 -0
index 3cebf2d96e..947ee48701 100644
@@ -6,13 +6,6 @@ the coverage of its own basic blocks.  Being a piece of system software rather
  than a userspace, it can't automatically write coverage out to the filesystem,
  so some extra steps are required to collect and process the data.
 
Quoted 9 lines

docs/hypervisor-guide/code-coverage.rst the coverage of its own basic blocks. Being a piece of system software rather · line 13

Quoted 5 lines
docs/hypervisor-guide/code-coverage.rst +0 -5
-.. warning::
-
-  Coverage has only been tested on x86 at the moment.  ARM doesn't currently
-  boot when the final binary exceeds 2MB in size, and the coverage build tends
-  to exceeds this limit.

... does not address the 2MB part. So part of the warning is still valid here.

Is it known why do we have this 2MB limit?
Should we fix it?

Thanks

Quoted 4 lines

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#3 lore raw

Hi,

Quoted 37 lines · Viktor Mitin
Quoted 3 lines · Julien Grall

Hi,

Hi Julien,

Quoted 22 lines · Viktor Mitin
Quoted 4 lines

Remove obsolete warning about testing gcov on arm. gcov has been fixed and tested with arm hw previously

See commit 6ac66c9

This commit...

Quoted 14 lines
---
   docs/hypervisor-guide/code-coverage.rst | 7 -------
   1 file changed, 7 deletions(-)
docs/hypervisor-guide/code-coverage.rst +0 -0
index 3cebf2d96e..947ee48701 100644
@@ -6,13 +6,6 @@ the coverage of its own basic blocks.  Being a piece of system software rather
   than a userspace, it can't automatically write coverage out to the filesystem,
   so some extra steps are required to collect and process the data.
 
Quoted 9 lines

docs/hypervisor-guide/code-coverage.rst the coverage of its own basic blocks. Being a piece of system software rather · line 13

Quoted 5 lines
docs/hypervisor-guide/code-coverage.rst +0 -5
-.. warning::
-
-  Coverage has only been tested on x86 at the moment.  ARM doesn't currently
-  boot when the final binary exceeds 2MB in size, and the coverage build tends
-  to exceeds this limit.

... does not address the 2MB part. So part of the warning is still valid here.

Quoted 1 line

Is it known why do we have this 2MB limit?

Without code coverage (and UBSAN) Xen is quite small and can fit in 2MB.

The memory layout is fixed, so we had to define a maximum size. 2MB is convenient because you only deal with only a second-level page-table entry.

Quoted 1 line

Should we fix it?

It should be fixed but not very easy with the current boot code. I am in process to rework the boot/memory code (see [1]). There are more to come.

Once the work is finished, it should be easy to extend the limit to 4MB (or bigger if necessary).

Cheers,

[1] https://lists.xen.org/archives/html/xen-devel/2019-06/msg00588.html

Signature · 6 lines
Julien Grall

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel