xfs: chain bios the right way around in xfs_rw_bdev
PATCH 1/1 xfs: chain bios the right way around in xfs_rw_bdev
We need to chain the earlier bios to the later ones, so that submit_bio_wait waits on the bio that all the completions are dispatched to.
Fixes 6ad5b3255b9e ("xfs: use bios directly to read and write the log recovery buffers")
Reported-by Dave Chinner <[email protected]>
Signed-off-by Christoph Hellwig <[email protected]>
--- fs/xfs/xfs_bio_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/xfs_bio_io.c +1 -1
@@ -43,7 +43,7 @@ xfs_rw_bdev(bio_copy_dev (bio, prev); bio->bi_iter.bi_sector =bio_end_sector (prev); bio->bi_opf = prev->bi_opf; -bio_chain (bio, prev); +bio_chain (prev, bio);submit_bio (prev); }
Signature · 1 line
2.20.1
Quoted 7 lines · Christoph Hellwig
We need to chain the earlier bios to the later ones, so that
submit_bio_waitwaits on the bio that all the completions are dispatched to.Fixes 6ad5b3255b9e ("xfs: use bios directly to read and write the log recovery buffers")Reported-by Dave Chinner <[email protected]>Signed-off-by Christoph Hellwig <[email protected]>
Looks ok to me; anyone else want to add a tested-by?
Reviewed-by Darrick J. Wong <[email protected]>
--D
Quoted 20 lines
--- fs/xfs/xfs_bio_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)fs/xfs/xfs_bio_io.c +1
-1@@ -43,7 +43,7 @@ xfs_rw_bdev(bio_copy_dev (bio, prev); bio->bi_iter.bi_sector =bio_end_sector (prev); bio->bi_opf = prev->bi_opf; -bio_chain (bio, prev); +bio_chain (prev, bio);submit_bio (prev); }Signature · 1 line
2.20.1
Quoted 6 lines · Christoph Hellwig
We need to chain the earlier bios to the later ones, so that
submit_bio_waitwaits on the bio that all the completions are dispatched to.Fixes 6ad5b3255b9e ("xfs: use bios directly to read and write the log recovery buffers")Reported-by Dave Chinner <[email protected]>
Reported-and-Tested-by Dave Chinner <[email protected]>
Signature · 2 lines
Dave Chinner [email protected]