Skip to contentSkip to conversation

gpsd: Don't build without optimization

PATCH Superseded Adrian Bunk 2 participants 5 messages Jul 9, 2019

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpsd: Don't build without optimization

The upstream build system adds -O0 when debug is enabled.

---
 meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb +2 -2
index 6716f402a..43bf25a93 100644
@@ -36,8 +36,8 @@ PACKAGECONFIG[qt] = "qt='yes' qt_versioned=5,qt='no',qtbase"
 EXTRA_OESCONS = " \
     sysroot=${STAGING_DIR_TARGET} \
     libQgpsmm='false' \
-    debug='true' \
-    strip='false' \
+    debug='false' \
+    nostrip='true' \
     chrpath='yes' \
     systemd='${SYSTEMD_OESCONS}' \
     libdir='${libdir}' \
Signature · 1 line
2.17.1
#1 lore raw
Quoted 13 lines · Adrian Bunk

The upstream build system adds -O0 when debug is enabled.

---
 meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb +0 -0
index 6716f402a..43bf25a93 100644

meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb PACKAGECONFIG[qt] = "qt='yes' qt_versioned=5,qt='no',qtbase" · line 40

Quoted 7 lines
meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb +2 -2
@@ -36,8 +36,8 @@ PACKAGECONFIG[qt] = "qt='yes' qt_versioned=5,qt='no',qtbase"
 EXTRA_OESCONS = " \
     sysroot=${STAGING_DIR_TARGET} \
     libQgpsmm='false' \
-    debug='true' \
-    strip='false' \
+    debug='false' \
+    nostrip='true' \

I think this change is improvement over what we have, however it will be nicer if it was knobbed with
DEBUG_BUILD flag, then we can get proper debug info when doing a debug build as user will expect.

Quoted 11 lines
meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb +0 -1
     chrpath='yes' \
     systemd='${SYSTEMD_OESCONS}' \
     libdir='${libdir}' \
--

2.17.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#2 lore raw
Quoted 19 lines · Khem Raj
Quoted 18 lines · Adrian Bunk

The upstream build system adds -O0 when debug is enabled.

---
 meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb +0 -2
index 6716f402a..43bf25a93 100644
@@ -36,8 +36,8 @@ PACKAGECONFIG[qt] = "qt='yes' qt_versioned=5,qt='no',qtbase"
 EXTRA_OESCONS = " \
     sysroot=${STAGING_DIR_TARGET} \
     libQgpsmm='false' \
-    debug='true' \
-    strip='false' \
Quoted 8 lines

meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb PACKAGECONFIG[qt] = "qt='yes' qt_versioned=5,qt='no',qtbase" · line 40

Quoted 2 lines
meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb +2 -0
+    debug='false' \
+    nostrip='true' \

I think this change is improvement over what we have, however it will be nicer if it was knobbed with
DEBUG_BUILD flag, then we can get proper debug info when doing a debug build as user will expect.
...

Sorry for being terse in the description.

For gpsd "debug" means adding -g here, and this is already additionally inserted through the normal OE CFLAGS.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#3 lore raw
Quoted 30 lines · Adrian Bunk
Quoted 19 lines · Khem Raj
Quoted 18 lines · Adrian Bunk

The upstream build system adds -O0 when debug is enabled.

---
 meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb +0 -2
index 6716f402a..43bf25a93 100644
@@ -36,8 +36,8 @@ PACKAGECONFIG[qt] = "qt='yes' qt_versioned=5,qt='no',qtbase"
 EXTRA_OESCONS = " \
     sysroot=${STAGING_DIR_TARGET} \
     libQgpsmm='false' \
-    debug='true' \
-    strip='false' \
Quoted 8 lines

meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb PACKAGECONFIG[qt] = "qt='yes' qt_versioned=5,qt='no',qtbase" · line 40

Quoted 2 lines
meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb +2 -0
+    debug='false' \
+    nostrip='true' \

I think this change is improvement over what we have, however it will be nicer if it was knobbed with
DEBUG_BUILD flag, then we can get proper debug info when doing a debug build as user will expect.
...

Quoted 4 lines

Sorry for being terse in the description.

For gpsd "debug" means adding -g here, and this is already additionally inserted through the normal OE CFLAGS.

I see, then the patch subject and commit msg should be updated, thanks

Quoted 11 lines

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

#4 lore raw
Quoted 31 lines · Khem Raj
Quoted 30 lines · Adrian Bunk
Quoted 27 lines · Khem Raj
Quoted 13 lines · Adrian Bunk

The upstream build system adds -O0 when debug is enabled.

---
 meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb +0 -0
index 6716f402a..43bf25a93 100644

meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb PACKAGECONFIG[qt] = "qt='yes' qt_versioned=5,qt='no',qtbase" · line 40

Quoted 7 lines
meta-oe/recipes-navigation/gpsd/gpsd_3.18.1.bb +2 -2
@@ -36,8 +36,8 @@ PACKAGECONFIG[qt] = "qt='yes' qt_versioned=5,qt='no',qtbase"
 EXTRA_OESCONS = " \
     sysroot=${STAGING_DIR_TARGET} \
     libQgpsmm='false' \
-    debug='true' \
-    strip='false' \
+    debug='false' \
+    nostrip='true' \

I think this change is improvement over what we have, however it will be nicer if it was knobbed with
DEBUG_BUILD flag, then we can get proper debug info when doing a debug build as user will expect.
...

Quoted 6 lines
Quoted 4 lines

Sorry for being terse in the description.

For gpsd "debug" means adding -g here, and this is already additionally inserted through the normal OE CFLAGS.

I see, then the patch subject and commit msg should be updated, thanks

v2 sent with updated commit msg, subject looks OK to me.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed