Skip to contentSkip to conversation

watchdog: digicolor_wdt: Remove unused variable in dc_wdt_probe

PATCH In review Nathan Chancellor 3 participants 3 messages Jul 9, 2019 – Jul 18, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 watchdog: digicolor_wdt: Remove unused variable in dc_wdt_probe

clang warns:

drivers/watchdog/digicolor_wdt.c:121:6: warning: unused variable 'ret' [-Wunused-variable]

        int ret;
            ^

1 warning generated.

It's unused now, remove it.

Fixes cdad26977e3f ("watchdog: digicolor_wdt: drop warning after registering device")
---
 drivers/watchdog/digicolor_wdt.c | 1 -
 1 file changed, 1 deletion(-)
drivers/watchdog/digicolor_wdt.c +0 -1
index 33cda95bd238..073d37867f47 100644
@@ -118,7 +118,6 @@ static int dc_wdt_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
 	struct dc_wdt *wdt;
-	int ret;
 
 	wdt = devm_kzalloc(dev, sizeof(struct dc_wdt), GFP_KERNEL);
 	if (!wdt)
Signature · 1 line
2.22.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Nathan Chancellor

clang warns:

drivers/watchdog/digicolor_wdt.c:121:6: warning: unused variable 'ret' [-Wunused-variable]

        int ret;
            ^
Quoted 8 lines

1 warning generated.

It's unused now, remove it.

Fixes cdad26977e3f ("watchdog: digicolor_wdt: drop warning after registering device")
Quoted 19 lines
---
 drivers/watchdog/digicolor_wdt.c | 1 -
 1 file changed, 1 deletion(-)
drivers/watchdog/digicolor_wdt.c +0 -1
index 33cda95bd238..073d37867f47 100644
@@ -118,7 +118,6 @@ static int dc_wdt_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
 	struct dc_wdt *wdt;
-	int ret;
 
 	wdt = devm_kzalloc(dev, sizeof(struct dc_wdt), GFP_KERNEL);
 	if (!wdt)
Signature · 1 line
2.22.0
Reviewed-by on v1 1/1
#2 lore raw
In reply to Nathan Chancellor
Quoted 6 lines · Nathan Chancellor

clang warns:

drivers/watchdog/digicolor_wdt.c:121:6: warning: unused variable 'ret' [-Wunused-variable]

        int ret;
            ^
Quoted 8 lines

1 warning generated.

It's unused now, remove it.

Fixes cdad26977e3f ("watchdog: digicolor_wdt: drop warning after registering device")

Oops, sorry for missing this. I wonder why buildbot neither did find it... Anyway: