nvme: tcp: depends on CRYPTO_HASH2 for nvme-tcp
PATCH 1/1 nvme: tcp: depends on CRYPTO_HASH2 for nvme-tcp
The tcp host module is now taking those APIs from crypto ahash:
(1) crypto_ahash_final() (2) crypto_ahash_digest() (3) crypto_alloc_ahash()
nvme-tcp should depends on CRYPTO_HASH2.
--- drivers/nvme/host/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/nvme/host/Kconfig +1 -0
@@ -63,6 +63,7 @@ config NVME_TCP tristate "NVM Express over Fabrics TCP host driver" depends on INET depends on BLK_DEV_NVME + depends on CRYPTO_HASH2 select NVME_FABRICS help This provides support for the NVMe over Fabrics protocol using
Signature · 1 line
2.17.1
Sagi Grimberg
maintainerPATCH 1/1 nvme: tcp: depends on CRYPTO_HASH2 for nvme-tcp
Hi Minwoo,
Quoted 6 lines
The tcp host module is now taking those APIs from crypto ahash:
(1) crypto_ahash_final() (2) crypto_ahash_digest() (3) crypto_alloc_ahash()nvme-tcp should depends on
CRYPTO_HASH2.
It actually should depend on CRYPTO_CRC32C because it needs CRC32C.
Quoted 15 lines
Cc Christoph Hellwig <hch at lst.de>Cc Keith Busch <kbusch at kernel.org>Cc Sagi Grimberg <sagi at grimberg.me>Cc Jens Axboe <axboe at fb.com>Signed-off-by Minwoo Im <minwoo.im.dev at gmail.com>--- drivers/nvme/host/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/nvme/host/Kconfig +0
-0
drivers/nvme/host/Kconfig config NVME_TCP · line 66
Quoted 4 lines
drivers/nvme/host/Kconfig +1
-0@@ -63,6 +63,7 @@ config NVME_TCP tristate "NVM Express over Fabrics TCP host driver" depends on INET depends on BLK_DEV_NVME + depends on CRYPTO_HASH2
Lets make it select instead.
Quoted 4 lines
drivers/nvme/host/Kconfig +0
-0select NVME_FABRICS help This provides support for the NVMe over Fabrics protocol using
PATCH 1/1 nvme: tcp: depends on CRYPTO_HASH2 for nvme-tcp
Hi Sagi,
Thanks for your review on this.
Quoted 11 lines · Sagi Grimberg
Hi Minwoo,
Quoted 6 lines
The tcp host module is now taking those APIs from crypto ahash:
(1) crypto_ahash_final() (2) crypto_ahash_digest() (3) crypto_alloc_ahash()nvme-tcp should depends on
CRYPTO_HASH2.It actually should depend on
CRYPTO_CRC32Cbecause it needs CRC32C.
Okay. That looks right for this commit's goal..
Quoted 10 lines
Quoted 10 lines
Cc Christoph Hellwig <hch at lst.de>Cc Keith Busch <kbusch at kernel.org>Cc Sagi Grimberg <sagi at grimberg.me>Cc Jens Axboe <axboe at fb.com>Signed-off-by Minwoo Im <minwoo.im.dev at gmail.com>--- drivers/nvme/host/Kconfig | 1 + 1 file changed, 1 insertion(+)
Quoted 11 lines
drivers/nvme/host/Kconfig config NVME_TCP · line 66
Quoted 9 lines
drivers/nvme/host/Kconfig +1
-0@@ -63,6 +63,7 @@ config NVME_TCP tristate "NVM Express over Fabrics TCP host driver" depends on INET depends on BLK_DEV_NVME + depends on CRYPTO_HASH2Lets make it select instead.
Oh, That would be much easier to use them. Will prepare updated patch soon.
Thanks,