perf diff: Report noisy for cycles diff
PATCH 1/1 perf diff: Report noisy for cycles diff
This patch prints the stddev and hist for the cycles diff of program block. It can help us to understand if the cycles diff is noisy or not.
This patch is inspired by Andi Kleen's patch
https://lwn.net/Articles/600471/
We create new option '-n or --noisy'.
Example:
perf record -b ./div
perf record -b ./div
perf diff -c cycles
# Event 'cycles'
#
# Baseline [Program Block Range] Cycles Diff Shared Object Symbol
# ........ ...................................................................... ................. ................................
#
46.42% [div.c:40 -> div.c:40] 0 div [.] main
46.42% [div.c:42 -> div.c:44] 0 div [.] main
46.42% [div.c:42 -> div.c:39] 0 div [.] main
20.72% [random_r.c:357 -> random_r.c:394] -2 libc-2.27.so [.] __random_r
20.72% [random_r.c:357 -> random_r.c:380] -1 libc-2.27.so [.] __random_r
20.72% [random_r.c:388 -> random_r.c:388] 0 libc-2.27.so [.] __random_r
20.72% [random_r.c:388 -> random_r.c:391] 0 libc-2.27.so [.] __random_r
17.58% [random.c:288 -> random.c:291] 0 libc-2.27.so [.] __random
17.58% [random.c:291 -> random.c:291] 0 libc-2.27.so [.] __random
17.58% [random.c:293 -> random.c:293] 0 libc-2.27.so [.] __random
17.58% [random.c:295 -> random.c:295] 0 libc-2.27.so [.] __random
17.58% [random.c:295 -> random.c:295] 0 libc-2.27.so [.] __random
17.58% [random.c:298 -> random.c:298] 0 libc-2.27.so [.] __random
8.33% [div.c:22 -> div.c:25] 0 div [.] compute_flag
8.33% [div.c:27 -> div.c:28] 0 div [.] compute_flag
4.80% [rand.c:26 -> rand.c:27] 0 libc-2.27.so [.] rand
4.80% [rand.c:28 -> rand.c:28] 0 libc-2.27.so [.] rand
2.14% [rand@plt+0 -> rand@plt+0] 0 div [.] rand@pltWhen we enable the option '-n', the output is
perf diff -c cycles -n
# Event 'cycles'
#
# Baseline [Program Block Range]/Cycles Diff/stddev/Hist Shared Object Symbol
# ........ ................................................................................ ................. ................................
#
46.42% [div.c:40 -> div.c:40] 0 ± 40.2% ▂███▁▂▁▁ div [.] main
46.42% [div.c:42 -> div.c:44] 0 ±100.0% ▁▁▁▁█▁▁▁ div [.] main
46.42% [div.c:42 -> div.c:39] 0 ± 15.3% ▃▃▂▆▃▂█▁ div [.] main
20.72% [random_r.c:357 -> random_r.c:394] -2 ± 20.1% ▁▄▄▅▂▅█▁ libc-2.27.so [.] __random_r
20.72% [random_r.c:357 -> random_r.c:380] -1 ± 20.9% ▁▆▇▁█▅▇█ libc-2.27.so [.] __random_r
20.72% [random_r.c:388 -> random_r.c:388] 0 ± 0.0% libc-2.27.so [.] __random_r
20.72% [random_r.c:388 -> random_r.c:391] 0 ± 88.0% ▁▁▁▁▁▁▁█ libc-2.27.so [.] __random_r
17.58% [random.c:288 -> random.c:291] 0 ± 29.3% ▁████▁█▁ libc-2.27.so [.] __random
17.58% [random.c:291 -> random.c:291] 0 ± 29.3% ▁████▁▁█ libc-2.27.so [.] __random
17.58% [random.c:293 -> random.c:293] 0 ± 29.3% ▁████▁▁█ libc-2.27.so [.] __random
17.58% [random.c:295 -> random.c:295] 0 ± 0.0% libc-2.27.so [.] __random
17.58% [random.c:295 -> random.c:295] 0 ± 0.0% libc-2.27.so [.] __random
17.58% [random.c:298 -> random.c:298] 0 ± 0.0% libc-2.27.so [.] __random
8.33% [div.c:22 -> div.c:25] 0 ± 29.3% ▁████▁█▁ div [.] compute_flag
8.33% [div.c:27 -> div.c:28] 0 ± 48.8% ▁██▁▁▁█▁ div [.] compute_flag
4.80% [rand.c:26 -> rand.c:27] 0 ± 29.3% ▁████▁█▁ libc-2.27.so [.] rand
4.80% [rand.c:28 -> rand.c:28] 0 ± 0.0% libc-2.27.so [.] rand
2.14% [rand@plt+0 -> rand@plt+0] 0 ± 0.0% div [.] rand@plt--- tools/perf/Documentation/perf-diff.txt | 5 ++ tools/perf/builtin-diff.c | 94 +++++++++++++++++++++++--- tools/perf/util/Build | 1 + tools/perf/util/annotate.c | 4 ++ tools/perf/util/annotate.h | 2 + tools/perf/util/sort.h | 2 + tools/perf/util/spark.c | 35 ++++++++++ tools/perf/util/spark.h | 6 ++ tools/perf/util/stat.c | 37 ++++++++++ tools/perf/util/stat.h | 10 +++ tools/perf/util/symbol.h | 2 + 11 files changed, 187 insertions(+), 11 deletions(-) create mode 100644 tools/perf/util/spark.c create mode 100644 tools/perf/util/spark.h
tools/perf/Documentation/perf-diff.txt +5 -0
@@ -95,6 +95,11 @@ OPTIONS diff.compute config option. See COMPARISON METHODS section for more info. +-n:: +--noisy:: + Show cycles noisy data, such as stddev and hists. Should use + with '-c cycles'. + -p:: --period:: Show period values for both compared hist entries.
tools/perf/builtin-diff.c +83 -11
171 lines not on this page · raw message
tools/perf/util/Build +1 -0
@@ -91,6 +91,7 @@ perf-y += cloexec.o perf-y += call-path.o perf-y += rwsem.o perf-y += thread-stack.o +perf-y += spark.o perf-$(CONFIG_AUXTRACE) += auxtrace.o perf-$(CONFIG_AUXTRACE) += intel-pt-decoder/ perf-$(CONFIG_AUXTRACE) += intel-pt.o
tools/perf/util/annotate.c +4 -0
@@ -847,6 +847,10 @@ static int __symbol__account_cycles(struct cyc_hist *ch, ch[offset].start < start)return 0 ; } + +if (ch[offset].num <NUM_SPARK_VALS ) + ch[offset].cycles_spark[ch[offset].num] = cycles; + ch[offset].have_start = have_start; ch[offset].start = start; ch[offset].cycles += cycles;
tools/perf/util/annotate.h +2 -0
@@ -11,6 +11,7 @@#include <pthread.h> #include <asm/bug.h> #include "symbol_conf.h" +#include "stat.h" struct hist_browser_timer ;struct hist_entry ;
@@ -235,6 +236,7 @@ struct cyc_hist {u64 cycles_aggr;u64 cycles_max;u64 cycles_min; +u64 cycles_spark[NUM_SPARK_VALS ];u32 num;u32 num_aggr;u8 have_start;
tools/perf/util/sort.h +2 -0
@@ -23,6 +23,7 @@#include "parse-events.h" #include "hist.h" #include "srcline.h" +#include "stat.h" struct thread ;
@@ -83,6 +84,7 @@ struct hist_entry_diff {/* PERF_HPP_DIFF__CYCLES */ s64 cycles; }; +struct stats stats; };struct hist_entry_ops {
tools/perf/util/spark.c new file +35 -0
@@ -0,0 +1,35 @@ +#include <stdio.h> +#include <limits.h> +#include <string.h> +#include <stdlib.h> +#include "spark.h" +#include "stat.h" + +#define NUM_SPARKS 8 +#define SPARK_SHIFT 8 + +/* Print spark lines on outf for numval values in val. */ +int print_spark (char *bf,int size,unsigned long *val,int numval) +{ +static const char *ticks[NUM_SPARKS ] = { +"▁" ,"▂" ,"▃" ,"▄" ,"▅" ,"▆" ,"▇" ,"█" + }; +int i, printed =0 ; +unsigned long min =ULONG_MAX , max =0 , f; + +for (i =0 ; i < numval; i++) { +if (val[i] < min) + min = val[i]; +if (val[i] > max) + max = val[i]; + } + f = ((max - min) <<SPARK_SHIFT ) / (NUM_SPARKS -1 ); +if (f <1 ) + f =1 ; +for (i =0 ; i < numval; i++) { + printed +=scnprintf (bf + printed, size - printed,"%s" , + ticks[((val[i] - min) <<SPARK_SHIFT ) / f]); + } + +return printed; +}
tools/perf/util/spark.h new file +6 -0
@@ -0,0 +1,6 @@ +#ifndef SPARK_H +#define SPARK_H 1 + +int print_spark (char *bf,int size,unsigned long *val,int numval); + +#endif
tools/perf/util/stat.c +37 -0
@@ -6,11 +6,16 @@#include "evlist.h" #include "evsel.h" #include "thread_map.h" +#include "spark.h" #include <linux/zalloc.h> void update_stats (struct stats *stats,u64 val) {double delta; +int n = stats->n; + +if (n <NUM_SPARK_VALS ) + stats->svals[n] = val; stats->n++; delta = val - stats->mean;
@@ -24,6 +29,38 @@ void update_stats(struct stats *stats, u64 val) stats->min = val; } +static int all_zero (unsigned long *vals,int len) +{ +int i; + +for (i =0 ; i < len; i++) +if (vals[i] !=0 ) +return 0 ; +return 1 ; +} + +int print_stat_spark (char *bf,int size,struct stats *stat) +{ +int len, printed; + +if (stat->n <=1 ) +return 0 ; + + len = stat->n; +if (len >NUM_SPARK_VALS ) + len =NUM_SPARK_VALS ; +if (all_zero (stat->svals, len)) +return 0 ; + + printed =print_spark (bf, size, stat->svals, len); + printed +=scnprintf (bf + printed, size - printed," " ); + +if (stat->n >NUM_SPARK_VALS ) + printed +=scnprintf (bf + printed, size - printed,".." ); + +return printed; +} +double avg_stats (struct stats *stats) {return stats->mean;
tools/perf/util/stat.h +10 -0
@@ -8,14 +8,18 @@#include <sys/time.h> #include <sys/resource.h> #include <sys/wait.h> +#include <stdio.h> #include "xyarray.h" #include "rblist.h" #include "perf.h" #include "event.h" +#define NUM_SPARK_VALS 8/* support spark line on first N items */ +struct stats {double n, mean, M2;u64 max, min; +unsigned long svals[NUM_SPARK_VALS ]; };enum perf_stat_evsel_id {
@@ -134,13 +138,19 @@ double avg_stats(struct stats *stats);double stddev_stats (struct stats *stats);double rel_stddev_stats (double stddev,double avg); +int print_stat_spark (char *bf,int size,struct stats *stat); +static inline void init_stats (struct stats *stats) { +int i; + stats->n =0.0 ; stats->mean =0.0 ; stats->M2 =0.0 ; stats->min = (u64) -1 ; stats->max =0 ; +for (i =0 ; i <NUM_SPARK_VALS ; i++) + stats->svals[i] =0 ; }struct perf_evsel ;
tools/perf/util/symbol.h +2 -0
@@ -12,6 +12,7 @@#include "branch.h" #include "path.h" #include "symbol_conf.h" +#include "stat.h" #ifdef HAVE_LIBELF_SUPPORT #include <libelf.h>
@@ -137,6 +138,7 @@ struct block_info {u64 end;u64 cycles;u64 cycles_aggr; +u64 cycles_spark[NUM_SPARK_VALS ];int num;int num_aggr;refcount_t refcnt;
Signature · 1 line
2.17.1
Quoted 3 lines · Jin Yao
This patch prints the stddev and hist for the cycles diff of program block. It can help us to understand if the cycles diff is noisy or not.
I'm getting compile error:
CC builtin-diff.obuiltin-diff.c: In function ‘compute_cycles_diff’:
builtin-diff.c:712:10: error: taking the absolute value of unsigned type ‘u64’ {aka ‘long unsigned int’} has no effect [-Werror=absolute-value]
712 | labs(pair->block_info->cycles_spark[i] -
| ^~~~cc1: all warnings being treated as errors
mv: cannot stat './.builtin-diff.o.tmp': No such file or directory
jirka
Quoted 7 lines · Jiri Olsa
Quoted 3 lines · Jin Yao
This patch prints the stddev and hist for the cycles diff of program block. It can help us to understand if the cycles diff is noisy or not.
I'm getting compile error:
Quoted 9 lines
CC builtin-diff.o
builtin-diff.c: In function ‘compute_cycles_diff’:
builtin-diff.c:712:10: error: taking the absolute value of unsigned type ‘u64’ {aka ‘long unsigned int’} has no effect [-Werror=absolute-value]712 | labs(pair->block_info->cycles_spark[i] - | ^~~~cc1: all warnings being treated as errors
mv: cannot stat './.builtin-diff.o.tmp': No such file or directory
Oh, sorry about that. My gcc (gcc version 7.4.0 (Ubuntu 7.4.0-1ubuntu1~18.04.1)) didn't report this error. :(
u64 - u64 is u64. I should define it as s64.
Thanks for reminding me.
Thanks
Jin Yao
Quoted 2 lines
jirka