Skip to contentSkip to conversation

mt7601u: use params->ssn value directly

PATCH In review Stanislaw Gruszka 3 participants 3 messages Jul 12, 2019 – Jul 24, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mt7601u: use params->ssn value directly

There is no point to use pointer to params->ssn.

---
 drivers/net/wireless/mediatek/mt7601u/main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/mediatek/mt7601u/main.c +2 -2
index 89a7b1234ffb..72e608cc53af 100644
@@ -351,7 +351,7 @@ mt76_ampdu_action(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
 	struct ieee80211_sta *sta = params->sta;
 	enum ieee80211_ampdu_mlme_action action = params->action;
 	u16 tid = params->tid;
-	u16 *ssn = &params->ssn;
+	u16 ssn = params->ssn;
 	struct mt76_sta *msta = (struct mt76_sta *) sta->drv_priv;
 
 	WARN_ON(msta->wcid.idx > GROUP_WCID(0));
@@ -371,7 +371,7 @@ mt76_ampdu_action(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
 	case IEEE80211_AMPDU_TX_STOP_FLUSH_CONT:
 		break;
 	case IEEE80211_AMPDU_TX_START:
-		msta->agg_ssn[tid] = *ssn << 4;
+		msta->agg_ssn[tid] = ssn << 4;
 		ieee80211_start_tx_ba_cb_irqsafe(vif, sta->addr, tid);
 		break;
 	case IEEE80211_AMPDU_TX_STOP_CONT:
Signature · 1 line
2.20.1
#2 lore raw
In reply to Stanislaw Gruszka
Quoted 4 lines · Stanislaw Gruszka

There is no point to use pointer to params->ssn.

Patch applied to wireless-drivers-next.git, thanks.

f0248ec49bde mt7601u: use params->ssn value directly

Signature · 3 lines
https://patchwork.kernel.org/patch/11042213/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches