Skip to contentSkip to conversation

migration/postcopy: fix document of postcopy_send_discard_bm_ram()

PATCH In review Wei Yang 2 participants 3 messages Jul 15, 2019

lore
Share & tools
lore

Wei Yang

author
#0 lore raw

PATCH v2 1/1 migration/postcopy: fix document of postcopy_send_discard_bm_ram()

Commit 6b6712efccd3 ('ram: Split dirty bitmap by RAMBlock') changes the parameter of postcopy_send_discard_bm_ram(), while left the document part untouched.

This patch correct the document and fix two typo by hand.

---
v2: fix typo in function name, pointed by Dave

---
 migration/ram.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
migration/ram.c +2 -3
index 246efe6939..e019c925b2 100644
@@ -2763,8 +2763,7 @@ void ram_postcopy_migrated_memory_release(MigrationState *ms)
  *
  * @ms: current migration state
  * @pds: state for postcopy
- * @start: RAMBlock starting page
- * @length: RAMBlock size
+ * @block: RAMBlock to discard
  */
 static int postcopy_send_discard_bm_ram(MigrationState *ms,
                                         PostcopyDiscardState *pds,
@@ -2961,7 +2960,7 @@ static void postcopy_chunk_hostpages_pass(MigrationState *ms, bool unsent_pass,
 }
 
 /**
- * postcopy_chuck_hostpages: discrad any partially sent host page
+ * postcopy_chunk_hostpages: discard any partially sent host page
  *
  * Utility for the outgoing postcopy code.
  *
Signature · 1 line
2.17.1
author Reviewed-by Philippe Mathieu-Daudé on v2 1/1
#1 lore raw
Quoted 7 lines · Wei Yang

Commit 6b6712efccd3 ('ram: Split dirty bitmap by RAMBlock') changes the parameter of postcopy_send_discard_bm_ram(), while left the document part untouched.

This patch correct the document and fix two typo by hand.

Oops, I missed this. Sorry Philippe :)

Quoted 31 lines

---
v2: fix typo in function name, pointed by Dave
---
migration/ram.c | 5 ++---

1 file changed, 2 insertions(+), 3 deletions(-)
migration/ram.c +2 -3
index 246efe6939..e019c925b2 100644
@@ -2763,8 +2763,7 @@ void ram_postcopy_migrated_memory_release(MigrationState *ms)
 *
 * @ms: current migration state
 * @pds: state for postcopy
- * @start: RAMBlock starting page
- * @length: RAMBlock size
+ * @block: RAMBlock to discard
 */
 static int postcopy_send_discard_bm_ram(MigrationState *ms,
                                        PostcopyDiscardState *pds,
@@ -2961,7 +2960,7 @@ static void postcopy_chunk_hostpages_pass(MigrationState *ms, bool unsent_pass,
 }
 
 /**
- * postcopy_chuck_hostpages: discrad any partially sent host page
+ * postcopy_chunk_hostpages: discard any partially sent host page
 *
 * Utility for the outgoing postcopy code.
 *
Signature · 1 line
2.17.1
Signature · 2 lines
Wei Yang
Help you, Help me
Reviewed-by on v2 1/1
#2 lore raw
In reply to Wei Yang
Quoted 7 lines · * Wei Yang ([email protected]) wrote:

Commit 6b6712efccd3 ('ram: Split dirty bitmap by RAMBlock') changes the parameter of postcopy_send_discard_bm_ram(), while left the document part untouched.

This patch correct the document and fix two typo by hand.

Quoted 32 lines

---
v2: fix typo in function name, pointed by Dave

---
 migration/ram.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
migration/ram.c +2 -3
index 246efe6939..e019c925b2 100644
@@ -2763,8 +2763,7 @@ void ram_postcopy_migrated_memory_release(MigrationState *ms)
  *
  * @ms: current migration state
  * @pds: state for postcopy
- * @start: RAMBlock starting page
- * @length: RAMBlock size
+ * @block: RAMBlock to discard
  */
 static int postcopy_send_discard_bm_ram(MigrationState *ms,
                                         PostcopyDiscardState *pds,
@@ -2961,7 +2960,7 @@ static void postcopy_chunk_hostpages_pass(MigrationState *ms, bool unsent_pass,
 }
 
 /**
- * postcopy_chuck_hostpages: discrad any partially sent host page
+ * postcopy_chunk_hostpages: discard any partially sent host page
  *
  * Utility for the outgoing postcopy code.
  *
Signature · 1 line
2.17.1

--
Dr. David Alan Gilbert / [email protected] / Manchester, UK