staging: rtl8723bs: core: Change return type of init_mlme_ext_priv
PATCH 1/1 staging: rtl8723bs: core: Change return type of init_mlme_ext_priv
As init_mlme_ext_priv function always returns SUCCESS , We can change return type from int to void.
Fixes below issue identified by coccicheck drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:464:5-8: Unneeded
variable: "res". Return "_SUCCESS" on line 492
Signed-off-by Hariprasad Kelam <[email protected]>
--- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 6 +----- drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 6 +----- 3 files changed, 3 insertions(+), 11 deletions(-)
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +1 -5
@@ -459,9 +459,8 @@ static u8 init_channel_set(struct adapter *padapter, u8 ChannelPlan, RT_CHANNEL_return chanset_size; } -int init_mlme_ext_priv (struct adapter *padapter) +void init_mlme_ext_priv (struct adapter *padapter) { -int res = _SUCCESS;struct registry_priv *pregistrypriv = &padapter->registrypriv;struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
@@ -488,9 +487,6 @@ int init_mlme_ext_priv(struct adapter *padapter)#ifdef DBG_FIXED_CHAN pmlmeext->fixed_chan =0xFF ;#endif - -return res; - }void free_mlme_ext_priv (struct mlme_ext_priv *pmlmeext)
drivers/staging/rtl8723bs/include/rtw_mlme_ext.h +1 -1
@@ -535,7 +535,7 @@ struct mlme_ext_priv };void init_mlme_default_rate_set (struct adapter *padapter); -int init_mlme_ext_priv (struct adapter *padapter); +void init_mlme_ext_priv (struct adapter *padapter);int init_hw_mlme_ext (struct adapter *padapter);void free_mlme_ext_priv (struct mlme_ext_priv *pmlmeext);extern void init_mlme_ext_timer (struct adapter *padapter);
drivers/staging/rtl8723bs/os_dep/os_intfs.c +1 -5
@@ -768,11 +768,7 @@ u8 rtw_init_drv_sw(struct adapter *padapter) goto exit; } -if (init_mlme_ext_priv (padapter) == _FAIL) { -RT_TRACE (_module_os_intfs_c_, _drv_err_, ("\n Can't init mlme_ext_priv\n" )); - ret8 = _FAIL; - goto exit; - } +init_mlme_ext_priv (padapter);if (_rtw_init_xmit_priv (&padapter->xmitpriv, padapter) == _FAIL) {DBG_871X ("Can't _rtw_init_xmit_priv\n" );
Signature · 1 line
2.7.4