Skip to contentSkip to conversation

sched/core: fix double fetch in sched_copy_attr()

PATCH New JingYi Hou 1 participant 1 message Jul 16, 2019 Scheduler

lore
Share & tools
lore

JingYi Hou

author
#0 lore raw

PATCH 1/1 sched/core: fix double fetch in sched_copy_attr()

In sched_copy_attr(), attr->size was fetched twice in get_user() and copy_from_user().

If change it between two fetches may cause security problems or unexpected behaivor.

We can apply the same pattern used in perf_copy_attr(). That is, use value fetched first time to overwrite it after second fetch.

---
 kernel/sched/core.c | 2 ++
 1 file changed, 2 insertions(+)
kernel/sched/core.c +2 -0
index 2b037f195473..60088b907ef4 100644
@@ -4945,6 +4945,8 @@ static int sched_copy_attr(struct sched_attr __user *uattr, struct sched_attr *a
 	ret = copy_from_user(attr, uattr, size);
 	if (ret)
 		return -EFAULT;
+
+	attr->size = size;
 
 	if ((attr->sched_flags & SCHED_FLAG_UTIL_CLAMP) &&
 	    size < SCHED_ATTR_SIZE_VER1)

--
2.20.1