Skip to contentSkip to conversation

ARCv2: Don't pretend we may set U & DE bits in STATUS32 with kflag

PATCH In review Alexey Brodkin 2 participants 2 messages Jul 16, 2019 – Jul 17, 2019 Synopsys ARC architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARCv2: Don't pretend we may set U & DE bits in STATUS32 with kflag

As per PRM "kflag" instruction doesn't change state of DE-flag ("Delayed branch is pending") and U-flag ("User mode") in STATUS32 register so let's not act as if we can affect those bits.

Signed-off-by Alexey Brodkin <abrodkin at synopsys.com>
---
 arch/arc/include/asm/entry-arcv2.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arc/include/asm/entry-arcv2.h +1 -1
index 225e7df2d8ed..6558e2edb583 100644
@@ -237,7 +237,7 @@
 
 .macro FAKE_RET_FROM_EXCPN
 	lr      r9, [status32]
-	bic     r9, r9, (STATUS_U_MASK|STATUS_DE_MASK|STATUS_AE_MASK)
+	bic     r9, r9, STATUS_AE_MASK
 	or      r9, r9, STATUS_IE_MASK
 	kflag   r9
 .endm
Signature · 1 line
2.16.2
#1 lore raw
Quoted 3 lines · Alexey Brodkin

As per PRM "kflag" instruction doesn't change state of DE-flag ("Delayed branch is pending") and U-flag ("User mode") in STATUS32 register so let's not act as if we can affect those bits.

I understand the motivation and indeed bits not writable by kflag should be removed. But what if we do need to clear those bits out from status32 (assuming they exist there in first place) and that kflag might not be the right instruction to do that.
So the question to ask is do we need to clear U and DE bits from status32 and answer from reading the PRM is no, we don't have to, as those are cleared already when an exception is taken.

The likely reason this code is because back in arc700 days we used to have a different version of this macro which atleast in original code relied on using the pre-exception status32 (in pt_regs) - and that could easily have U and/or DE set based hence needed clearing.

.macro FAKE_RET_FROM_EXCPN reg

ld \reg, [sp, PT_status32]
and \reg, \reg, ~(STATUS_U_MASK|STATUS_DE_MASK) or \reg, \reg, STATUS_L_MASK
sr \reg, [erstatus]
mov \reg, 55f
sr \reg, [eret]

rtie
55:
.endm

This is not needed (even in arc700) if we are using the current "in-exception" status32 for doing the early return.

Long story short, your patch is correct but we need to explain better why it is. I've applied it locally with slight tweak to changelog to that effect.

Quoted 18 lines
Signed-off-by Alexey Brodkin <abrodkin at synopsys.com>
---
 arch/arc/include/asm/entry-arcv2.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arc/include/asm/entry-arcv2.h +1 -1
index 225e7df2d8ed..6558e2edb583 100644
@@ -237,7 +237,7 @@
 
 .macro FAKE_RET_FROM_EXCPN
 	lr      r9, [status32]
-	bic     r9, r9, (STATUS_U_MASK|STATUS_DE_MASK|STATUS_AE_MASK)
+	bic     r9, r9, STATUS_AE_MASK
 	or      r9, r9, STATUS_IE_MASK
 	kflag   r9
 .endm