ipv6: rt6_check should return NULL if 'from' is NULL
Subsystems (3)
David Ahern
maintainerPATCH 1/1 ipv6: rt6_check should return NULL if 'from' is NULL
From: David Ahern <[email protected]>
Paul reported that l2tp sessions were broken after the commit referenced in the Fixes tag. Prior to this commit rt6_check returned NULL if the rt6_info 'from' was NULL - ie., the dst_entry was disconnected from a FIB entry. Restore that behavior.
Fixes 93531c674315 ("net/ipv6: separate handling of FIB entries from dst based routes")
Reported-by Paul Donohue <[email protected]>
Tested-by Paul Donohue <[email protected]>
Signed-off-by David Ahern <[email protected]>
--- net/ipv6/route.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/ipv6/route.c +1 -1
@@ -2563,7 +2563,7 @@ static struct dst_entry *rt6_check(struct rt6_info *rt, {u32 rt_cookie =0 ; -if ((from && !fib6_get_cookie_safe (from, &rt_cookie)) || +if (!from || !fib6_get_cookie_safe (from, &rt_cookie) || rt_cookie != cookie)return NULL ;
Signature · 1 line
2.11.0
David Miller
maintainerFrom: David Ahern <[email protected]>
Date: Wed, 17 Jul 2019 15:08:43 -0700
Quoted 11 lines
From: David Ahern <[email protected]>
Paul reported that l2tp sessions were broken after the commit referenced in the Fixes tag. Prior to this commit
rt6_checkreturned NULL if thert6_info'from' was NULL - ie., thedst_entrywas disconnected from a FIB entry. Restore that behavior.Fixes 93531c674315 ("net/ipv6: separate handling of FIB entries from dst based routes")Reported-by Paul Donohue <[email protected]>Tested-by Paul Donohue <[email protected]>Signed-off-by David Ahern <[email protected]>
Applied and queued up for -stable, thanks.