RFC: move kernel/memremap.c to mm/

DISCUSSION Christoph Hellwig 2 participants 2 messages Jul 18, 2019 Memory management

Share & tools

Christoph Hellwig

author

2019-07-18 05:48 UTC #0 lore raw

Hi Dan,

was there any really good reason to have memremap.c in kernel/ back when you started it? It seems to be pretty much tried into the mm infrastructure, and I keep mistyping the path. Would you mind a simple git-mv patch after -rc1 to move it to mm/ ?

Dan Williams

2019-07-18 06:04 UTC #1 lore raw

Quoted 7 lines · Christoph Hellwig

Hi Dan,
was there any really good reason to have memremap.c in kernel/ back when you started it? It seems to be pretty much tried into the mm infrastructure, and I keep mistyping the path. Would you mind a simple git-mv patch after -rc1 to move it to mm/ ?

No complaints from me. It ended up there because it was originally just the common memremap implementation always built with CONFIG_HAS_IOMEM.

Arguably we should have done this move right after commit 5981690ddb8f ("memremap: split devm_memremap_pages() and memremap() infrastructure").