Skip to contentSkip to conversation

drm/amdgpu: Remove undefined amdgpu_device_parse_faked_did

PATCH In review [email protected] 2 participants 2 messages Jul 18, 2019 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu: Remove undefined amdgpu_device_parse_faked_did

From: Leo Li <[email protected]>

This forward declare was added for no apparent reason. Remove it to resolve this warning:

drivers/gpu/drm//amd/amdgpu/amdgpu_device.c:131:13: warning: ‘amdgpu_device_parse_faked_did’ declared ‘static’ but never defined [-Wunused-function]
static void amdgpu_device_parse_faked_did(struct amdgpu_device *adev);

Cc Michel Dänzer <[email protected]>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +0 -1
index 76106ad8ac84..4425ff06ecc4 100644
@@ -128,7 +128,6 @@ static DEVICE_ATTR(pcie_replay_count, S_IRUGO,
 		amdgpu_device_get_pcie_replay_count, NULL);
 
 static void amdgpu_device_get_pcie_info(struct amdgpu_device *adev);
-static void amdgpu_device_parse_faked_did(struct amdgpu_device *adev);
 
 /**
  * amdgpu_device_is_px - Is the device is a dGPU with HG/PX power control
Signature · 6 lines
2.22.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): [email protected]

Reviewed-by
#2 lore raw
Quoted 20 lines · On 2019-07-18 6:17 p.m., [email protected] wrote:

From: Leo Li <[email protected]>

This forward declare was added for no apparent reason. Remove it to resolve this warning:

drivers/gpu/drm//amd/amdgpu/amdgpu_device.c:131:13: warning: ‘amdgpu_device_parse_faked_did’ declared ‘static’ but never defined [-Wunused-function]
static void amdgpu_device_parse_faked_did(struct amdgpu_device *adev);

Cc Michel Dänzer <[email protected]>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +0 -0
index 76106ad8ac84..4425ff06ecc4 100644

drivers/gpu/drm/amd/amdgpu/amdgpu_device.c static DEVICE_ATTR(pcie_replay_count, S_IRUGO, · line 133

Quoted 7 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +0 -1
@@ -128,7 +128,6 @@ static DEVICE_ATTR(pcie_replay_count, S_IRUGO,
 		amdgpu_device_get_pcie_replay_count, NULL);
 
 static void amdgpu_device_get_pcie_info(struct amdgpu_device *adev);
-static void amdgpu_device_parse_faked_did(struct amdgpu_device *adev);
 
 /**
  * amdgpu_device_is_px - Is the device is a dGPU with HG/PX power control

Thanks Leo.

Signature · 6 lines
Earthling Michel Dänzer               |              https://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx