Skip to contentSkip to conversation

mm/sparsemem: introduce struct mem_section_usage

PATCH Michal Hocko 3 participants 4 messages Jul 19, 2019 – Jul 22, 2019 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 20190718225757.ndUBg%[email protected]

#1 lore raw
Quoted 4 lines · Andrew Morton

From: Dan Williams <[email protected]>
Subject: mm/sparsemem: introduce struct mem_section_usage

Patch series "mm: Sub-section memory hotplug support", v10.

Has this been properly reviewed after the last rebase and is this actually ready for merging? I have seen some follow up fixes
http://lkml.kernel.org/r/[email protected]
and do not see those patches being in the pipe line. Or have they been merged?

Signature · 2 lines
Michal Hocko
SUSE Labs
#2 lore raw
Quoted 6 lines · Michal Hocko

Has this been properly reviewed after the last rebase and is this actually ready for merging? I have seen some follow up fixes
http://lkml.kernel.org/r/[email protected]
and do not see those patches being in the pipe line. Or have they been merged?

It looks to me from the patches that Andrew updated them with

https://lore.kernel.org/linux-mm/[email protected]/

and

https://lore.kernel.org/linux-mm/20190718120543.GA8500@linux/

so it looks good to me.

But that's just from reading the patches, I might have missed something and I don't see the history.

Linus

#3 lore raw
Quoted 13 lines · Linus Torvalds
Quoted 6 lines · Michal Hocko

Has this been properly reviewed after the last rebase and is this actually ready for merging? I have seen some follow up fixes
http://lkml.kernel.org/r/[email protected]
and do not see those patches being in the pipe line. Or have they been merged?

It looks to me from the patches that Andrew updated them with

https://lore.kernel.org/linux-mm/[email protected]/

Quoted 8 lines

and

https://lore.kernel.org/linux-mm/20190718120543.GA8500@linux/

so it looks good to me.

But that's just from reading the patches, I might have missed something and I don't see the history.

I verified them. The rebase contents are identical to the manual merge I did between my dev branch and hmm.git before sending them to Andrew. So no lingering surprises that I can see.

#4 lore raw
In reply to Linus Torvalds
Quoted 12 lines · Linus Torvalds
Quoted 6 lines · Michal Hocko

Has this been properly reviewed after the last rebase and is this actually ready for merging? I have seen some follow up fixes
http://lkml.kernel.org/r/[email protected]
and do not see those patches being in the pipe line. Or have they been merged?

It looks to me from the patches that Andrew updated them with

https://lore.kernel.org/linux-mm/[email protected]/

Quoted 8 lines

and

https://lore.kernel.org/linux-mm/20190718120543.GA8500@linux/

so it looks good to me.

But that's just from reading the patches, I might have missed something and I don't see the history.

Thanks for double checking! It's good that follow up fixes didn't fall through cracks. Anyway I have to say that I find merging shortly after a non-trivial rebase as risky and rushed through. I am not really convinced this is so urgent to warrant such a step.

I hoped to get to it eventually and give it a deeper review because this is a non trivial stuff. I am sorry but I couldn't have done that yet (busy with other stuff and being OOO for quite some time).

Signature · 2 lines
Michal Hocko
SUSE Labs