Skip to contentSkip to conversation

habanalabs: power management through sysfs is only for GOYA

PATCH In review Oded Gabbay 2 participants 2 messages Jul 21, 2019 – Jul 22, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 habanalabs: power management through sysfs is only for GOYA

The ability of setting power management properties by the system administrator (through sysfs properties) is only relevant for the GOYA ASIC. Therefore, move the relevant sysfs properties to the GOYA sysfs specific file, to make the properties appear in sysfs only for GOYA cards.

---
 .../ABI/testing/sysfs-driver-habanalabs       |  5 +-
 drivers/misc/habanalabs/goya/goya_hwmgr.c     | 98 +++++++++++++++++++
 drivers/misc/habanalabs/sysfs.c               | 98 -------------------
 3 files changed, 101 insertions(+), 100 deletions(-)
Documentation/ABI/testing/sysfs-driver-habanalabs +3 -2
index 8d1c81cc9167..782df74042ed 100644
@@ -57,6 +57,7 @@ KernelVersion:  5.1
 Contact:        [email protected]
 Description:    Allows the user to set the maximum clock frequency for MME, TPC
                 and IC when the power management profile is set to "automatic".
+                This property is valid only for the Goya ASIC family
 
 What:           /sys/class/habanalabs/hl<n>/ic_clk
 Date:           Jan 2019
@@ -127,8 +128,8 @@ Description:    Power management profile. Values are "auto", "manual". In "auto"
                 the max clock frequency to a low value when there are no user
                 processes that are opened on the device's file. In "manual"
                 mode, the user sets the maximum clock frequency by writing to
-                ic_clk, mme_clk and tpc_clk
-
+                ic_clk, mme_clk and tpc_clk. This property is valid only for
+                the Goya ASIC family
 
 What:           /sys/class/habanalabs/hl<n>/preboot_btl_ver
 Date:           Jan 2019
drivers/misc/habanalabs/goya/goya_hwmgr.c +98 -0

116 lines not on this page · raw message

drivers/misc/habanalabs/sysfs.c +0 -98

122 lines not on this page · raw message

Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw

From: Oded Gabbay <[email protected]>
Sent: Sunday, 21 July 2019 17:31

Quoted 6 lines

The ability of setting power management properties by the system administrator (through sysfs properties) is only relevant for the GOYA ASIC. Therefore, move the relevant sysfs properties to the GOYA sysfs specific file, to make the properties appear in sysfs only for GOYA cards.