video: fbdev: pvr2fb: remove unnecessary comparison of unsigned integer with < 0
PATCH 1/1 video: fbdev: pvr2fb: remove unnecessary comparison of unsigned integer with < 0
There is no need to compare *var->xoffset* or *var->yoffset* with < 0 because such variables are of type unsigned, making it impossible to hold a negative value.
Fix this by removing such comparisons.
Addresses-Coverity-ID: 1451964 ("Unsigned compared against 0")
Signed-off-by Gustavo A. R. Silva <[email protected]>
--- drivers/video/fbdev/pvr2fb.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/video/fbdev/pvr2fb.c +2 -4
@@ -458,13 +458,11 @@ static int pvr2fb_check_var(struct fb_var_screeninfo *var, struct fb_info *info)set_color_bitfields (var);if (var->vmode &FB_VMODE_YWRAP ) { -if (var->xoffset || var->yoffset <0 || - var->yoffset >= var->yres_virtual) { +if (var->xoffset || var->yoffset >= var->yres_virtual) { var->xoffset = var->yoffset =0 ; }else {if (var->xoffset > var->xres_virtual - var->xres || - var->yoffset > var->yres_virtual - var->yres || - var->xoffset <0 || var->yoffset <0 ) + var->yoffset > var->yres_virtual - var->yres) var->xoffset = var->yoffset =0 ; } }else {
Signature · 1 line
2.22.0
Quoted 8 lines · Gustavo A. R. Silva
There is no need to compare *var->xoffset* or *var->yoffset* with < 0 because such variables are of type unsigned, making it impossible to hold a negative value.
Fix this by removing such comparisons.
Addresses-Coverity-ID: 1451964 ("Unsigned compared against 0")
Signed-off-by Gustavo A. R. Silva <[email protected]>
Patch queued for v5.4, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics