Skip to contentSkip to conversation

phy: marvell: phy-mvebu-cp110-comphy: Add of_node_put() before return

PATCH New Nishka Dasgupta 1 participant 1 message Jul 23, 2019 Generic PHY framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 phy: marvell: phy-mvebu-cp110-comphy: Add of_node_put() before return

Each iteration of for_each_available_child_of_node puts the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the return in two places.
Issue found with Coccinelle.

---
 drivers/phy/marvell/phy-mvebu-cp110-comphy.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/phy/marvell/phy-mvebu-cp110-comphy.c +6 -2
index d98e0451f6a1..f7a16dc6e171 100644
@@ -626,12 +626,16 @@ static int mvebu_comphy_probe(struct platform_device *pdev)
 		}
 
 		lane = devm_kzalloc(&pdev->dev, sizeof(*lane), GFP_KERNEL);
-		if (!lane)
+		if (!lane) {
+			of_node_put(child);
 			return -ENOMEM;
+		}
 
 		phy = devm_phy_create(&pdev->dev, child, &mvebu_comphy_ops);
-		if (IS_ERR(phy))
+		if (IS_ERR(phy)) {
+			of_node_put(child);
 			return PTR_ERR(phy);
+		}
 
 		lane->priv = priv;
 		lane->mode = PHY_MODE_INVALID;
Signature · 1 line
2.19.1