Skip to contentSkip to conversation

drivers/hwmon/acpi_power_meter.c: Change log level

PATCH Superseded Wang Shenran 2 participants 2 messages Jul 23, 2019 Hardware monitoring

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Wang Shenran

author
#0 lore raw

PATCH 1/1 drivers/hwmon/acpi_power_meter.c: Change log level

At boot time, the acpi_power_meter driver logs the following error level
message: "Ignoring unsafe software power cap". Having read about it from a few sources, it seems that the error message can be quite misleading.

While the message can imply that Linux is ignoring the fact that the system is operating in potentially dangerous conditions, the truth is the driver found an ACPI_PMC object that supports software power capping. The driver simply decides not to use it, perhaps because it doesn't support the object.

The best solution is probably changing the log level from error to warning. All sources I have found, regarding the error, have downplayed its significance. There is not much of a reason for it to be on error level, while causing potential confusions or misinterpretations.

Signed-off-by Wang Shenran <[email protected]>
---
 drivers/hwmon/acpi_power_meter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/acpi_power_meter.c +1 -1
index 6ba1a08253f0..ee0363e5be43 100644
@@ -681,7 +681,7 @@ static int setup_attrs(struct acpi_power_meter_resource *resource)
 
 	if (resource->caps.flags & POWER_METER_CAN_CAP) {
 		if (!can_cap_in_hardware()) {
-			dev_err(&resource->acpi_dev->dev,
+			dev_warn(&resource->acpi_dev->dev,
 				"Ignoring unsafe software power cap!\n");
 			goto skip_unsafe_cap;
 		}
Signature · 1 line
2.20.1
maintainer
#1 lore raw
Quoted 25 lines · Wang Shenran

At boot time, the acpi_power_meter driver logs the following error level
message: "Ignoring unsafe software power cap". Having read about it from a few sources, it seems that the error message can be quite misleading.

While the message can imply that Linux is ignoring the fact that the system is operating in potentially dangerous conditions, the truth is the driver found an ACPI_PMC object that supports software power capping. The driver simply decides not to use it, perhaps because it doesn't support the object.

The best solution is probably changing the log level from error to warning. All sources I have found, regarding the error, have downplayed its significance. There is not much of a reason for it to be on error level, while causing potential confusions or misinterpretations.

Signed-off-by Wang Shenran <[email protected]>
---
  drivers/hwmon/acpi_power_meter.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/acpi_power_meter.c +0 -0
index 6ba1a08253f0..ee0363e5be43 100644

drivers/hwmon/acpi_power_meter.c static int setup_attrs(struct acpi_power_meter_resource *resource) · line 685

Quoted 6 lines
drivers/hwmon/acpi_power_meter.c +1 -1
@@ -681,7 +681,7 @@ static int setup_attrs(struct acpi_power_meter_resource *resource)
 
  	if (resource->caps.flags & POWER_METER_CAN_CAP) {
  		if (!can_cap_in_hardware()) {
-			dev_err(&resource->acpi_dev->dev,
+			dev_warn(&resource->acpi_dev->dev,
  				"Ignoring unsafe software power cap!\n");

Also please fix continuation line alignment.

Thanks,
Guenter

Quoted 3 lines
drivers/hwmon/acpi_power_meter.c +0 -0
  			goto skip_unsafe_cap;
  		}