crypto: nx: nx-842-powernv: Add of_node_put() before return
Subsystems (3)
PATCH v2 1/1 crypto: nx: nx-842-powernv: Add of_node_put() before return
Each iteration of for_each_compatible_node puts the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Add an of_node_put before the return. Issue found with Coccinelle.
Acked-by Stewart Smith <[email protected]>
Signed-off-by Nishka Dasgupta <[email protected]>
---
Changes in v2:
- Fixed commit message to match the loop in question.
drivers/crypto/nx/nx-842-powernv.c | 1 + 1 file changed, 1 insertion(+)
drivers/crypto/nx/nx-842-powernv.c +1 -0
@@ -1020,6 +1020,7 @@ static __init int nx842_powernv_init(void) ret =nx842_powernv_probe_vas (dn);if (ret) {nx842_delete_coprocs (); +of_node_put (dn);return ret; } }
Signature · 1 line
2.19.1
Herbert Xu
maintainerQuoted 8 lines · Nishka Dasgupta
Each iteration of
for_each_compatible_nodeputs the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Add anof_node_putbefore the return. Issue found with Coccinelle.Acked-by Stewart Smith <[email protected]>Signed-off-by Nishka Dasgupta <[email protected]>
Quoted 6 lines
---
Changes in v2:
- Fixed commit message to match the loop in question.drivers/crypto/nx/nx-842-powernv.c | 1 + 1 file changed, 1 insertion(+)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt