Skip to contentSkip to conversation

coresight: fix typos

PATCH In review Pavel Machek 2 participants 3 messages Jul 24, 2019

Subsystems (2)
Arm/CoreSight framework and drivers Hardware tracing facilities
lore
Share & tools
lore

Pavel Machek

author
#0 lore raw

PATCH 1/1 coresight: fix typos

Fix typos in comments.

Signed-off-by Pavel Machek <[email protected]>
drivers/hwtracing/coresight/coresight.c +2 -2
index 55db77f641..1d66191 100644
@@ -1001,7 +1001,7 @@ static int coresight_orphan_match(struct device *dev, void *data)
 	if (!i_csdev->orphan)
 		return 0;
 	/*
-	 * Circle throuch all the connection of that component.  If we find
+	 * Circle through all the connections of that component.  If we find
 	 * an orphan connection whose name matches @csdev, link it.
 	 */
 	for (i = 0; i < i_csdev->pdata->nr_outport; i++) {

@@ -1021,7 +1021,7 @@ static int coresight_orphan_match(struct device *dev, void *data)
 	i_csdev->orphan = still_orphan;
 
 	/*
-	 * Returning '0' ensures that all known component on the
+	 * Returning '0' ensures that all known components on the
 	 * bus will be checked.
 	 */
 	return 0;
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
maintainer
#1 lore raw
Quoted 10 lines · Pavel Machek

Fix typos in comments.

Signed-off-by Pavel Machek <[email protected]>
drivers/hwtracing/coresight/coresight.c +0 -0
index 55db77f641..1d66191 100644

drivers/hwtracing/coresight/coresight.c static int coresight_orphan_match(struct device *dev, void *data) · line 1005

Quoted 6 lines
drivers/hwtracing/coresight/coresight.c +1 -1
@@ -1001,7 +1001,7 @@ static int coresight_orphan_match(struct device *dev, void *data)
  	if (!i_csdev->orphan)
  		return 0;
  	/*
-	 * Circle throuch all the connection of that component.  If we find
+	 * Circle through all the connections of that component.  If we find
  	 * an orphan connection whose name matches @csdev, link it.

We have stopped using name to match the csdev and switched to fwnode handles. Please could you update the comment to reflect this, while you are at it ? Otherwise looks fine to me.

Suzuki

author
#2 lore raw
Quoted 8 lines · Suzuki K Poulose
Quoted 5 lines · Pavel Machek

Fix typos in comments.

Signed-off-by Pavel Machek <[email protected]>
Quoted 16 lines

drivers/hwtracing/coresight/coresight.c static int coresight_orphan_match(struct device *dev, void *data) · line 1005

Quoted 11 lines
drivers/hwtracing/coresight/coresight.c +1 -1
index 55db77f641..1d66191 100644
@@ -1001,7 +1001,7 @@ static int coresight_orphan_match(struct device *dev, void *data)
 	if (!i_csdev->orphan)
 		return 0;
 	/*
-	 * Circle throuch all the connection of that component.  If we find
+	 * Circle through all the connections of that component.  If we find
 	 * an orphan connection whose name matches @csdev, link it.

We have stopped using name to match the csdev and switched to fwnode handles. Please could you update the comment to reflect this, while you are at it ?
Otherwise looks fine to me.

I guess best way would be to apply this and then fix up the facts in a comment... or feel free to just fix it up. I am not best person to fix facts there...

Best regards,
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html