Skip to contentSkip to conversation

Wimplicit-fallthrough patches for 5.3-rc2

GIT PULL Gustavo A. R. Silva 1 participant 1 message Jul 24, 2019

lore
Share & tools
lore
#0 lore raw

Hi Linus,

I was having some problem with SPF record and it seems that you were not getting my emails. So, I'm sending you this pull-request again.

Thanks

-Gustavo

The following changes since commit 5f9e832c137075045d15cd6899ab0505cfb2ca4b:

Linus 5.3-rc1 (2019-07-21 14:05:38 -0700)

are available in the Git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git tags/Wimplicit-fallthrough-5.3-rc2

for you to fetch changes up to bc512fd704a92e1be700c941c137d73c0f222eed:

Makefile: Globally enable fall-through warning (2019-07-22 14:50:20 -0500)

----------------------------------------------------------------
Wimplicit-fallthrough patches for 5.3-rc2

Hi Linus,

Please, pull the following patches that mark switch cases where we are expecting to fall through. These patches are part of the ongoing efforts to enable -Wimplicit-fallthrough. Most of them have been baking in linux-next for a whole development cycle.

Also, pull the Makefile patch that globally enables the -Wimplicit-fallthrough option.

Finally, some missing-break fixes that have been tagged for -stable:

- drm/amdkfd: Fix missing break in switch statement
- drm/amdgpu/gfx10: Fix missing break in switch statement

Notice that with these changes, we completely get rid of all the fall-through warnings in the kernel.

Thanks

----------------------------------------------------------------
Gustavo A. R. Silva (11):
firewire: mark expected switch fall-throughs
can: mark expected switch fall-throughs
afs: yfsclient: Mark expected switch fall-throughs
afs: fsclient: Mark expected switch fall-throughs
mtd: onenand_base: Mark expected switch fall-through perf/x86/intel: Mark expected switch fall-throughs drm/amdkfd: Fix missing break in switch statement drm/amdgpu/gfx10: Fix missing break in switch statement drm/amdkfd/kfd_mqd_manager_v10: Avoid fall-through warning drm/i915: Mark expected switch fall-throughs
Makefile: Globally enable fall-through warning

 Documentation/process/deprecated.rst             | 14 ++++++
 Makefile                                         |  3 ++
 arch/x86/events/intel/core.c                     |  2 +
 drivers/firewire/core-device.c                   |  2 +-
 drivers/firewire/core-iso.c                      |  2 +-
 drivers/firewire/core-topology.c                 |  1 +
 drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c           |  1 +
 drivers/gpu/drm/amd/amdkfd/kfd_crat.c            |  1 +
 drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v10.c |  1 -
 drivers/gpu/drm/i915/Makefile                    |  1 -
 drivers/gpu/drm/i915/display/intel_display.c     |  2 +-
 drivers/gpu/drm/i915/display/intel_dp.c          |  1 +
 drivers/gpu/drm/i915/gem/i915_gem_mman.c         |  2 +-
 drivers/gpu/drm/i915/gem/i915_gem_pages.c        |  2 +-
 drivers/gpu/drm/i915/i915_gpu_error.c            |  1 +
 drivers/mtd/nand/onenand/onenand_base.c          |  1 +
 drivers/net/can/at91_can.c                       |  6 ++-
 drivers/net/can/peak_canfd/peak_pciefd_main.c    |  2 +-
 drivers/net/can/spi/mcp251x.c                    |  3 +-
 drivers/net/can/usb/peak_usb/pcan_usb.c          |  2 +-
 fs/afs/fsclient.c                                | 51 ++++++++++++++--------
 fs/afs/yfsclient.c                               | 54 +++++++++++++++---------
 22 files changed, 106 insertions(+), 49 deletions(-)