dt-bindings: vendor-prefixes: Add Admatec AG
Subsystems (3)
Krzysztof Kozlowski
maintainerPATCH v2 1/2 dt-bindings: vendor-prefixes: Add Admatec AG
Add vendor prefix for Admatec AG.
---
Changes since v1:
New patch
--- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
@@ -43,6 +43,8 @@ patternProperties: description: AD Holdings Plc. "^adi,.*": description: Analog Devices, Inc. + "^admatec,.*": + description: Admatec AG "^advantech,.*": description: Advantech Corporation "^aeroflexgaisler,.*":
Signature · 1 line
2.17.1
Krzysztof Kozlowski
maintainerPATCH v2 2/2 ARM: dts: imx6ul-kontron-n6310: Add Kontron i.MX6UL N6310 SoM and boards
Add support for i.MX6UL modules from Kontron Electronics GmbH (before
acquisition: Exceet Electronics) and evalkit boards based on it:
1. N6310 SOM: i.MX6 UL System-on-Module, a 25x25 mm solderable module (LGA pads and pin castellations) with 256 MB RAM, 1 MB NOR-Flash, 256 MB NAND and other interfaces,
2. N6310 S: evalkit, w/wo eMMC, without display,
3. N6310 S 43: evalkit with 4.3" display,
4. N6310 S 50: evalkit with 5.0" display.
This includes device nodes for unsupported displays (Admatec T043C004800272T2A and T070P133T0S301).
The work is based on Exceet/Kontron source code (GPLv2) with numerous changes:
1. Reorganize files,
2. Rename Exceet -> Kontron,
3. Rename models/compatibles to match newest Kontron product naming,
4. Fix coding style errors,
5. Fix DTC warnings,
6. Extend compatibles so eval boards inherit the SoM compatible,
7. Use defines instead of GPIO flag values,
8. Use proper vendor compatible for Macronix SPI NOR,
9. Sort nodes alphabetically.
---
Changes since v1, after Frieder's review:
1. Remove unneeded license notes,
2. Add Kontron copyright (2018),
3. Rename the files/models/compatibles to new naming - N6310,
4. Remove unneeded CPU operating points override,
5. Switch regulator nodes into simple children nodes without addresses (so not simple bus),
6. Use proper vendor compatible for Macronix SPI NOR.
--- .../devicetree/bindings/arm/fsl.yaml | 4 + arch/arm/boot/dts/Makefile | 3 + .../boot/dts/imx6ul-kontron-n6310-s-43.dts | 120 +++++ .../boot/dts/imx6ul-kontron-n6310-s-50.dts | 120 +++++ arch/arm/boot/dts/imx6ul-kontron-n6310-s.dts | 424 ++++++++++++++++++ .../boot/dts/imx6ul-kontron-n6310-som.dtsi | 137 ++++++ 6 files changed, 808 insertions(+) create mode 100644 arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dts create mode 100644 arch/arm/boot/dts/imx6ul-kontron-n6310-s-50.dts create mode 100644 arch/arm/boot/dts/imx6ul-kontron-n6310-s.dts create mode 100644 arch/arm/boot/dts/imx6ul-kontron-n6310-som.dtsi
Documentation/devicetree/bindings/arm/fsl.yaml +4 -0
@@ -161,6 +161,10 @@ properties: items: - enum: - fsl,imx6ul-14x14-evk # i.MX6 UltraLite 14x14 EVK Board + - kontron,n6310-som # Kontron N6310 SOM + - kontron,n6310-s # Kontron N6310 S Board + - kontron,n6310-s-43 # Kontron N6310 S 43 Board + - kontron,n6310-s-50 # Kontron N6310 S 50 Board - const: fsl,imx6ul - description: i.MX6ULL based Boards
arch/arm/boot/dts/Makefile +3 -0
@@ -569,6 +569,9 @@ dtb-$(CONFIG_SOC_IMX6UL) += \ imx6ul-geam.dtb \ imx6ul-isiot-emmc.dtb \ imx6ul-isiot-nand.dtb \ + imx6ul-kontron-n6310-s.dtb \ + imx6ul-kontron-n6310-s-43.dtb \ + imx6ul-kontron-n6310-s-50.dtb \ imx6ul-liteboard.dtb \ imx6ul-opos6uldev.dtb \ imx6ul-pico-hobbit.dtb \
arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dts new file +120 -0
120 lines not on this page · raw message
arch/arm/boot/dts/imx6ul-kontron-n6310-s-50.dts new file +120 -0
120 lines not on this page · raw message
arch/arm/boot/dts/imx6ul-kontron-n6310-s.dts new file +424 -0
424 lines not on this page · raw message
arch/arm/boot/dts/imx6ul-kontron-n6310-som.dtsi new file +137 -0
137 lines not on this page · raw message
Signature · 1 line
2.17.1
Quoted 1 line · Krzysztof Kozlowski
Add vendor prefix for Admatec AG.
We get the displays used with the Kontron eval kits from "admatec GmbH" in Hamburg, not "Admatec AG" in Switzerland. I think we have to differentiate here.
I will review patch 2/2 soon...
Quoted 25 lines
Signed-off-by Krzysztof Kozlowski <[email protected]>---
Changes since v1:
New patch--- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+)Documentation/devicetree/bindings/vendor-prefixes.yaml +2
-0@@ -43,6 +43,8 @@ patternProperties: description: AD Holdings Plc. "^adi,.*": description: Analog Devices, Inc. + "^admatec,.*": + description: Admatec AG "^advantech,.*": description: Advantech Corporation "^aeroflexgaisler,.*":
Krzysztof Kozlowski
maintainerQuoted 9 lines · Schrempf Frieder
Quoted 1 line · Krzysztof Kozlowski
Add vendor prefix for Admatec AG.
We get the displays used with the Kontron eval kits from "admatec GmbH" in Hamburg, not "Admatec AG" in Switzerland. I think we have to differentiate here.
I will review patch 2/2 soon...
What a coincidence... they have so similar portfolio. After looking at vendor prefixes that would be the first duplication of name.
To avoid conflict, how about: "admatecde"?
Best regards,
Krzysztof
Quoted 6 lines · Krzysztof Kozlowski
Quoted 4 lines · Schrempf Frieder
Quoted 1 line · Krzysztof Kozlowski
Add vendor prefix for Admatec AG.
Quoted 8 lines
Quoted 5 lines
We get the displays used with the Kontron eval kits from "admatec GmbH" in Hamburg, not "Admatec AG" in Switzerland. I think we have to differentiate here.
I will review patch 2/2 soon...
What a coincidence... they have so similar portfolio. After looking at vendor prefixes that would be the first duplication of name.
I have no idea, whether they are related somehow or have a common history...
Quoted 2 lines
To avoid conflict, how about: "admatecde"?
Would be ok, I guess.
Quoted 4 lines
Best regards,
Krzysztof
Fabio Estevam
reviewerRe: [PATCH v2 2/2] ARM: dts: imx6ul-kontron-n6310: Add Kontron i.MX6UL N6310 SoM and boards
In reply to Krzysztof KozlowskiHi Krzysztof,
Documentation/devicetree/bindings/arm/fsl.yaml properties: · line 167
Quoted 12 lines · Krzysztof Kozlowski
Documentation/devicetree/bindings/arm/fsl.yaml +4
-0@@ -161,6 +161,10 @@ properties: items: - enum: - fsl,imx6ul-14x14-evk # i.MX6 UltraLite 14x14 EVK Board + - kontron,n6310-som # Kontron N6310 SOM + - kontron,n6310-s # Kontron N6310 S Board + - kontron,n6310-s-43 # Kontron N6310 S 43 Board + - kontron,n6310-s-50 # Kontron N6310 S 50 Board
These entries should be:
imx6ul-kontron-n6310-s.dtb
imx6ul-kontron-n6310-s-43.dtb
imx6ul-kontron-n6310-s-50.dtbDocumentation/devicetree/bindings/arm/fsl.yaml properties: · line 169
Quoted 2 lines
Documentation/devicetree/bindings/arm/fsl.yaml +2
-0+ panel { + compatible = "admatec,t043c004800272t2a";
I do not find this binding documented.
Documentation/devicetree/bindings/arm/fsl.yaml properties:
Quoted 2 lines
Documentation/devicetree/bindings/arm/fsl.yaml +2
-0+&i2c4 { + gt911@5d {
Node names should be generic according to the devicetree spec, so:
touchscreen@5d
Documentation/devicetree/bindings/arm/fsl.yaml
Quoted 6 lines
Documentation/devicetree/bindings/arm/fsl.yaml +6
-0+ compatible = "goodix,gt928"; + reg = <0x5d>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_cap_touch>; + interrupt-parent = <&gpio5>; + interrupts = <6 8>;
It would be better to use a laber to indicate the irq type:
interrupts = <6 IRQ_TYPE_LEVEL_LOW>;
Documentation/devicetree/bindings/arm/fsl.yaml
Quoted 2 lines
Documentation/devicetree/bindings/arm/fsl.yaml +2
-0+ reset-gpios = <&gpio5 8 GPIO_ACTIVE_HIGH>; + irq-gpios = <&gpio5 6 GPIO_ACTIVE_HIGH>;
Active high?
Above you use "interrupts = <6 8>;" which means IRQ_TYPE_LEVEL_LOW.
Documentation/devicetree/bindings/arm/fsl.yaml
Quoted 4 lines
Documentation/devicetree/bindings/arm/fsl.yaml +4
-0+ }; +}; + +&iomuxc {
We tend to prefer putting iomuxc as the last node.
Quoted 48 lines
Documentation/devicetree/bindings/arm/fsl.yaml +48
-0+ pinctrl_lcdif_dat: lcdifdatgrp { + fsl,pins = < + MX6UL_PAD_LCD_DATA00__LCDIF_DATA00 0x79 + MX6UL_PAD_LCD_DATA01__LCDIF_DATA01 0x79 + MX6UL_PAD_LCD_DATA02__LCDIF_DATA02 0x79 + MX6UL_PAD_LCD_DATA03__LCDIF_DATA03 0x79 + MX6UL_PAD_LCD_DATA04__LCDIF_DATA04 0x79 + MX6UL_PAD_LCD_DATA05__LCDIF_DATA05 0x79 + MX6UL_PAD_LCD_DATA06__LCDIF_DATA06 0x79 + MX6UL_PAD_LCD_DATA07__LCDIF_DATA07 0x79 + MX6UL_PAD_LCD_DATA08__LCDIF_DATA08 0x79 + MX6UL_PAD_LCD_DATA09__LCDIF_DATA09 0x79 + MX6UL_PAD_LCD_DATA10__LCDIF_DATA10 0x79 + MX6UL_PAD_LCD_DATA11__LCDIF_DATA11 0x79 + MX6UL_PAD_LCD_DATA12__LCDIF_DATA12 0x79 + MX6UL_PAD_LCD_DATA13__LCDIF_DATA13 0x79 + MX6UL_PAD_LCD_DATA14__LCDIF_DATA14 0x79 + MX6UL_PAD_LCD_DATA15__LCDIF_DATA15 0x79 + MX6UL_PAD_LCD_DATA16__LCDIF_DATA16 0x79 + MX6UL_PAD_LCD_DATA17__LCDIF_DATA17 0x79 + MX6UL_PAD_LCD_DATA18__LCDIF_DATA18 0x79 + MX6UL_PAD_LCD_DATA19__LCDIF_DATA19 0x79 + MX6UL_PAD_LCD_DATA20__LCDIF_DATA20 0x79 + MX6UL_PAD_LCD_DATA21__LCDIF_DATA21 0x79 + MX6UL_PAD_LCD_DATA22__LCDIF_DATA22 0x79 + MX6UL_PAD_LCD_DATA23__LCDIF_DATA23 0x79 + >; + }; + + pinctrl_lcdif_ctrl: lcdifctrlgrp { + fsl,pins = < + MX6UL_PAD_LCD_CLK__LCDIF_CLK 0x79 + MX6UL_PAD_LCD_ENABLE__LCDIF_ENABLE 0x79 + MX6UL_PAD_LCD_HSYNC__LCDIF_HSYNC 0x79 + MX6UL_PAD_LCD_VSYNC__LCDIF_VSYNC 0x79 + MX6UL_PAD_LCD_RESET__LCDIF_RESET 0x79 + >; + }; + + pinctrl_cap_touch: captouchgrp { + fsl,pins = < + MX6UL_PAD_SNVS_TAMPER6__GPIO5_IO06 0x1b0b0 /* Touch Interrupt */ + MX6UL_PAD_SNVS_TAMPER7__GPIO5_IO07 0x1b0b0 /* Touch Reset */ + MX6UL_PAD_SNVS_TAMPER8__GPIO5_IO08 0x1b0b0 /* Touch Wake */ + >; + }; + + pinctrl_pwm7: pwm7grp {
Documentation/devicetree/bindings/arm/fsl.yaml
Quoted 10 lines
Documentation/devicetree/bindings/arm/fsl.yaml +10
-0+ fsl,pins = < + MX6UL_PAD_CSI_VSYNC__PWM7_OUT 0x110b0 + >; + }; +}; + +&lcdif { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_lcdif_dat + &pinctrl_lcdif_ctrl>;
Could fit into a single line.
Documentation/devicetree/bindings/arm/fsl.yaml
Quoted 2 lines
Documentation/devicetree/bindings/arm/fsl.yaml +2
-0+ panel { + compatible = "admatec,t070p133t0s301";
Same here. Undocumented binding.
Documentation/devicetree/bindings/arm/fsl.yaml
Quoted 12 lines
Documentation/devicetree/bindings/arm/fsl.yaml +12
-0+ backlight = <&backlight>; + + port { + panel_in: endpoint { + remote-endpoint = <&display_out>; + }; + }; + }; +}; + +&i2c4 { + gt911@5d {
Same comments as previously apply.
Documentation/devicetree/bindings/arm/fsl.yaml
Quoted 2 lines
Documentation/devicetree/bindings/arm/fsl.yaml +2
-0+ + regulators {
No need to have this regulators indent level.
Quoted 1 line
+
reg_3v3: regulator1 {
You can place this one directly. The preferred format is:
reg_3v3: regulator-reg-3v3 {
Quoted 2 lines
+&ecspi1 {
+ fsl,spi-num-chipselects = <1>;
This property is obsoleted. Please remove it.
Documentation/devicetree/bindings/arm/fsl.yaml
Quoted 6 lines
Documentation/devicetree/bindings/arm/fsl.yaml +6
-0+ cs-gpios = <&gpio4 26 GPIO_ACTIVE_HIGH>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_ecspi1>; + status = "okay"; + + fram@0 {
Generic name please. eeprom@0
Quoted 1 line
+ compatible = "atmel,at25";
Please use the recommended compatible scheme as per Documentation/devicetree/bindings/eeprom/at25.txt.
Quoted 6 lines
Documentation/devicetree/bindings/arm/fsl.yaml +6
-0+ reg = <0>; + spi-max-frequency = <20000000>; + spi-cpha; + spi-cpol; + pagesize = <1>; + size = <8192>;
Documentation/devicetree/bindings/arm/fsl.yaml
Quoted 10 lines
Documentation/devicetree/bindings/arm/fsl.yaml +8
-0+ address-width = <16>; + }; +}; +&usbotg1 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usbotg1>; + dr_mode = "otg"; + status = "okay";
We prefer to put the 'status' property as the last one.
Documentation/devicetree/bindings/arm/fsl.yaml
Quoted 11 lines
Documentation/devicetree/bindings/arm/fsl.yaml +10
-0+ srp-disable; + hnp-disable; + adp-disable; + vbus-supply = <®_usb_otg1_vbus>; +}; +/ { + model = "Kontron N6310 SOM"; + compatible = "kontron,n6310-som", "fsl,imx6ul"; + + memory@80000000 {
device_type = "memory"; is missing here.
Documentation/devicetree/bindings/arm/fsl.yaml
Quoted 6 lines
Documentation/devicetree/bindings/arm/fsl.yaml +6
-0+ reg = <0x80000000 0x10000000>; + }; +}; + +&cpu0 { + clock-frequency = <528000000>;
Is this one really needed?
Documentation/devicetree/bindings/arm/fsl.yaml
Quoted 7 lines
+&ecspi2 {
Documentation/devicetree/bindings/arm/fsl.yaml +6
-0+ cs-gpios = <&gpio4 22 GPIO_ACTIVE_HIGH>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_ecspi2>; + status = "okay"; + + flash: mx25v80@0 {
spi-flash@0
Documentation/devicetree/bindings/arm/fsl.yaml
Quoted 6 lines
+&qspi {
Documentation/devicetree/bindings/arm/fsl.yaml +5
-0+ pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_qspi>; + status = "okay"; + + flash0: w25m02gv@0 {
generic name, please.
Krzysztof Kozlowski
maintainerRe: [PATCH v2 2/2] ARM: dts: imx6ul-kontron-n6310: Add Kontron i.MX6UL N6310 SoM and boards
Quoted 18 lines · Fabio Estevam
Hi Krzysztof,
Documentation/devicetree/bindings/arm/fsl.yaml properties: · line 167
Quoted 12 lines · Krzysztof Kozlowski
Documentation/devicetree/bindings/arm/fsl.yaml +4
-0@@ -161,6 +161,10 @@ properties: items: - enum: - fsl,imx6ul-14x14-evk # i.MX6 UltraLite 14x14 EVK Board + - kontron,n6310-som # Kontron N6310 SOM + - kontron,n6310-s # Kontron N6310 S Board + - kontron,n6310-s-43 # Kontron N6310 S 43 Board + - kontron,n6310-s-50 # Kontron N6310 S 50 BoardThese entries should be:
Quoted 3 lines
imx6ul-kontron-n6310-s.dtb
imx6ul-kontron-n6310-s-43.dtb
imx6ul-kontron-n6310-s-50.dtbOK
(I'll apply all your suggestions without and just reply here where there is some discussion)
Quoted 5 lines
Documentation/devicetree/bindings/arm/fsl.yaml properties: · line 169
Quoted 3 lines
Documentation/devicetree/bindings/arm/fsl.yaml +2
-0+ panel { + compatible = "admatec,t043c004800272t2a";I do not find this binding documented.
Because they are not... I mentioned it in commit msg - there are no driver and bindings for them. I put them for completness of HW description.
Quoted 15 lines
Documentation/devicetree/bindings/arm/fsl.yaml properties:
Quoted 3 lines
Documentation/devicetree/bindings/arm/fsl.yaml +2
-0+&i2c4 { + gt911@5d {Node names should be generic according to the devicetree spec, so:
touchscreen@5d
Documentation/devicetree/bindings/arm/fsl.yaml
Quoted 6 lines
Documentation/devicetree/bindings/arm/fsl.yaml +6
-0+ compatible = "goodix,gt928"; + reg = <0x5d>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_cap_touch>; + interrupt-parent = <&gpio5>; + interrupts = <6 8>;
Quoted 3 lines
It would be better to use a laber to indicate the irq type:
interrupts = <6
IRQ_TYPE_LEVEL_LOW>;
Indeed.
Quoted 7 lines
Documentation/devicetree/bindings/arm/fsl.yaml
Quoted 3 lines
Documentation/devicetree/bindings/arm/fsl.yaml +2
-0+ reset-gpios = <&gpio5 8 GPIO_ACTIVE_HIGH>; + irq-gpios = <&gpio5 6 GPIO_ACTIVE_HIGH>;Active high?
Above you use "interrupts = <6 8>;" which means
IRQ_TYPE_LEVEL_LOW.
Yes, it is confusing but it looks correct. The driver does not use the GPIO flag so ACTIVE_HIGH or any other setting does not have effect. Driver uses this pin (as active high) after disabling the interrupts as an additional reset pin during resume. After this additional reset, it serves back as interrupt pin.
Quoted 152 lines
Documentation/devicetree/bindings/arm/fsl.yaml
Quoted 5 lines
Documentation/devicetree/bindings/arm/fsl.yaml +4
-0+ }; +}; + +&iomuxc {We tend to prefer putting iomuxc as the last node.
Quoted 48 lines
Documentation/devicetree/bindings/arm/fsl.yaml +48
-0+ pinctrl_lcdif_dat: lcdifdatgrp { + fsl,pins = < + MX6UL_PAD_LCD_DATA00__LCDIF_DATA00 0x79 + MX6UL_PAD_LCD_DATA01__LCDIF_DATA01 0x79 + MX6UL_PAD_LCD_DATA02__LCDIF_DATA02 0x79 + MX6UL_PAD_LCD_DATA03__LCDIF_DATA03 0x79 + MX6UL_PAD_LCD_DATA04__LCDIF_DATA04 0x79 + MX6UL_PAD_LCD_DATA05__LCDIF_DATA05 0x79 + MX6UL_PAD_LCD_DATA06__LCDIF_DATA06 0x79 + MX6UL_PAD_LCD_DATA07__LCDIF_DATA07 0x79 + MX6UL_PAD_LCD_DATA08__LCDIF_DATA08 0x79 + MX6UL_PAD_LCD_DATA09__LCDIF_DATA09 0x79 + MX6UL_PAD_LCD_DATA10__LCDIF_DATA10 0x79 + MX6UL_PAD_LCD_DATA11__LCDIF_DATA11 0x79 + MX6UL_PAD_LCD_DATA12__LCDIF_DATA12 0x79 + MX6UL_PAD_LCD_DATA13__LCDIF_DATA13 0x79 + MX6UL_PAD_LCD_DATA14__LCDIF_DATA14 0x79 + MX6UL_PAD_LCD_DATA15__LCDIF_DATA15 0x79 + MX6UL_PAD_LCD_DATA16__LCDIF_DATA16 0x79 + MX6UL_PAD_LCD_DATA17__LCDIF_DATA17 0x79 + MX6UL_PAD_LCD_DATA18__LCDIF_DATA18 0x79 + MX6UL_PAD_LCD_DATA19__LCDIF_DATA19 0x79 + MX6UL_PAD_LCD_DATA20__LCDIF_DATA20 0x79 + MX6UL_PAD_LCD_DATA21__LCDIF_DATA21 0x79 + MX6UL_PAD_LCD_DATA22__LCDIF_DATA22 0x79 + MX6UL_PAD_LCD_DATA23__LCDIF_DATA23 0x79 + >; + }; + + pinctrl_lcdif_ctrl: lcdifctrlgrp { + fsl,pins = < + MX6UL_PAD_LCD_CLK__LCDIF_CLK 0x79 + MX6UL_PAD_LCD_ENABLE__LCDIF_ENABLE 0x79 + MX6UL_PAD_LCD_HSYNC__LCDIF_HSYNC 0x79 + MX6UL_PAD_LCD_VSYNC__LCDIF_VSYNC 0x79 + MX6UL_PAD_LCD_RESET__LCDIF_RESET 0x79 + >; + }; + + pinctrl_cap_touch: captouchgrp { + fsl,pins = < + MX6UL_PAD_SNVS_TAMPER6__GPIO5_IO06 0x1b0b0 /* Touch Interrupt */ + MX6UL_PAD_SNVS_TAMPER7__GPIO5_IO07 0x1b0b0 /* Touch Reset */ + MX6UL_PAD_SNVS_TAMPER8__GPIO5_IO08 0x1b0b0 /* Touch Wake */ + >; + }; + + pinctrl_pwm7: pwm7grp {Documentation/devicetree/bindings/arm/fsl.yaml
Quoted 10 lines
Documentation/devicetree/bindings/arm/fsl.yaml +10
-0+ fsl,pins = < + MX6UL_PAD_CSI_VSYNC__PWM7_OUT 0x110b0 + >; + }; +}; + +&lcdif { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_lcdif_dat + &pinctrl_lcdif_ctrl>;Could fit into a single line.
Documentation/devicetree/bindings/arm/fsl.yaml
Quoted 2 lines
Documentation/devicetree/bindings/arm/fsl.yaml +2
-0+ panel { + compatible = "admatec,t070p133t0s301";Same here. Undocumented binding.
Documentation/devicetree/bindings/arm/fsl.yaml
Quoted 12 lines
Documentation/devicetree/bindings/arm/fsl.yaml +12
-0+ backlight = <&backlight>; + + port { + panel_in: endpoint { + remote-endpoint = <&display_out>; + }; + }; + }; +}; + +&i2c4 { + gt911@5d {Same comments as previously apply.
Documentation/devicetree/bindings/arm/fsl.yaml
Quoted 2 lines
Documentation/devicetree/bindings/arm/fsl.yaml +2
-0+ + regulators {No need to have this regulators indent level.
Quoted 1 line
+
reg_3v3: regulator1 {You can place this one directly. The preferred format is:
reg_3v3: regulator-reg-3v3 {Quoted 2 lines
+&ecspi1 {
+ fsl,spi-num-chipselects = <1>;This property is obsoleted. Please remove it.
Documentation/devicetree/bindings/arm/fsl.yaml
Quoted 6 lines
Documentation/devicetree/bindings/arm/fsl.yaml +6
-0+ cs-gpios = <&gpio4 26 GPIO_ACTIVE_HIGH>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_ecspi1>; + status = "okay"; + + fram@0 {Generic name please. eeprom@0
Quoted 1 line
+ compatible = "atmel,at25";
Please use the recommended compatible scheme as per
Documentation/devicetree/bindings/eeprom/at25.txt.Quoted 6 lines
Documentation/devicetree/bindings/arm/fsl.yaml +6
-0+ reg = <0>; + spi-max-frequency = <20000000>; + spi-cpha; + spi-cpol; + pagesize = <1>; + size = <8192>;Documentation/devicetree/bindings/arm/fsl.yaml
Quoted 10 lines
Documentation/devicetree/bindings/arm/fsl.yaml +8
-0+ address-width = <16>; + }; +}; +&usbotg1 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usbotg1>; + dr_mode = "otg"; + status = "okay";We prefer to put the 'status' property as the last one.
Documentation/devicetree/bindings/arm/fsl.yaml
Quoted 11 lines
Documentation/devicetree/bindings/arm/fsl.yaml +10
-0+ srp-disable; + hnp-disable; + adp-disable; + vbus-supply = <®_usb_otg1_vbus>; +}; +/ { + model = "Kontron N6310 SOM"; + compatible = "kontron,n6310-som", "fsl,imx6ul"; + + memory@80000000 {
device_type= "memory"; is missing here.
Quoted 8 lines
Documentation/devicetree/bindings/arm/fsl.yaml
Quoted 6 lines
Documentation/devicetree/bindings/arm/fsl.yaml +6
-0+ reg = <0x80000000 0x10000000>; + }; +}; + +&cpu0 { + clock-frequency = <528000000>;Is this one really needed?
I'll check.
Quoted 11 lines
Documentation/devicetree/bindings/arm/fsl.yaml
Quoted 8 lines
+&ecspi2 {
Documentation/devicetree/bindings/arm/fsl.yaml +6
-0+ cs-gpios = <&gpio4 22 GPIO_ACTIVE_HIGH>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_ecspi2>; + status = "okay"; + + flash: mx25v80@0 {spi-flash@0
Quoted 8 lines
Documentation/devicetree/bindings/arm/fsl.yaml
Quoted 6 lines
+&qspi {
Documentation/devicetree/bindings/arm/fsl.yaml +5
-0+ pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_qspi>; + status = "okay"; + + flash0: w25m02gv@0 {generic name, please.
Thanks for review!
Best regards,
Krzysztof