net: spider_net: Mark expected switch fall-through
Subsystems (2)
PATCH 1/1 net: spider_net: Mark expected switch fall-through
Mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/net/ethernet/toshiba/spider_net.c: In function 'spider_net_release_tx_chain':drivers/net/ethernet/toshiba/spider_net.c:783:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (!brutal) {
^drivers/net/ethernet/toshiba/spider_net.c:792:3: note: here
case SPIDER_NET_DESCR_RESPONSE_ERROR:
^~~~
Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find.
--- drivers/net/ethernet/toshiba/spider_net.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/ethernet/toshiba/spider_net.c +1 -0
@@ -788,6 +788,7 @@ spider_net_release_tx_chain(struct spider_net_card *card, int brutal)/* fallthrough, if we release the descriptors * brutally (then we don't care about * SPIDER_NET_DESCR_CARDOWNED) */ +/* Fall through */ case SPIDER_NET_DESCR_RESPONSE_ERROR :case SPIDER_NET_DESCR_PROTECTION_ERROR :
Signature · 1 line
2.22.0
Quoted 12 lines · Gustavo A. R. Silva
Mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/net/ethernet/toshiba/spider_net.c: In function 'spider_net_release_tx_chain':drivers/net/ethernet/toshiba/spider_net.c:783:7: warning: this statement may fall through [-Wimplicit-fallthrough=]if (!brutal) { ^ drivers/net/ethernet/toshiba/spider_net.c:792:3: note: here case SPIDER_NET_DESCR_RESPONSE_ERROR: ^~~~
Quoted 5 lines
Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find.
Reported-by Stephen Rothwell <[email protected]>Signed-off-by Gustavo A. R. Silva <[email protected]>
-Kees
Quoted 19 lines
--- drivers/net/ethernet/toshiba/spider_net.c | 1 + 1 file changed, 1 insertion(+)drivers/net/ethernet/toshiba/spider_net.c +1
-0@@ -788,6 +788,7 @@ spider_net_release_tx_chain(struct spider_net_card *card, int brutal)/* fallthrough, if we release the descriptors * brutally (then we don't care about * SPIDER_NET_DESCR_CARDOWNED) */ +/* Fall through */ case SPIDER_NET_DESCR_RESPONSE_ERROR :case SPIDER_NET_DESCR_PROTECTION_ERROR :Signature · 1 line
2.22.0
Signature · 1 line
Kees Cook
From: "Gustavo A. R. Silva" <[email protected]>
Date: Sun, 28 Jul 2019 19:32:51 -0500
Quoted 12 lines
Mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/net/ethernet/toshiba/spider_net.c: In function 'spider_net_release_tx_chain':drivers/net/ethernet/toshiba/spider_net.c:783:7: warning: this statement may fall through [-Wimplicit-fallthrough=]if (!brutal) { ^ drivers/net/ethernet/toshiba/spider_net.c:792:3: note: here case SPIDER_NET_DESCR_RESPONSE_ERROR: ^~~~
Quoted 5 lines
Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find.
Reported-by Stephen Rothwell <[email protected]>Signed-off-by Gustavo A. R. Silva <[email protected]>
Applied.