arcnet: com90xx: Mark expected switch fall-throughs
Subsystems (3)
PATCH 1/1 arcnet: com90xx: Mark expected switch fall-throughs
Mark switch cases where we are expecting to fall through.
This patch fixes the following warnings (Building: powerpc allyesconfig):
drivers/net/arcnet/com90xx.c: In function 'com90xx_setup':include/linux/printk.h:304:2: warning: this statement may fall through [-Wimplicit-fallthrough=]
printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~drivers/net/arcnet/com90xx.c:695:3: note: in expansion of macro 'pr_err'
pr_err("Too many arguments\n");
^~~~~~drivers/net/arcnet/com90xx.c:696:2: note: here
case 3: /* Mem address */
^~~~drivers/net/arcnet/com90xx.c:697:9: warning: this statement may fall through [-Wimplicit-fallthrough=]
shmem = ints[3];
~~~~~~^~~~~~~~~drivers/net/arcnet/com90xx.c:698:2: note: here
case 2: /* IRQ */
^~~~drivers/net/arcnet/com90xx.c:699:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
irq = ints[2];
~~~~^~~~~~~~~drivers/net/arcnet/com90xx.c:700:2: note: here
case 1: /* IO address */
^~~~
--- drivers/net/arcnet/com90xx.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/net/arcnet/com90xx.c +3 -0
@@ -693,10 +693,13 @@ static int __init com90xx_setup(char *s)switch (ints[0 ]) {default :/* ERROR */ pr_err ("Too many arguments\n" ); +/* Fall through */ case 3 :/* Mem address */ shmem = ints[3 ]; +/* Fall through */ case 2 :/* IRQ */ irq = ints[2 ]; +/* Fall through */ case 1 :/* IO address */ io = ints[1 ]; }
Signature · 1 line
2.22.0
Quoted 21 lines · Gustavo A. R. Silva
Mark switch cases where we are expecting to fall through.
This patch fixes the following warnings (Building: powerpc allyesconfig):
drivers/net/arcnet/com90xx.c: In function 'com90xx_setup':include/linux/printk.h:304:2: warning: this statement may fall through [-Wimplicit-fallthrough=]
printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~drivers/net/arcnet/com90xx.c:695:3: note: in expansion of macro 'pr_err'pr_err("Too many arguments\n"); ^~~~~~
drivers/net/arcnet/com90xx.c:696:2: note: here
case 3: /* Mem address */
^~~~drivers/net/arcnet/com90xx.c:697:9: warning: this statement may fall through [-Wimplicit-fallthrough=]shmem = ints[3]; ~~~~~~^~~~~~~~~
drivers/net/arcnet/com90xx.c:698:2: note: here
case 2: /* IRQ */
^~~~drivers/net/arcnet/com90xx.c:699:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
Quoted 8 lines
irq = ints[2]; ~~~~^~~~~~~~~
drivers/net/arcnet/com90xx.c:700:2: note: here
case 1: /* IO address */
^~~~Reported-by Stephen Rothwell <[email protected]>Signed-off-by Gustavo A. R. Silva <[email protected]>
-Kees
Quoted 25 lines
--- drivers/net/arcnet/com90xx.c | 3 +++ 1 file changed, 3 insertions(+)drivers/net/arcnet/com90xx.c +3
-0@@ -693,10 +693,13 @@ static int __init com90xx_setup(char *s)switch (ints[0 ]) {default :/* ERROR */ pr_err ("Too many arguments\n" ); +/* Fall through */ case 3 :/* Mem address */ shmem = ints[3 ]; +/* Fall through */ case 2 :/* IRQ */ irq = ints[2 ]; +/* Fall through */ case 1 :/* IO address */ io = ints[1 ]; }Signature · 1 line
2.22.0
Signature · 1 line
Kees Cook
From: "Gustavo A. R. Silva" <[email protected]>
Date: Mon, 29 Jul 2019 06:09:53 -0500
Quoted 3 lines
Mark switch cases where we are expecting to fall through.
This patch fixes the following warnings (Building: powerpc allyesconfig):
...
Quoted 2 lines
Reported-by Stephen Rothwell <[email protected]>Signed-off-by Gustavo A. R. Silva <[email protected]>
Applied.