Skip to contentSkip to conversation

crypto: ccp - Log an error message when ccp-crypto fails to load

PATCH In review Hook, Gary 2 participants 2 messages Jul 29, 2019 – Aug 9, 2019

Subsystems (2)
lore
Share & tools
lore

Hook, Gary

author
#0 lore raw

PATCH v2 1/1 crypto: ccp - Log an error message when ccp-crypto fails to load

From: Gary R Hook <[email protected]>

If there are no CCP devices on the system, ccp-crypto will not load. Write a message to the system log clarifying the reason for the failure of the modprobe operation

---

Changes since v1:
- Add missing signed-off-by

 drivers/crypto/ccp/ccp-crypto-main.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/crypto/ccp/ccp-crypto-main.c +3 -1
index 818096490829..8ee4cb45a3f3 100644
@@ -405,8 +405,10 @@ static int ccp_crypto_init(void)
 	int ret;
 
 	ret = ccp_present();
-	if (ret)
+	if (ret) {
+		pr_err("Cannot load: there are no available CCPs\n");
 		return ret;
+	}
 
 	spin_lock_init(&req_queue_lock);
 	INIT_LIST_HEAD(&req_queue.cmds);
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 6 lines · Gary

From: Gary R Hook <[email protected]>

If there are no CCP devices on the system, ccp-crypto will not load. Write a message to the system log clarifying the reason for the failure of the modprobe operation

Quoted 8 lines

---

Changes since v1:
- Add missing signed-off-by

 drivers/crypto/ccp/ccp-crypto-main.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt