arcnet: com20020-isa: Mark expected switch fall-throughs
Subsystems (3)
PATCH 1/1 arcnet: com20020-isa: Mark expected switch fall-throughs
Mark switch cases where we are expecting to fall through.
This patch fixes the following warnings:
drivers/net/arcnet/com20020-isa.c: warning: this statement may fall through [-Wimplicit-fallthrough=]: => 205:13, 203:10, 209:7, 201:11, 207:8
--- drivers/net/arcnet/com20020-isa.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/net/arcnet/com20020-isa.c +6 -0
@@ -197,16 +197,22 @@ static int __init com20020isa_setup(char *s)switch (ints[0 ]) {default :/* ERROR */ pr_info ("Too many arguments\n" ); +/* Fall through */ case 6 :/* Timeout */ timeout = ints[6 ]; +/* Fall through */ case 5 :/* CKP value */ clockp = ints[5 ]; +/* Fall through */ case 4 :/* Backplane flag */ backplane = ints[4 ]; +/* Fall through */ case 3 :/* Node ID */ node = ints[3 ]; +/* Fall through */ case 2 :/* IRQ */ irq = ints[2 ]; +/* Fall through */ case 1 :/* IO address */ io = ints[1 ]; }
Signature · 1 line
2.22.0
Quoted 10 lines · Gustavo A. R. Silva
Mark switch cases where we are expecting to fall through.
This patch fixes the following warnings:
drivers/net/arcnet/com20020-isa.c: warning: this statement may fall through [-Wimplicit-fallthrough=]: => 205:13, 203:10, 209:7, 201:11, 207:8Reported-by Geert Uytterhoeven <[email protected]>Signed-off-by Gustavo A. R. Silva <[email protected]>
-Kees
Quoted 34 lines
--- drivers/net/arcnet/com20020-isa.c | 6 ++++++ 1 file changed, 6 insertions(+)drivers/net/arcnet/com20020-isa.c +6
-0@@ -197,16 +197,22 @@ static int __init com20020isa_setup(char *s)switch (ints[0 ]) {default :/* ERROR */ pr_info ("Too many arguments\n" ); +/* Fall through */ case 6 :/* Timeout */ timeout = ints[6 ]; +/* Fall through */ case 5 :/* CKP value */ clockp = ints[5 ]; +/* Fall through */ case 4 :/* Backplane flag */ backplane = ints[4 ]; +/* Fall through */ case 3 :/* Node ID */ node = ints[3 ]; +/* Fall through */ case 2 :/* IRQ */ irq = ints[2 ]; +/* Fall through */ case 1 :/* IO address */ io = ints[1 ]; }Signature · 1 line
2.22.0
Signature · 1 line
Kees Cook
From: "Gustavo A. R. Silva" <[email protected]>
Date: Mon, 29 Jul 2019 09:25:03 -0500
Quoted 10 lines
Mark switch cases where we are expecting to fall through.
This patch fixes the following warnings:
drivers/net/arcnet/com20020-isa.c: warning: this statement may fall through [-Wimplicit-fallthrough=]: => 205:13, 203:10, 209:7, 201:11, 207:8Reported-by Geert Uytterhoeven <[email protected]>Signed-off-by Gustavo A. R. Silva <[email protected]>
Applied.