Skip to contentSkip to conversation

Enable QUERY_LAG over DEVX

PATCH In review Leon Romanovsky 3 participants 6 messages Jul 31, 2019 – Aug 6, 2019

Subsystems (3)
InfiniBand Mellanox mlx5 core Mellanox MLX5 IB driver
lore
Share & tools
lore

Leon Romanovsky

author
#0 lore raw

cover Enable QUERY_LAG over DEVX

From: Leon Romanovsky <[email protected]>

Hi,

Enable QUERY_LAG command over DEVX. That command was added to the mlx5_core, but were not used and hence has wrong HW spec layout which is fixed in first patch. The second patch actually makes this command available for DEVX users.

Thanks

Mark Zhang (2):
net/mlx5: Fix mlx5_ifc_query_lag_out_bits
IB/mlx5: Support MLX5_CMD_OP_QUERY_LAG as a DEVX general command

 drivers/infiniband/hw/mlx5/devx.c | 1 +
 include/linux/mlx5/mlx5_ifc.h     | 2 --
 2 files changed, 1 insertion(+), 2 deletions(-)

--
2.20.1

author
#1 lore raw

PATCH 1/2 net/mlx5: Fix mlx5_ifc_query_lag_out_bits

From: Mark Zhang <[email protected]>

Remove the "reserved_at_40" field to match the device specification.

Fixes 84df61ebc69b ("net/mlx5: Add HW interfaces used by LAG")
Signed-off-by Mark Zhang <[email protected]>
Reviewed-by Yishai Hadas <[email protected]>
Signed-off-by Leon Romanovsky <[email protected]>
---
 include/linux/mlx5/mlx5_ifc.h | 2 --
 1 file changed, 2 deletions(-)
include/linux/mlx5/mlx5_ifc.h +0 -2
index 5eae8d734435..726790d9ef25 100644
@@ -9572,8 +9572,6 @@ struct mlx5_ifc_query_lag_out_bits {
 
 	u8         syndrome[0x20];
 
-	u8         reserved_at_40[0x40];
-
 	struct mlx5_ifc_lagc_bits ctx;
 };

--
2.20.1

author
#2 lore raw

PATCH 2/2 IB/mlx5: Support MLX5_CMD_OP_QUERY_LAG as a DEVX general command

In reply to Leon Romanovsky

From: Mark Zhang <[email protected]>

The "MLX5_CMD_OP_QUERY_LAG" is one of the DEVX general commands, add it.

Fixes 8aa8c95ce4cc ("IB/mlx5: Add support for DEVX general command")
Signed-off-by Mark Zhang <[email protected]>
Reviewed-by Yishai Hadas <[email protected]>
Signed-off-by Leon Romanovsky <[email protected]>
---
 drivers/infiniband/hw/mlx5/devx.c | 1 +
 1 file changed, 1 insertion(+)
drivers/infiniband/hw/mlx5/devx.c +1 -0
index a527cf7f01ac..fd577ffd7864 100644
@@ -930,6 +930,7 @@ static bool devx_is_general_cmd(void *in, struct mlx5_ib_dev *dev)
 	case MLX5_CMD_OP_QUERY_CONG_STATUS:
 	case MLX5_CMD_OP_QUERY_CONG_PARAMS:
 	case MLX5_CMD_OP_QUERY_CONG_STATISTICS:
+	case MLX5_CMD_OP_QUERY_LAG:
 		return true;
 	default:
 		return false;
Signature · 1 line
2.20.1
#3 lore raw
In reply to Leon Romanovsky
Quoted 9 lines · Leon Romanovsky

From: Leon Romanovsky <[email protected]>

Hi,

Enable QUERY_LAG command over DEVX. That command was added to the mlx5_core, but were not used and hence has wrong HW spec layout which is fixed in first patch. The second patch actually makes this command available for DEVX users.

Quoted 5 lines

Thanks

Mark Zhang (2):
net/mlx5: Fix mlx5_ifc_query_lag_out_bits
IB/mlx5: Support MLX5_CMD_OP_QUERY_LAG as a DEVX general command

Both patches are applied to mlx5-next.

Thanks,

#4 lore raw
Quoted 10 lines · Leon Romanovsky
Quoted 9 lines · Leon Romanovsky

From: Leon Romanovsky <[email protected]>

Hi,

Enable QUERY_LAG command over DEVX. That command was added to the mlx5_core, but were not used and hence has wrong HW spec layout which is fixed in first patch. The second patch actually makes this command available for DEVX users.

Quoted 7 lines
Quoted 5 lines

Thanks

Mark Zhang (2):
net/mlx5: Fix mlx5_ifc_query_lag_out_bits
IB/mlx5: Support MLX5_CMD_OP_QUERY_LAG as a DEVX general command

Both patches are applied to mlx5-next.

Why the second one?

Jason

#5 lore raw
Quoted 13 lines · Jason Gunthorpe
Quoted 12 lines · Leon Romanovsky
Quoted 11 lines · Leon Romanovsky

From: Leon Romanovsky <[email protected]>

Hi,

Enable QUERY_LAG command over DEVX. That command was added to the mlx5_core, but were not used and hence has wrong HW spec layout which is fixed in first patch. The second patch actually makes this command available for DEVX users.

Thanks

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

Mark Zhang (2):
net/mlx5: Fix mlx5_ifc_query_lag_out_bits
IB/mlx5: Support MLX5_CMD_OP_QUERY_LAG as a DEVX general command

Both patches are applied to mlx5-next.

Why the second one?

It was one-liner patch and I preferred to save work from you.

Thanks

Quoted 2 lines

Jason