Skip to contentSkip to conversation

Speculative mitigation facilities report wrong status v2

PATCH In review Jin Nan Wang 2 participants 2 messages Jul 31, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Speculative mitigation facilities report wrong status v2

Add a check about X86_FEATURE_MD_CLEAR to avoid to print "None".

---
 xen/arch/x86/spec_ctrl.c | 2 ++
 1 file changed, 2 insertions(+)
xen/arch/x86/spec_ctrl.c +2 -0
index cada9a058e..468a847598 100644
@@ -366,6 +366,7 @@ static void __init print_details(enum ind_thunk thunk, uint64_t caps)
     printk("  Support for HVM VMs:%s%s%s%s%s\n",
            (boot_cpu_has(X86_FEATURE_SC_MSR_HVM) ||
             boot_cpu_has(X86_FEATURE_SC_RSB_HVM) ||
+            boot_cpu_has(X86_FEATURE_MD_CLEAR)   ||
             opt_eager_fpu)                           ? ""               : " None",
            boot_cpu_has(X86_FEATURE_SC_MSR_HVM)      ? " MSR_SPEC_CTRL" : "",
            boot_cpu_has(X86_FEATURE_SC_RSB_HVM)      ? " RSB"           : "",
@@ -377,6 +378,7 @@ static void __init print_details(enum ind_thunk thunk, uint64_t caps)
     printk("  Support for PV VMs:%s%s%s%s%s\n",
            (boot_cpu_has(X86_FEATURE_SC_MSR_PV) ||
             boot_cpu_has(X86_FEATURE_SC_RSB_PV) ||
+            boot_cpu_has(X86_FEATURE_MD_CLEAR)  ||
             opt_eager_fpu)                           ? ""               : " None",
            boot_cpu_has(X86_FEATURE_SC_MSR_PV)       ? " MSR_SPEC_CTRL" : "",
            boot_cpu_has(X86_FEATURE_SC_RSB_PV)       ? " RSB"           : "",
Signature · 7 lines
2.22.0


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
#1 lore raw

On 31/07/2019 14:09, Jin Nan Wang wrote:

This wants at least a minimal aspect of description from your first patch, i.e. that booting with spec-ctrl=0 results in Xen printing "None MD_CLEAR".

Quoted 1 line

Add a check about X86_FEATURE_MD_CLEAR to avoid to print "None".

Needs a SoB tag.

The actual code change is correct.

~Andrew

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel