Skip to contentSkip to conversation

staging/octeon: Fix build error without CONFIG_NETDEVICES

PATCH Applied Greg KH 2 participants 2 messages Jul 31, 2019

Subsystems (3)
lore
Share & tools
lore

Greg KH

author maintainer
#0 lore raw

PATCH v2 1/1 staging/octeon: Fix build error without CONFIG_NETDEVICES

From: YueHaibing <[email protected]>

While do COMPILE_TEST build without CONFIG_NETDEVICES, we get Kconfig warning:

WARNING: unmet direct dependencies detected for PHYLIB
Depends on [n]: NETDEVICES [=n]
Selected by [y]:
- OCTEON_ETHERNET [=y] && STAGING [=y] && (CAVIUM_OCTEON_SOC && NETDEVICES [=n] || COMPILE_TEST [=y])

Fixes 171a9bae68c7 ("staging/octeon: Allow test build on !MIPS")

---
v2: cc: netdev and add another reported-by line.

 drivers/staging/octeon/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/octeon/Kconfig +2 -1
index 5b39946..5319909 100644
@@ -1,7 +1,8 @@
 # SPDX-License-Identifier: GPL-2.0
 config OCTEON_ETHERNET
 	tristate "Cavium Networks Octeon Ethernet support"
-	depends on CAVIUM_OCTEON_SOC && NETDEVICES || COMPILE_TEST
+	depends on CAVIUM_OCTEON_SOC || COMPILE_TEST
+	depends on NETDEVICES
 	select PHYLIB
 	select MDIO_OCTEON
 	help
Signature · 7 lines
2.7.4


_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
maintainer Applied
#1 lore raw

From: Greg KH <[email protected]>
Date: Wed, 31 Jul 2019 18:02:19 +0200

Quoted 10 lines

From: YueHaibing <[email protected]>

While do COMPILE_TEST build without CONFIG_NETDEVICES, we get Kconfig warning:

WARNING: unmet direct dependencies detected for PHYLIB
Depends on [n]: NETDEVICES [=n]
Selected by [y]:
- OCTEON_ETHERNET [=y] && STAGING [=y] && (CAVIUM_OCTEON_SOC && NETDEVICES [=n] || COMPILE_TEST [=y])

Quoted 5 lines
Fixes 171a9bae68c7 ("staging/octeon: Allow test build on !MIPS")

Applied to net-next.