Skip to contentSkip to conversation

drm/panfrost: Remove completed features still in TODO

PATCH In review Rob Herring 4 participants 6 messages Aug 2, 2019 – Aug 13, 2019

Subsystems (3)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 drm/panfrost: Remove completed features still in TODO

There's a few features the driver supports which we forgot to remove, so remove them now.

Cc Tomeu Vizoso <[email protected]>
Cc Boris Brezillon <[email protected]>
---
 drivers/gpu/drm/panfrost/TODO | 9 ---------
 1 file changed, 9 deletions(-)
drivers/gpu/drm/panfrost/TODO +0 -9
index c2e44add37d8..2ac972a3469c 100644
@@ -1,15 +1,9 @@
-- Thermal support.
-
 - Bifrost support:
   - DT bindings (Neil, WIP)
   - MMU page table format and address space setup
   - Bifrost specific feature and issue handling
   - Coherent DMA support
 
-- Support for 2MB pages. The io-pgtable code already supports this. Finishing
-  support involves either copying or adapting the iommu API to handle passing
-  aligned addresses and sizes to the io-pgtable code.
-
 - Per FD address space support. The h/w supports multiple addresses spaces.
   The hard part is handling when more address spaces are needed than what
   the h/w provides.
@@ -22,6 +16,3 @@
 
 - Compute job support. So called 'compute only' jobs need to be plumbed up to
   userspace.
-
-- Performance counter support. (Boris)
-
Signature · 6 lines
2.20.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · On Fri, 2 Aug 2019 13:57:27 -0600 Rob Herring <[email protected]> wrote:

There's a few features the driver supports which we forgot to remove, so remove them now.

Cc Tomeu Vizoso <[email protected]>
Cc Boris Brezillon <[email protected]>
Quoted 26 lines
---
 drivers/gpu/drm/panfrost/TODO | 9 ---------
 1 file changed, 9 deletions(-)
drivers/gpu/drm/panfrost/TODO +0 -6
index c2e44add37d8..2ac972a3469c 100644
@@ -1,15 +1,9 @@
-- Thermal support.
-
 - Bifrost support:
   - DT bindings (Neil, WIP)
   - MMU page table format and address space setup
   - Bifrost specific feature and issue handling
   - Coherent DMA support
 
-- Support for 2MB pages. The io-pgtable code already supports this. Finishing
-  support involves either copying or adapting the iommu API to handle passing
-  aligned addresses and sizes to the io-pgtable code.
-
 - Per FD address space support. The h/w supports multiple addresses spaces.
   The hard part is handling when more address spaces are needed than what
   the h/w provides.

drivers/gpu/drm/panfrost/TODO line 27

Quoted 6 lines
drivers/gpu/drm/panfrost/TODO +0 -3
@@ -22,6 +16,3 @@
 
 - Compute job support. So called 'compute only' jobs need to be plumbed up to
   userspace.
-
-- Performance counter support. (Boris)
-

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#2 lore raw
In reply to Rob Herring
Quoted 15 lines · Rob Herring

There's a few features the driver supports which we forgot to remove, so remove them now.

Cc Tomeu Vizoso <[email protected]>
Cc Boris Brezillon <[email protected]>
---
  drivers/gpu/drm/panfrost/TODO | 9 ---------
  1 file changed, 9 deletions(-)
drivers/gpu/drm/panfrost/TODO +0 -0
index c2e44add37d8..2ac972a3469c 100644

drivers/gpu/drm/panfrost/TODO line 1

Quoted 1 line
drivers/gpu/drm/panfrost/TODO +0 -1
@@ -1,15 +1,9 @@
-- Thermal support.

Was thinking that this item referred to cooling device support, which we don't yet have?

Cheers,

Tomeu

Quoted 16 lines
drivers/gpu/drm/panfrost/TODO +0 -5
-
  - Bifrost support:
    - DT bindings (Neil, WIP)
    - MMU page table format and address space setup
    - Bifrost specific feature and issue handling
    - Coherent DMA support
 
-- Support for 2MB pages. The io-pgtable code already supports this. Finishing
-  support involves either copying or adapting the iommu API to handle passing
-  aligned addresses and sizes to the io-pgtable code.
-
  - Per FD address space support. The h/w supports multiple addresses spaces.
    The hard part is handling when more address spaces are needed than what
    the h/w provides.

drivers/gpu/drm/panfrost/TODO line 27

Quoted 6 lines
drivers/gpu/drm/panfrost/TODO +0 -3
@@ -22,6 +16,3 @@
 
  - Compute job support. So called 'compute only' jobs need to be plumbed up to
    userspace.
-
-- Performance counter support. (Boris)
-

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

author maintainer
#3 lore raw
Quoted 12 lines · Tomeu Vizoso
Quoted 10 lines · Rob Herring

There's a few features the driver supports which we forgot to remove, so remove them now.

Cc Tomeu Vizoso <[email protected]>
Cc Boris Brezillon <[email protected]>
---
  drivers/gpu/drm/panfrost/TODO | 9 ---------
  1 file changed, 9 deletions(-)
Quoted 9 lines

drivers/gpu/drm/panfrost/TODO line 1

Quoted 6 lines
drivers/gpu/drm/panfrost/TODO +0 -1
index c2e44add37d8..2ac972a3469c 100644
@@ -1,15 +1,9 @@
-- Thermal support.

Was thinking that this item referred to cooling device support, which we don't yet have?

Oh right. I thinking that somehow was left over from before committing upstream... Will drop that change.

Rob
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#4 lore raw
In reply to Rob Herring
Quoted 15 lines · Rob Herring

There's a few features the driver supports which we forgot to remove, so remove them now.

Cc Tomeu Vizoso <[email protected]>
Cc Boris Brezillon <[email protected]>
---
 drivers/gpu/drm/panfrost/TODO | 9 ---------
 1 file changed, 9 deletions(-)
drivers/gpu/drm/panfrost/TODO +0 -0
index c2e44add37d8..2ac972a3469c 100644

drivers/gpu/drm/panfrost/TODO line 2

Quoted 4 lines
drivers/gpu/drm/panfrost/TODO +0 -2
@@ -1,15 +1,9 @@
-- Thermal support.
-
 - Bifrost support:
   - DT bindings (Neil, WIP)

The bifrostr bindings are upstream, but not in YAML, you should move and transform this line into :

- DT bindings in YAML schema

Neil

Quoted 13 lines
drivers/gpu/drm/panfrost/TODO +0 -4
   - MMU page table format and address space setup
   - Bifrost specific feature and issue handling
   - Coherent DMA support
 
-- Support for 2MB pages. The io-pgtable code already supports this. Finishing
-  support involves either copying or adapting the iommu API to handle passing
-  aligned addresses and sizes to the io-pgtable code.
-
 - Per FD address space support. The h/w supports multiple addresses spaces.
   The hard part is handling when more address spaces are needed than what
   the h/w provides.

drivers/gpu/drm/panfrost/TODO line 27

Quoted 6 lines
drivers/gpu/drm/panfrost/TODO +0 -3
@@ -22,6 +16,3 @@
 
 - Compute job support. So called 'compute only' jobs need to be plumbed up to
   userspace.
-
-- Performance counter support. (Boris)
-

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

author maintainer
#5 lore raw
Quoted 24 lines · Neil Armstrong
Quoted 15 lines · Rob Herring

There's a few features the driver supports which we forgot to remove, so remove them now.

Cc Tomeu Vizoso <[email protected]>
Cc Boris Brezillon <[email protected]>
---
 drivers/gpu/drm/panfrost/TODO | 9 ---------
 1 file changed, 9 deletions(-)
drivers/gpu/drm/panfrost/TODO +0 -0
index c2e44add37d8..2ac972a3469c 100644

drivers/gpu/drm/panfrost/TODO line 2

Quoted 4 lines
drivers/gpu/drm/panfrost/TODO +0 -2
@@ -1,15 +1,9 @@
-- Thermal support.
-
 - Bifrost support:
   - DT bindings (Neil, WIP)

The bifrostr bindings are upstream, but not in YAML, you should move and transform this line into :

Quoted 1 line

- DT bindings in YAML schema

Already applied this. In any case, this patch was about removals. If we have updates or additions, that's a separate thing.

But I rather just get this one done than add a todo.

Rob
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel