clk: ti: dm814x: Add of_node_put() to prevent memory leak
Subsystems (2)
PATCH 1/1 clk: ti: dm814x: Add of_node_put() to prevent memory leak
In function dm814x_adpll_early_init, variable np takes the value returned by of_find_node_by_name, which gets a node but does not put it. If np is not put before return, it may cause a memory leak. Hence put np before return.
Issue found with Coccinelle.
Signed-off-by Nishka Dasgupta <[email protected]>
--- drivers/clk/ti/clk-814x.c | 1 + 1 file changed, 1 insertion(+)
drivers/clk/ti/clk-814x.c +1 -0
@@ -66,6 +66,7 @@ static int __init dm814x_adpll_early_init(void) }of_platform_populate (np,NULL ,NULL ,NULL ); +of_node_put (np);return 0 ; }
Signature · 1 line
2.19.1
Quoting Nishka Dasgupta (2019-08-04 09:33:28)
Quoted 8 lines
In function
dm814x_adpll_early_init, variable np takes the value returned byof_find_node_by_name, which gets a node but does not put it. If np is not put before return, it may cause a memory leak. Hence put np before return.
Issue found with Coccinelle.Signed-off-by Nishka Dasgupta <[email protected]>---
Applied to clk-next