Skip to contentSkip to conversation

iio: frequency: adf4371: Fix output frequency setting

PATCH Applied Nuno Sá 3 participants 3 messages Aug 5, 2019

Subsystems (2)
lore
Share & tools
lore

Nuno Sá

author maintainer
#0 lore raw

PATCH 1/1 iio: frequency: adf4371: Fix output frequency setting

The fract1 word was not being properly programmed on the device leading to wrong output frequencies.

Fixes 7f699bd14913 (iio: frequency: adf4371: Add support for ADF4371 PLL)
---
 drivers/iio/frequency/adf4371.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/iio/frequency/adf4371.c +4 -4
index e48f15cc9ab5..ff82863cbf42 100644
@@ -276,11 +276,11 @@ static int adf4371_set_freq(struct adf4371_state *st, unsigned long long freq,
 	st->buf[0] = st->integer >> 8;
 	st->buf[1] = 0x40; /* REG12 default */
 	st->buf[2] = 0x00;
-	st->buf[3] = st->fract2 & 0xFF;
-	st->buf[4] = st->fract2 >> 7;
-	st->buf[5] = st->fract2 >> 15;
+	st->buf[3] = st->fract1 & 0xFF;
+	st->buf[4] = st->fract1 >> 8;
+	st->buf[5] = st->fract1 >> 16;
 	st->buf[6] = ADF4371_FRAC2WORD_L(st->fract2 & 0x7F) |
-		     ADF4371_FRAC1WORD(st->fract1 >> 23);
+		     ADF4371_FRAC1WORD(st->fract1 >> 24);
 	st->buf[7] = ADF4371_FRAC2WORD_H(st->fract2 >> 7);
 	st->buf[8] = st->mod2 & 0xFF;
 	st->buf[9] = ADF4371_MOD2WORD(st->mod2 >> 8);
Signature · 1 line
2.22.0
Reviewed-by Stefan Popa on v1 1/1
#1 lore raw
Quoted 10 lines

The fract1 word was not being properly programmed on the device leading to wrong output frequencies.

Fixes 7f699bd14913 (iio: frequency: adf4371: Add support for ADF4371

PLL)

---
 drivers/iio/frequency/adf4371.c | 8 ++++----

 1 file changed, 4 insertions(+), 4 deletions(-)
maintainer Applied
#2 lore raw
Quoted 12 lines · Stefan Serban
Quoted 9 lines

The fract1 word was not being properly programmed on the device leading to wrong output frequencies.

Fixes 7f699bd14913 (iio: frequency: adf4371: Add support for ADF4371

PLL)

---
 drivers/iio/frequency/adf4371.c | 8 ++++----

 1 file changed, 4 insertions(+), 4 deletions(-)  

Applied to the fixes-togreg branch of iio.git and marked for stable.

Thanks,

Jonathan