aio-dio-regress: code clarification

PATCH New Andreas Gruenbacher 1 participant 1 message Aug 5, 2019

lore

Share & tools

lore

Andreas Gruenbacher

author

2019-08-05 22:49 UTC #0 lore raw

PATCH 1/1 aio-dio-regress: code clarification

In this test, FILE_SIZE is defined as 300 but that definition isn't used consistently. Make the code more obvious.

(Used by generic/210.)

Signed-off-by Andreas Gruenbacher <[email protected]>

---
 src/aio-dio-regress/aio-dio-subblock-eof-read.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

src/aio-dio-regress/aio-dio-subblock-eof-read.c +2 -2

index 6f35b0e8..894965ea 100644
@@ -63,7 +63,7 @@ main(int argc, char **argv)
 	/* <1> use normal disk read, this should be ok */
 	ret = read(fd, buffer, 4096);
 	if (ret != FILE_SIZE)
-		fail("buffered read returned %d, should be 300\n", ret);
+		fail("buffered read returned %d, should be %d\n", ret, FILE_SIZE);
 
 	/* <2> use AIO disk read, it sees error. */
 	memset(&myiocb, 0, sizeof(myiocb));

@@ -89,7 +89,7 @@ main(int argc, char **argv)
 		fail("io_getevents returned %d\n", ret);
 
 	/*
-	 *  If all goes well, we should see 300 bytes read.  If things
+	 *  If all goes well, we should see FILE_SIZE bytes read.  If things
 	 *  are broken, we may very well see a result of 4k.
 	 */
 	if (ie.res != FILE_SIZE)

Signature · 1 line

2.20.1